feat(gql) allow unsetting optional incident fields (#12801)

Author: jayacryl

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/incident/IncidentUtils.java

@@ -6,6 +6,7 @@
 import com.linkedin.common.AuditStamp;
 import com.linkedin.common.urn.Urn;
 import com.linkedin.common.urn.UrnUtils;
+import com.linkedin.data.template.SetMode;
 import com.linkedin.datahub.graphql.QueryContext;
 import com.linkedin.datahub.graphql.authorization.AuthorizationUtils;
 import com.linkedin.datahub.graphql.generated.IncidentPriority;
@@ -92,12 +93,13 @@ public static IncidentStatus mapIncidentStatus(
 
     IncidentStatus status = new IncidentStatus();
     status.setState(IncidentState.valueOf(input.getState().toString()));
-    if (input.getStage() != null) {
-      status.setStage(IncidentStage.valueOf(input.getStage().toString()));
-    }
+    status.setStage(
+        input.getStage() == null ? null : IncidentStage.valueOf(input.getStage().toString()),
+        SetMode.REMOVE_IF_NULL);
     if (input.getMessage() != null) {
       status.setMessage(input.getMessage());
     }
+    status.setLastUpdated(auditStamp);
     return status;
   }
 

datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/incident/UpdateIncidentResolver.java

@@ -12,6 +12,7 @@
 import com.linkedin.common.UrnArray;
 import com.linkedin.common.urn.Urn;
 import com.linkedin.common.urn.UrnUtils;
+import com.linkedin.data.template.SetMode;
 import com.linkedin.datahub.graphql.QueryContext;
 import com.linkedin.datahub.graphql.authorization.AuthorizationUtils;
 import com.linkedin.datahub.graphql.exception.AuthorizationException;
@@ -116,18 +117,19 @@ private void updateIncidentInfo(
     if (input.getDescription() != null) {
       info.setDescription(input.getDescription());
     }
-    if (input.getPriority() != null) {
-      info.setPriority(IncidentUtils.mapIncidentPriority(input.getPriority()));
-    }
-    if (input.getAssigneeUrns() != null) {
-      info.setAssignees(IncidentUtils.mapIncidentAssignees(input.getAssigneeUrns(), actorStamp));
-    }
     if (input.getStatus() != null) {
       info.setStatus(IncidentUtils.mapIncidentStatus(input.getStatus(), actorStamp));
     }
     if (input.getResourceUrns() != null && !input.getResourceUrns().isEmpty()) {
       info.setEntities(new UrnArray(IncidentUtils.stringsToUrns(input.getResourceUrns())));
     }
+
+    info.setPriority(
+        IncidentUtils.mapIncidentPriority(input.getPriority()), SetMode.REMOVE_IF_NULL);
+
+    info.setAssignees(
+        IncidentUtils.mapIncidentAssignees(input.getAssigneeUrns(), actorStamp),
+        SetMode.REMOVE_IF_NULL);
   }
 
   private boolean isAuthorizedToUpdateIncident(final Urn resourceUrn, final QueryContext context) {

datahub-graphql-core/src/test/java/com/linkedin/datahub/graphql/resolvers/incident/UpdateIncidentResolverTest.java

@@ -53,17 +53,7 @@ public void testGetSuccessAllFields() throws Exception {
     existingInfo.setEntities(
         new UrnArray(ImmutableList.of(UrnUtils.getUrn("urn:li:dataset:(test,test,test)"))));
     existingInfo.setStatus(
-        new IncidentStatus()
-            .setState(IncidentState.ACTIVE)
-            .setStage(IncidentStage.INVESTIGATION)
-            .setMessage("Message"));
-    existingInfo.setAssignees(
-        new IncidentAssigneeArray(
-            ImmutableList.of(
-                new IncidentAssignee()
-                    .setActor(UrnUtils.getUrn("urn:li:corpuser:test"))
-                    .setAssignedAt(new AuditStamp()))));
-    existingInfo.setPriority(0);
+        new IncidentStatus().setState(IncidentState.ACTIVE).setMessage("Message"));
     existingInfo.setSource(new IncidentSource().setType(IncidentSourceType.MANUAL));
 
     EntityService mockEntityService = Mockito.mock(EntityService.class);
@@ -198,17 +188,7 @@ public void testGetSuccessRequiredFields() throws Exception {
     expectedInfo.setEntities(
         new UrnArray(ImmutableList.of(UrnUtils.getUrn("urn:li:dataset:(test,test,test)"))));
     expectedInfo.setStatus(
-        new IncidentStatus()
-            .setState(IncidentState.ACTIVE)
-            .setStage(IncidentStage.INVESTIGATION)
-            .setMessage("Message"));
-    expectedInfo.setAssignees(
-        new IncidentAssigneeArray(
-            ImmutableList.of(
-                new IncidentAssignee()
-                    .setActor(UrnUtils.getUrn("urn:li:corpuser:test"))
-                    .setAssignedAt(new AuditStamp()))));
-    expectedInfo.setPriority(0);
+        new IncidentStatus().setState(IncidentState.ACTIVE).setMessage("Message"));
     expectedInfo.setSource(new IncidentSource().setType(IncidentSourceType.MANUAL));
 
     // Verify entity client