pr feedback

Author: asikowitz

metadata-ingestion/src/datahub/ingestion/source/looker/looker_usage.py

@@ -42,6 +42,7 @@
     TimeWindowSizeClass,
     _Aspect as AspectAbstract,
 )
+from datahub.utilities.lossy_collections import LossySet
 
 logger = logging.getLogger(__name__)
 
@@ -225,9 +226,8 @@ def get_id(self, looker_object: ModelForUsage) -> str:
     def get_id_from_row(self, row: dict) -> str:
         pass
 
-    @property
     @abstractmethod
-    def SKIPPED_REPORT_KEY(self) -> str:
+    def report_skip_set(self) -> LossySet[str]:
         pass
 
     def create_mcp(
@@ -402,13 +402,10 @@ def generate_usage_stat_mcps(self) -> Iterable[MetadataChangeProposalWrapper]:
             if object_id in self.id_to_model:
                 yield self.create_mcp(self.id_to_model[object_id], aspect)
             else:
-                skipped_set = getattr(self.report, self.SKIPPED_REPORT_KEY)
-                skipped_set.add(object_id)
+                self.report_skip_set().add(object_id)
 
 
 class DashboardStatGenerator(BaseStatGenerator):
-    SKIPPED_REPORT_KEY = "dashboards_skipped_for_usage"
-
     def __init__(
         self,
         config: StatGeneratorConfig,
@@ -428,6 +425,9 @@ def __init__(
     def get_stats_generator_name(self) -> str:
         return "DashboardStats"
 
+    def report_skip_set(self) -> LossySet[str]:
+        return self.report.dashboards_skipped_for_usage
+
     def get_filter(self) -> Dict[ViewField, str]:
         return {
             HistoryViewField.HISTORY_DASHBOARD_ID: ",".join(
@@ -525,8 +525,6 @@ def append_user_stat(
 
 
 class LookStatGenerator(BaseStatGenerator):
-    SKIPPED_REPORT_KEY = "charts_skipped_for_usage"
-
     def __init__(
         self,
         config: StatGeneratorConfig,
@@ -546,6 +544,9 @@ def __init__(
     def get_stats_generator_name(self) -> str:
         return "ChartStats"
 
+    def report_skip_set(self) -> LossySet[str]:
+        return self.report.charts_skipped_for_usage
+
     def get_filter(self) -> Dict[ViewField, str]:
         return {
             LookViewField.LOOK_ID: ",".join(

metadata-ingestion/tests/integration/looker/looker_mces_usage_history.json

@@ -581,7 +581,10 @@
                 {
                     "com.linkedin.pegasus2avro.dataset.DatasetProperties": {
                         "customProperties": {
+                            "project": "lkml_samples",
+                            "model": "look_data",
                             "looker.explore.label": "My Explore View",
+                            "looker.explore.name": "look_view",
                             "looker.explore.file": "test_source_file.lkml"
                         },
                         "externalUrl": "https://looker.company.com/explore/look_data/look_view",