Skip to content

Commit b31d0f6

Browse files
committed
fix comment
1 parent a8d7980 commit b31d0f6

File tree

2 files changed

+12
-11
lines changed

2 files changed

+12
-11
lines changed

metadata-ingestion/src/datahub/ingestion/source/vertexai.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def get_report(self) -> SourceReport:
143143

144144
def get_workunits_internal(self) -> Iterable[MetadataWorkUnit]:
145145
"""
146-
Main Function to fetch and yields work units for various VertexAI resources.
146+
Main Function to fetch and yields mcps for various VertexAI resources.
147147
- Models and Model Versions from the Model Registry
148148
- Training Jobs
149149
"""
@@ -165,15 +165,15 @@ def _gen_project_workunits(self) -> Iterable[MetadataWorkUnit]:
165165

166166
def _get_ml_models_mcps(self) -> Iterable[MetadataChangeProposalWrapper]:
167167
"""
168-
Fetch List of Models in Model Registry and generate a corresponding work unit.
168+
Fetch List of Models in Model Registry and generate a corresponding mcp.
169169
"""
170170
registered_models = self.client.Model.list()
171171
for model in registered_models:
172-
# create work unit for Model Group (= Model in VertexAI)
172+
# create mcp for Model Group (= Model in VertexAI)
173173
yield from self._gen_ml_group_mcps(model)
174174
model_versions = model.versioning_registry.list_versions()
175175
for model_version in model_versions:
176-
# create work unit for Model (= Model Version in VertexAI)
176+
# create mcp for Model (= Model Version in VertexAI)
177177
logger.info(
178178
f"Ingesting a model (name: {model.display_name} id:{model.name})"
179179
)
@@ -183,11 +183,11 @@ def _get_ml_models_mcps(self) -> Iterable[MetadataChangeProposalWrapper]:
183183

184184
def _get_training_jobs_mcps(self) -> Iterable[MetadataChangeProposalWrapper]:
185185
"""
186-
Fetches training jobs from Vertex AI and generates corresponding work units.
186+
Fetches training jobs from Vertex AI and generates corresponding mcps.
187187
This method retrieves various types of training jobs from Vertex AI, including
188188
CustomJob, CustomTrainingJob, CustomContainerTrainingJob, CustomPythonPackageTrainingJob,
189189
AutoMLTabularTrainingJob, AutoMLTextTrainingJob, AutoMLImageTrainingJob, AutoMLVideoTrainingJob,
190-
and AutoMLForecastingTrainingJob. For each job, it generates work units containing metadata
190+
and AutoMLForecastingTrainingJob. For each job, it generates mcps containing metadata
191191
about the job, its inputs, and its outputs.
192192
"""
193193
class_names = [
@@ -235,7 +235,7 @@ def _gen_training_job_mcps(
235235
self, job_meta: TrainingJobMetadata
236236
) -> Iterable[MetadataChangeProposalWrapper]:
237237
"""
238-
Generate a work unit for VertexAI Training Job
238+
Generate a mcp for VertexAI Training Job
239239
"""
240240
job = job_meta.job
241241
job_id = self._make_vertexai_job_name(entity_id=job.name)
@@ -293,7 +293,7 @@ def _gen_ml_group_mcps(
293293
model: Model,
294294
) -> Iterable[MetadataChangeProposalWrapper]:
295295
"""
296-
Generate an MLModelGroup work unit for a VertexAI Model.
296+
Generate an MLModelGroup mcp for a VertexAI Model.
297297
"""
298298
ml_model_group_urn = self._make_ml_model_group_urn(model)
299299

@@ -518,7 +518,7 @@ def _gen_ml_model_endpoint_mcps(
518518
training_job_urn: Optional[str] = None,
519519
) -> Iterable[MetadataChangeProposalWrapper]:
520520
"""
521-
Generate an MLModel and Endpoint work unit for an VertexAI Model Version.
521+
Generate an MLModel and Endpoint mcp for an VertexAI Model Version.
522522
"""
523523

524524
endpoint: Optional[Endpoint] = self._search_endpoint(model)
@@ -539,11 +539,11 @@ def _gen_ml_model_mcps(
539539
endpoint_urn: Optional[str] = None,
540540
) -> Iterable[MetadataChangeProposalWrapper]:
541541
"""
542-
Generate an MLModel workunit for an VertexAI Model Version.
542+
Generate an MLModel mcp for an VertexAI Model Version.
543543
Every Model Version is a DataHub MLModel entity associated with an MLModelGroup
544544
corresponding to a registered Model in VertexAI Model Registry.
545545
"""
546-
logging.info(f"starting model work unit for model {model.name}")
546+
logging.info(f"generating model mcp for {model.name}")
547547

548548
model_group_urn = self._make_ml_model_group_urn(model)
549549
model_name = self._make_vertexai_model_name(entity_id=model.name)

metadata-ingestion/tests/unit/test_vertexai_source.py

+1
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ def test_get_endpoint_mcps(
193193
elif isinstance(aspect, SubTypesClass):
194194
assert aspect.typeNames == ["Endpoint"]
195195

196+
196197
def test_get_training_jobs_mcps(
197198
source: VertexAISource,
198199
) -> None:

0 commit comments

Comments
 (0)