Skip to content

Commit b76a237

Browse files
committed
adding subtupes for openapi
1 parent eb17f80 commit b76a237

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

metadata-ingestion/src/datahub/ingestion/source/common/subtypes.py

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ class DatasetSubTypes(StrEnum):
2525
NEO4J_NODE = "Neo4j Node"
2626
NEO4J_RELATIONSHIP = "Neo4j Relationship"
2727
SNOWFLAKE_STREAM = "Snowflake Stream"
28+
API_ENDPOINT = "API Endpoint"
2829

2930
# TODO: Create separate entity...
3031
NOTEBOOK = "Notebook"

metadata-ingestion/src/datahub/ingestion/source/identity/okta.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
from typing import Dict, Iterable, List, Optional, Set, Union
99

1010
import nest_asyncio
11-
from okta.client import Client as OktaClient
12-
from okta.exceptions import OktaAPIException
13-
from okta.models import Group, GroupProfile, User, UserProfile, UserStatus
1411
from pydantic import validator
1512
from pydantic.fields import Field
1613

@@ -50,6 +47,9 @@
5047
StatusClass,
5148
)
5249
from datahub.utilities.lossy_collections import LossyList
50+
from okta.client import Client as OktaClient
51+
from okta.exceptions import OktaAPIException
52+
from okta.models import Group, GroupProfile, User, UserProfile, UserStatus
5353

5454
logger = logging.getLogger(__name__)
5555
nest_asyncio.apply()

metadata-ingestion/src/datahub/ingestion/source/openapi.py

+6
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
)
2121
from datahub.ingestion.api.source import Source, SourceReport
2222
from datahub.ingestion.api.workunit import MetadataWorkUnit
23+
from datahub.ingestion.source.common.subtypes import DatasetSubTypes
2324
from datahub.ingestion.source.openapi_parser import (
2425
clean_url,
2526
compose_url_attr,
@@ -40,6 +41,7 @@
4041
GlobalTagsClass,
4142
InstitutionalMemoryClass,
4243
InstitutionalMemoryMetadataClass,
44+
SubTypesClass,
4345
TagAssociationClass,
4446
)
4547

@@ -262,6 +264,10 @@ def init_dataset(
262264
inst_memory = InstitutionalMemoryClass([link_metadata])
263265
dataset_snapshot.aspects.append(inst_memory)
264266

267+
# Add API endpoint subtype
268+
sub_types = SubTypesClass(typeNames=[DatasetSubTypes.API_ENDPOINT])
269+
dataset_snapshot.aspects.append(sub_types)
270+
265271
return dataset_snapshot, dataset_name
266272

267273
def build_wu(

metadata-ingestion/tests/integration/okta/test_okta.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
import jsonpickle
77
import pytest
88
from freezegun import freeze_time
9-
from okta.models import Group, User
109

1110
from datahub.ingestion.run.pipeline import Pipeline
1211
from datahub.ingestion.source.identity.okta import OktaConfig
12+
from okta.models import Group, User
1313
from tests.test_helpers import mce_helpers
1414
from tests.test_helpers.state_helpers import (
1515
get_current_checkpoint_from_pipeline,

0 commit comments

Comments
 (0)