Skip to content

Commit c409a83

Browse files
committed
address review comment
1 parent eec37e9 commit c409a83

File tree

1 file changed

+3
-3
lines changed
  • metadata-ingestion/src/datahub/ingestion/source/tableau

1 file changed

+3
-3
lines changed

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
DatasetSourceConfigMixin,
5050
)
5151
from datahub.configuration.validate_field_deprecation import pydantic_field_deprecated
52+
from datahub.configuration.validate_field_removal import pydantic_removed_field
5253
from datahub.emitter.mcp import MetadataChangeProposalWrapper
5354
from datahub.emitter.mcp_builder import (
5455
ContainerKey,
@@ -382,7 +383,7 @@ class TableauConfig(
382383

383384
fetch_size: int = Field(
384385
default=250,
385-
description="[deprecated] Use page_size instead. Specifies the number of records to retrieve in each batch during a query execution.",
386+
description="[removed] The 'fetch_size' field is no longer used. Please use 'page_size' instead.",
386387
hidden_from_docs=True,
387388
)
388389

@@ -500,9 +501,8 @@ class TableauConfig(
500501
"This can only be used with ingest_tags enabled as it will overwrite tags entered from the UI.",
501502
)
502503

503-
_fetch_size = pydantic_field_deprecated(
504+
_fetch_size = pydantic_removed_field(
504505
"fetch_size",
505-
message="fetch_size is deprecated, use page_size instead",
506506
)
507507

508508
# pre = True because we want to take some decision before pydantic initialize the configuration to default values

0 commit comments

Comments
 (0)