Skip to content

Commit c6922cf

Browse files
committed
address review comments
1 parent e4a8d8c commit c6922cf

File tree

1 file changed

+14
-7
lines changed
  • metadata-ingestion/src/datahub/ingestion/source/tableau

1 file changed

+14
-7
lines changed

metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py

+14-7
Original file line numberDiff line numberDiff line change
@@ -908,21 +908,28 @@ def _is_allowed_project(self, project: TableauProject) -> bool:
908908
return is_allowed
909909

910910
def _is_denied_project(self, project: TableauProject) -> bool:
911-
# Either project_pattern or project_path_pattern is set
912-
deny_patterns: List[str] = self.config.project_pattern.deny
913-
deny_patterns.extend(self.config.project_path_pattern.deny)
911+
# Either project_pattern or project_path_pattern is set in a recipe
912+
# TableauConfig.projects_backward_compatibility ensures that at least one of these properties is configured.
914913

915-
for deny_pattern in deny_patterns:
916-
# Either name or project path is denied
914+
# for backward compatibility check deny list of project_pattern
915+
for deny_pattern in self.config.project_pattern.deny:
917916
if re.match(
918917
deny_pattern, project.name, self.config.project_pattern.regex_flags
919-
) or re.match(
918+
):
919+
return True
920+
921+
for deny_pattern in self.config.project_path_pattern.deny:
922+
if re.match(
920923
deny_pattern,
921924
self._get_project_path(project),
922925
self.config.project_pattern.regex_flags,
923926
):
924927
return True
925-
logger.info(f"project({project.name}) is not denied as per project_pattern")
928+
929+
logger.info(
930+
f"project({project.name}) is not denied as per project_pattern(or project_path_pattern)"
931+
)
932+
926933
return False
927934

928935
def _init_tableau_project_registry(self, all_project_map: dict) -> None:

0 commit comments

Comments
 (0)