Skip to content

Commit ccc4956

Browse files
committed
Modify experiment run logic
1 parent 3347258 commit ccc4956

File tree

1 file changed

+36
-30
lines changed
  • metadata-ingestion/src/datahub/ingestion/source

1 file changed

+36
-30
lines changed

metadata-ingestion/src/datahub/ingestion/source/vertexai.py

+36-30
Original file line numberDiff line numberDiff line change
@@ -274,18 +274,22 @@ def _gen_experiment_run_mcps(
274274
yield from MetadataChangeProposalWrapper.construct_many(
275275
entityUrn=str(run_urn),
276276
aspects=[
277-
DataProcessInstancePropertiesClass(
278-
name=run.name,
279-
created=AuditStampClass(
280-
time=created_time
281-
if created_time
282-
else datetime_to_ts_millis(datetime.now()),
283-
actor=created_actor,
284-
),
285-
externalUrl=self._make_experiment_run_external_url(experiment, run),
286-
customProperties=self._make_custom_properties_for_run(
287-
experiment, run
288-
),
277+
(
278+
DataProcessInstancePropertiesClass(
279+
name=run.name,
280+
created=AuditStampClass(
281+
time=created_time,
282+
actor=created_actor,
283+
),
284+
externalUrl=self._make_experiment_run_external_url(
285+
experiment, run
286+
),
287+
customProperties=self._make_custom_properties_for_run(
288+
experiment, run
289+
),
290+
)
291+
if created_time
292+
else None
289293
),
290294
ContainerClass(container=experiment_key.as_urn()),
291295
MLTrainingRunPropertiesClass(
@@ -296,24 +300,26 @@ def _gen_experiment_run_mcps(
296300
),
297301
DataPlatformInstanceClass(platform=str(DataPlatformUrn(self.platform))),
298302
SubTypesClass(typeNames=[MLAssetSubTypes.VERTEX_EXPERIMENT_RUN]),
299-
DataProcessInstanceRunEventClass(
300-
status=DataProcessRunStatusClass.STARTED,
301-
timestampMillis=created_time,
302-
result=DataProcessInstanceRunResultClass(
303-
type=self._get_run_result_status(run.get_state()),
304-
nativeResultType=self.platform,
305-
),
306-
durationMillis=duration,
307-
)
308-
if isinstance(run_result_type, RunResultTypeClass)
309-
and created_time is not None
310-
else None,
311-
DataProcessInstanceOutputClass(
312-
outputs=[],
313-
outputEdges=[
314-
EdgeClass(destinationUrn=experiment_key.as_urn()),
315-
],
303+
(
304+
DataProcessInstanceRunEventClass(
305+
status=DataProcessRunStatusClass.STARTED,
306+
timestampMillis=created_time,
307+
result=DataProcessInstanceRunResultClass(
308+
type=self._get_run_result_status(run.get_state()),
309+
nativeResultType=self.platform,
310+
),
311+
durationMillis=duration,
312+
)
313+
if isinstance(run_result_type, RunResultTypeClass)
314+
and created_time is not None
315+
else None
316316
),
317+
# DataProcessInstanceOutputClass(
318+
# outputs=[],
319+
# outputEdges=[
320+
# EdgeClass(destinationUrn=experiment_key.as_urn()),
321+
# ],
322+
# ),
317323
],
318324
)
319325

@@ -625,7 +631,7 @@ def _get_input_dataset_mcps(
625631
ContainerClass(container=self._get_project_container().as_urn()),
626632
DataPlatformInstanceClass(
627633
platform=str(DataPlatformUrn(self.platform))
628-
)
634+
),
629635
],
630636
)
631637

0 commit comments

Comments
 (0)