Skip to content

Commit cf32dc1

Browse files
John JoyceJohn Joyce
John Joyce
authored and
John Joyce
committed
Adding comments
1 parent c9ad9f9 commit cf32dc1

9 files changed

+39
-41
lines changed

metadata-ingestion/examples/library/dataset_add_custom_properties_patch.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.specific.dataset import DatasetPatchBuilder
44

55
# Create DataHub Client
6-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
6+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
77

88
# Create Dataset URN
99
dataset_urn = make_dataset_urn(platform="hive", name="fct_users_created", env="PROD")
@@ -16,4 +16,4 @@
1616

1717
# Emit Dataset Patch
1818
for patch_mcp in patch_mcps:
19-
rest_emitter.emit(patch_mcp)
19+
datahub_client.emit(patch_mcp)
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
1+
from datahub.emitter.mce_builder import make_dataset_urn, make_term_urn
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.metadata.schema_classes import GlossaryTermAssociationClass
44
from datahub.specific.dataset import DatasetPatchBuilder
55

66
# Create DataHub Client
7-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
7+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
88

99
# Create Dataset URN
1010
dataset_urn = make_dataset_urn(
@@ -13,12 +13,10 @@
1313

1414
# Create Dataset Patch to Add + Remove Term for 'profile_id' column
1515
patch_builder = DatasetPatchBuilder(dataset_urn)
16-
patch_builder.add_term(
17-
GlossaryTermAssociationClass("urn:li:glossaryTerm:term-to-add-id")
18-
)
19-
patch_builder.remove_term("urn:li:glossaryTerm:term-to-remove-id")
16+
patch_builder.add_term(GlossaryTermAssociationClass(make_term_urn("term-to-add-id")))
17+
patch_builder.remove_term(make_term_urn("term-to-remove-id"))
2018
patch_mcps = patch_builder.build()
2119

2220
# Emit Dataset Patch
2321
for patch_mcp in patch_mcps:
24-
rest_emitter.emit(patch_mcp)
22+
datahub_client.emit(patch_mcp)
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
1+
from datahub.emitter.mce_builder import make_dataset_urn, make_group_urn, make_user_urn
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.metadata.schema_classes import OwnerClass, OwnershipTypeClass
44
from datahub.specific.dataset import DatasetPatchBuilder
55

66
# Create DataHub Client
7-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
7+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
88

99
# Create Dataset URN
1010
dataset_urn = make_dataset_urn(
@@ -14,11 +14,11 @@
1414
# Create Dataset Patch to Add + Remove Owners
1515
patch_builder = DatasetPatchBuilder(dataset_urn)
1616
patch_builder.add_owner(
17-
OwnerClass("urn:li:corpuser:user-to-add-id", OwnershipTypeClass.TECHNICAL_OWNER)
17+
OwnerClass(make_user_urn("user-to-add-id"), OwnershipTypeClass.TECHNICAL_OWNER)
1818
)
19-
patch_builder.remove_owner("urn:li:corpGroup:group-to-remove-id")
19+
patch_builder.remove_owner(make_group_urn("group-to-remove-id"))
2020
patch_mcps = patch_builder.build()
2121

2222
# Emit Dataset Patch
2323
for patch_mcp in patch_mcps:
24-
rest_emitter.emit(patch_mcp)
24+
datahub_client.emit(patch_mcp)

metadata-ingestion/examples/library/dataset_add_remove_custom_properties_patch.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.specific.dataset import DatasetPatchBuilder
44

55
# Create DataHub Client
6-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
6+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
77

88
# Create Dataset URN
99
dataset_urn = make_dataset_urn(platform="hive", name="fct_users_created", env="PROD")
@@ -16,4 +16,4 @@
1616

1717
# Emit Dataset Patch
1818
for patch_mcp in patch_mcps:
19-
rest_emitter.emit(patch_mcp)
19+
datahub_client.emit(patch_mcp)

metadata-ingestion/examples/library/dataset_add_structured_properties_patch.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.specific.dataset import DatasetPatchBuilder
44

55
# Create DataHub Client
6-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
6+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
77

88
# Create Dataset URN
99
dataset_urn = make_dataset_urn(platform="hive", name="fct_users_created", env="PROD")
@@ -20,4 +20,4 @@
2020

2121
# Emit Dataset Patch
2222
for patch_mcp in patch_mcps:
23-
rest_emitter.emit(patch_mcp)
23+
datahub_client.emit(patch_mcp)
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
1+
from datahub.emitter.mce_builder import make_dataset_urn, make_tag_urn
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.metadata.schema_classes import TagAssociationClass
44
from datahub.specific.dataset import DatasetPatchBuilder
55

66
# Create DataHub Client
7-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
7+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
88

99
# Create Dataset URN
1010
dataset_urn = make_dataset_urn(
@@ -13,10 +13,10 @@
1313

1414
# Create Dataset Patch
1515
patch_builder = DatasetPatchBuilder(dataset_urn)
16-
patch_builder.add_tag(TagAssociationClass("urn:li:tag:tag-to-add-id"))
16+
patch_builder.add_tag(TagAssociationClass(make_tag_urn("tag-to-add-id")))
1717
patch_builder.remove_tag("urn:li:tag:tag-to-remove-id")
1818
patch_mcps = patch_builder.build()
1919

2020
# Emit Dataset Patch
2121
for patch_mcp in patch_mcps:
22-
rest_emitter.emit(patch_mcp)
22+
datahub_client.emit(patch_mcp)

metadata-ingestion/examples/library/dataset_add_upstream_lineage_patch.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from datahub.emitter.mce_builder import make_dataset_urn, make_schema_field_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.metadata.schema_classes import (
44
DatasetLineageTypeClass,
55
FineGrainedLineageClass,
@@ -9,7 +9,7 @@
99
from datahub.specific.dataset import DatasetPatchBuilder
1010

1111
# Create DataHub Client
12-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
12+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
1313

1414
# Create Dataset URN
1515
dataset_urn = make_dataset_urn(
@@ -59,4 +59,4 @@
5959

6060
# Emit Dataset Patch
6161
for patch_mcp in patch_mcps:
62-
rest_emitter.emit(patch_mcp)
62+
datahub_client.emit(patch_mcp)
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
1+
from datahub.emitter.mce_builder import make_dataset_urn, make_term_urn
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.metadata.schema_classes import GlossaryTermAssociationClass
44
from datahub.specific.dataset import DatasetPatchBuilder
55

66
# Create DataHub Client
7-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
7+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
88

99
# Create Dataset URN
1010
dataset_urn = make_dataset_urn(
@@ -14,7 +14,7 @@
1414
# Create Dataset Patch to Add + Remove Term for 'profile_id' column
1515
patch_builder = DatasetPatchBuilder(dataset_urn)
1616
patch_builder.for_field("profile_id").add_term(
17-
GlossaryTermAssociationClass("urn:li:glossaryTerm:term-to-add-id")
17+
GlossaryTermAssociationClass(make_term_urn("term-to-add-id"))
1818
)
1919
patch_builder.for_field("profile_id").remove_term(
2020
"urn:li:glossaryTerm:term-to-remove-id"
@@ -23,4 +23,4 @@
2323

2424
# Emit Dataset Patch
2525
for patch_mcp in patch_mcps:
26-
rest_emitter.emit(patch_mcp)
26+
datahub_client.emit(patch_mcp)
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from datahub.emitter.mce_builder import make_dataset_urn
2-
from datahub.emitter.rest_emitter import DataHubRestEmitter
1+
from datahub.emitter.mce_builder import make_dataset_urn, make_tag_urn
2+
from datahub.ingestion.graph.client import DataHubGraph, DataHubGraphConfig
33
from datahub.metadata.schema_classes import TagAssociationClass
44
from datahub.specific.dataset import DatasetPatchBuilder
55

66
# Create DataHub Client
7-
rest_emitter = DataHubRestEmitter(gms_server="http://localhost:8080")
7+
datahub_client = DataHubGraph(DataHubGraphConfig(server="http://localhost:8080"))
88

99
# Create Dataset URN
1010
dataset_urn = make_dataset_urn(
@@ -14,11 +14,11 @@
1414
# Create Dataset Patch to Add + Remove Tag for 'profile_id' column
1515
patch_builder = DatasetPatchBuilder(dataset_urn)
1616
patch_builder.for_field("profile_id").add_tag(
17-
TagAssociationClass("urn:li:tag:tag-to-add-id")
17+
TagAssociationClass(make_tag_urn("tag-to-add-id"))
1818
)
1919
patch_builder.for_field("profile_id").remove_tag("urn:li:tag:tag-to-remove-id")
2020
patch_mcps = patch_builder.build()
2121

2222
# Emit Dataset Patch
2323
for patch_mcp in patch_mcps:
24-
rest_emitter.emit(patch_mcp)
24+
datahub_client.emit(patch_mcp)

0 commit comments

Comments
 (0)