Skip to content

Commit d3a9208

Browse files
feat(glossary) removed debugging statements, fixed pipeline
1 parent 629b6bf commit d3a9208

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

metadata-ingestion/src/datahub/ingestion/source/metadata/business_glossary.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -161,19 +161,21 @@ def get_owners_multiple_types(owners: OwnersMultipleTypes) -> models.OwnershipCl
161161
if isinstance(owners, Owners):
162162
return models.OwnershipClass(owners=list(get_owners(owners)))
163163

164-
owners_meta = []
164+
owners_meta: List[models.OwnerClass]
165165
for owner in owners:
166166
owners_meta.extend(get_owners(owner))
167167

168168
return models.OwnershipClass(owners=owners_meta)
169169

170170

171171
def get_owners(owners: Owners) -> Iterable[models.OwnerClass]:
172-
if owners.type.startswith("urn:li:ownershipType:"):
172+
if owners.type and owners.type.startswith("urn:li:ownershipType:"):
173173
ownership_type = "CUSTOM"
174174
ownership_type_urn = owners.type
175175
else:
176-
ownership_type, ownership_type_urn = validate_ownership_type(owners.type)
176+
ownership_type, ownership_type_urn = validate_ownership_type(
177+
owners.type or models.OwnershipTypeClass.DEVELOPER
178+
)
177179

178180
if owners.typeUrn is not None:
179181
ownership_type_urn = owners.typeUrn

metadata-ingestion/tests/integration/business-glossary/test_business_glossary.py

-2
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ def test_single_owner_types(
8080
mock_time,
8181
):
8282
"""Test basic single owner cases with different ownership types"""
83-
output_mces_path: str = f"{tmp_path}/single_owner_types.json"
84-
print(f"\nOutput file location: {output_mces_path}")
8583
test_resources_dir = pytestconfig.rootpath / "tests/integration/business-glossary"
8684
output_mces_path: str = f"{tmp_path}/single_owner_types.json"
8785
golden_mces_path: str = f"{test_resources_dir}/single_owner_types_golden.json"

0 commit comments

Comments
 (0)