Skip to content

Commit ea4a9b2

Browse files
chriscollins3456chriscollins3456
authored
feat(forms) Extend forms support to other entity types (#9801)
1 parent e0276cf commit ea4a9b2

File tree

71 files changed

+717
-537
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+717
-537
lines changed

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/chart/ChartType.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ public class ChartType
8282
DATA_PRODUCTS_ASPECT_NAME,
8383
BROWSE_PATHS_V2_ASPECT_NAME,
8484
SUB_TYPES_ASPECT_NAME,
85-
STRUCTURED_PROPERTIES_ASPECT_NAME);
85+
STRUCTURED_PROPERTIES_ASPECT_NAME,
86+
FORMS_ASPECT_NAME);
8687
private static final Set<String> FACET_FIELDS =
8788
ImmutableSet.of("access", "queryType", "tool", "type");
8889

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/chart/mappers/ChartMapper.java

+6
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import com.linkedin.common.DataPlatformInstance;
88
import com.linkedin.common.Deprecation;
99
import com.linkedin.common.Embed;
10+
import com.linkedin.common.Forms;
1011
import com.linkedin.common.GlobalTags;
1112
import com.linkedin.common.GlossaryTerms;
1213
import com.linkedin.common.InputFields;
@@ -41,6 +42,7 @@
4142
import com.linkedin.datahub.graphql.types.common.mappers.util.MappingHelper;
4243
import com.linkedin.datahub.graphql.types.common.mappers.util.SystemMetadataUtils;
4344
import com.linkedin.datahub.graphql.types.domain.DomainAssociationMapper;
45+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
4446
import com.linkedin.datahub.graphql.types.glossary.mappers.GlossaryTermsMapper;
4547
import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
4648
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
@@ -128,6 +130,10 @@ public Chart apply(@Nonnull final EntityResponse entityResponse) {
128130
((chart, dataMap) ->
129131
chart.setStructuredProperties(
130132
StructuredPropertiesMapper.map(new StructuredProperties(dataMap)))));
133+
mappingHelper.mapToResult(
134+
FORMS_ASPECT_NAME,
135+
((entity, dataMap) ->
136+
entity.setForms(FormsMapper.map(new Forms(dataMap), entityUrn.toString()))));
131137
return mappingHelper.getResult();
132138
}
133139

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/container/ContainerType.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ public class ContainerType
5252
Constants.DOMAINS_ASPECT_NAME,
5353
Constants.DEPRECATION_ASPECT_NAME,
5454
Constants.DATA_PRODUCTS_ASPECT_NAME,
55-
Constants.STRUCTURED_PROPERTIES_ASPECT_NAME);
55+
Constants.STRUCTURED_PROPERTIES_ASPECT_NAME,
56+
Constants.FORMS_ASPECT_NAME);
5657

5758
private static final Set<String> FACET_FIELDS = ImmutableSet.of("origin", "platform");
5859
private static final String ENTITY_NAME = "container";

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/container/mappers/ContainerMapper.java

+8
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import com.linkedin.common.DataPlatformInstance;
66
import com.linkedin.common.Deprecation;
7+
import com.linkedin.common.Forms;
78
import com.linkedin.common.GlobalTags;
89
import com.linkedin.common.GlossaryTerms;
910
import com.linkedin.common.InstitutionalMemory;
@@ -26,6 +27,7 @@
2627
import com.linkedin.datahub.graphql.types.common.mappers.SubTypesMapper;
2728
import com.linkedin.datahub.graphql.types.common.mappers.util.SystemMetadataUtils;
2829
import com.linkedin.datahub.graphql.types.domain.DomainAssociationMapper;
30+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
2931
import com.linkedin.datahub.graphql.types.glossary.mappers.GlossaryTermsMapper;
3032
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
3133
import com.linkedin.datahub.graphql.types.tag.mappers.GlobalTagsMapper;
@@ -148,6 +150,12 @@ public static Container map(final EntityResponse entityResponse) {
148150
new StructuredProperties(envelopedStructuredProps.getValue().data())));
149151
}
150152

153+
final EnvelopedAspect envelopedForms = aspects.get(FORMS_ASPECT_NAME);
154+
if (envelopedForms != null) {
155+
result.setForms(
156+
FormsMapper.map(new Forms(envelopedForms.getValue().data()), entityUrn.toString()));
157+
}
158+
151159
return result;
152160
}
153161

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/corpgroup/mappers/CorpGroupMapper.java

+6
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static com.linkedin.metadata.Constants.*;
44

5+
import com.linkedin.common.Forms;
56
import com.linkedin.common.Origin;
67
import com.linkedin.common.Ownership;
78
import com.linkedin.common.urn.Urn;
@@ -10,6 +11,7 @@
1011
import com.linkedin.datahub.graphql.generated.EntityType;
1112
import com.linkedin.datahub.graphql.types.common.mappers.OwnershipMapper;
1213
import com.linkedin.datahub.graphql.types.common.mappers.util.MappingHelper;
14+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
1315
import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
1416
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
1517
import com.linkedin.entity.EntityResponse;
@@ -52,6 +54,10 @@ public CorpGroup apply(@Nonnull final EntityResponse entityResponse) {
5254
((entity, dataMap) ->
5355
entity.setStructuredProperties(
5456
StructuredPropertiesMapper.map(new StructuredProperties(dataMap)))));
57+
mappingHelper.mapToResult(
58+
FORMS_ASPECT_NAME,
59+
((entity, dataMap) ->
60+
entity.setForms(FormsMapper.map(new Forms(dataMap), entityUrn.toString()))));
5561
if (aspectMap.containsKey(ORIGIN_ASPECT_NAME)) {
5662
mappingHelper.mapToResult(ORIGIN_ASPECT_NAME, this::mapEntityOriginType);
5763
} else {

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/corpuser/mappers/CorpUserMapper.java

+6
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static com.linkedin.metadata.Constants.*;
44

5+
import com.linkedin.common.Forms;
56
import com.linkedin.common.GlobalTags;
67
import com.linkedin.common.urn.Urn;
78
import com.linkedin.data.DataMap;
@@ -15,6 +16,7 @@
1516
import com.linkedin.datahub.graphql.generated.EntityType;
1617
import com.linkedin.datahub.graphql.types.common.mappers.CustomPropertiesMapper;
1718
import com.linkedin.datahub.graphql.types.common.mappers.util.MappingHelper;
19+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
1820
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
1921
import com.linkedin.datahub.graphql.types.tag.mappers.GlobalTagsMapper;
2022
import com.linkedin.entity.EntityResponse;
@@ -80,6 +82,10 @@ public CorpUser apply(
8082
((entity, dataMap) ->
8183
entity.setStructuredProperties(
8284
StructuredPropertiesMapper.map(new StructuredProperties(dataMap)))));
85+
mappingHelper.mapToResult(
86+
FORMS_ASPECT_NAME,
87+
((entity, dataMap) ->
88+
entity.setForms(FormsMapper.map(new Forms(dataMap), entityUrn.toString()))));
8389

8490
mapCorpUserSettings(
8591
result, aspectMap.getOrDefault(CORP_USER_SETTINGS_ASPECT_NAME, null), featureFlags);

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dashboard/DashboardType.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ public class DashboardType
8282
EMBED_ASPECT_NAME,
8383
DATA_PRODUCTS_ASPECT_NAME,
8484
BROWSE_PATHS_V2_ASPECT_NAME,
85-
STRUCTURED_PROPERTIES_ASPECT_NAME);
85+
STRUCTURED_PROPERTIES_ASPECT_NAME,
86+
FORMS_ASPECT_NAME);
8687
private static final Set<String> FACET_FIELDS = ImmutableSet.of("access", "tool");
8788

8889
private final EntityClient _entityClient;

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dashboard/mappers/DashboardMapper.java

+6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.linkedin.common.DataPlatformInstance;
77
import com.linkedin.common.Deprecation;
88
import com.linkedin.common.Embed;
9+
import com.linkedin.common.Forms;
910
import com.linkedin.common.GlobalTags;
1011
import com.linkedin.common.GlossaryTerms;
1112
import com.linkedin.common.InputFields;
@@ -39,6 +40,7 @@
3940
import com.linkedin.datahub.graphql.types.common.mappers.util.MappingHelper;
4041
import com.linkedin.datahub.graphql.types.common.mappers.util.SystemMetadataUtils;
4142
import com.linkedin.datahub.graphql.types.domain.DomainAssociationMapper;
43+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
4244
import com.linkedin.datahub.graphql.types.glossary.mappers.GlossaryTermsMapper;
4345
import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
4446
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
@@ -129,6 +131,10 @@ public Dashboard apply(@Nonnull final EntityResponse entityResponse) {
129131
((dashboard, dataMap) ->
130132
dashboard.setStructuredProperties(
131133
StructuredPropertiesMapper.map(new StructuredProperties(dataMap)))));
134+
mappingHelper.mapToResult(
135+
FORMS_ASPECT_NAME,
136+
((entity, dataMap) ->
137+
entity.setForms(FormsMapper.map(new Forms(dataMap), entityUrn.toString()))));
132138
return mappingHelper.getResult();
133139
}
134140

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataflow/DataFlowType.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ public class DataFlowType
7777
DATA_PLATFORM_INSTANCE_ASPECT_NAME,
7878
DATA_PRODUCTS_ASPECT_NAME,
7979
BROWSE_PATHS_V2_ASPECT_NAME,
80-
STRUCTURED_PROPERTIES_ASPECT_NAME);
80+
STRUCTURED_PROPERTIES_ASPECT_NAME,
81+
FORMS_ASPECT_NAME);
8182
private static final Set<String> FACET_FIELDS = ImmutableSet.of("orchestrator", "cluster");
8283
private final EntityClient _entityClient;
8384

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataflow/mappers/DataFlowMapper.java

+6
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import com.linkedin.common.BrowsePathsV2;
66
import com.linkedin.common.DataPlatformInstance;
77
import com.linkedin.common.Deprecation;
8+
import com.linkedin.common.Forms;
89
import com.linkedin.common.GlobalTags;
910
import com.linkedin.common.GlossaryTerms;
1011
import com.linkedin.common.InstitutionalMemory;
@@ -28,6 +29,7 @@
2829
import com.linkedin.datahub.graphql.types.common.mappers.util.MappingHelper;
2930
import com.linkedin.datahub.graphql.types.common.mappers.util.SystemMetadataUtils;
3031
import com.linkedin.datahub.graphql.types.domain.DomainAssociationMapper;
32+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
3133
import com.linkedin.datahub.graphql.types.glossary.mappers.GlossaryTermsMapper;
3234
import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
3335
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
@@ -106,6 +108,10 @@ public DataFlow apply(@Nonnull final EntityResponse entityResponse) {
106108
((entity, dataMap) ->
107109
entity.setStructuredProperties(
108110
StructuredPropertiesMapper.map(new StructuredProperties(dataMap)))));
111+
mappingHelper.mapToResult(
112+
FORMS_ASPECT_NAME,
113+
((entity, dataMap) ->
114+
entity.setForms(FormsMapper.map(new Forms(dataMap), entityUrn.toString()))));
109115

110116
return mappingHelper.getResult();
111117
}

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/datajob/DataJobType.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ public class DataJobType
7979
DATA_PRODUCTS_ASPECT_NAME,
8080
BROWSE_PATHS_V2_ASPECT_NAME,
8181
SUB_TYPES_ASPECT_NAME,
82-
STRUCTURED_PROPERTIES_ASPECT_NAME);
82+
STRUCTURED_PROPERTIES_ASPECT_NAME,
83+
FORMS_ASPECT_NAME);
8384
private static final Set<String> FACET_FIELDS = ImmutableSet.of("flow");
8485
private final EntityClient _entityClient;
8586

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/datajob/mappers/DataJobMapper.java

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.linkedin.common.BrowsePathsV2;
77
import com.linkedin.common.DataPlatformInstance;
88
import com.linkedin.common.Deprecation;
9+
import com.linkedin.common.Forms;
910
import com.linkedin.common.GlobalTags;
1011
import com.linkedin.common.GlossaryTerms;
1112
import com.linkedin.common.InstitutionalMemory;
@@ -33,6 +34,7 @@
3334
import com.linkedin.datahub.graphql.types.common.mappers.SubTypesMapper;
3435
import com.linkedin.datahub.graphql.types.common.mappers.util.SystemMetadataUtils;
3536
import com.linkedin.datahub.graphql.types.domain.DomainAssociationMapper;
37+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
3638
import com.linkedin.datahub.graphql.types.glossary.mappers.GlossaryTermsMapper;
3739
import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
3840
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
@@ -124,6 +126,8 @@ public DataJob apply(@Nonnull final EntityResponse entityResponse) {
124126
} else if (STRUCTURED_PROPERTIES_ASPECT_NAME.equals(name)) {
125127
result.setStructuredProperties(
126128
StructuredPropertiesMapper.map(new StructuredProperties(data)));
129+
} else if (FORMS_ASPECT_NAME.equals(name)) {
130+
result.setForms(FormsMapper.map(new Forms(data), entityUrn.toString()));
127131
}
128132
});
129133

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataproduct/DataProductType.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static com.linkedin.metadata.Constants.DATA_PRODUCT_ENTITY_NAME;
44
import static com.linkedin.metadata.Constants.DATA_PRODUCT_PROPERTIES_ASPECT_NAME;
55
import static com.linkedin.metadata.Constants.DOMAINS_ASPECT_NAME;
6+
import static com.linkedin.metadata.Constants.FORMS_ASPECT_NAME;
67
import static com.linkedin.metadata.Constants.GLOBAL_TAGS_ASPECT_NAME;
78
import static com.linkedin.metadata.Constants.GLOSSARY_TERMS_ASPECT_NAME;
89
import static com.linkedin.metadata.Constants.INSTITUTIONAL_MEMORY_ASPECT_NAME;
@@ -51,7 +52,8 @@ public class DataProductType
5152
GLOSSARY_TERMS_ASPECT_NAME,
5253
DOMAINS_ASPECT_NAME,
5354
INSTITUTIONAL_MEMORY_ASPECT_NAME,
54-
STRUCTURED_PROPERTIES_ASPECT_NAME);
55+
STRUCTURED_PROPERTIES_ASPECT_NAME,
56+
FORMS_ASPECT_NAME);
5557
private final EntityClient _entityClient;
5658

5759
@Override

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/dataproduct/mappers/DataProductMapper.java

+7
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22

33
import static com.linkedin.metadata.Constants.DATA_PRODUCT_PROPERTIES_ASPECT_NAME;
44
import static com.linkedin.metadata.Constants.DOMAINS_ASPECT_NAME;
5+
import static com.linkedin.metadata.Constants.FORMS_ASPECT_NAME;
56
import static com.linkedin.metadata.Constants.GLOBAL_TAGS_ASPECT_NAME;
67
import static com.linkedin.metadata.Constants.GLOSSARY_TERMS_ASPECT_NAME;
78
import static com.linkedin.metadata.Constants.INSTITUTIONAL_MEMORY_ASPECT_NAME;
89
import static com.linkedin.metadata.Constants.OWNERSHIP_ASPECT_NAME;
910
import static com.linkedin.metadata.Constants.STRUCTURED_PROPERTIES_ASPECT_NAME;
1011

12+
import com.linkedin.common.Forms;
1113
import com.linkedin.common.GlobalTags;
1214
import com.linkedin.common.GlossaryTerms;
1315
import com.linkedin.common.InstitutionalMemory;
@@ -22,6 +24,7 @@
2224
import com.linkedin.datahub.graphql.types.common.mappers.OwnershipMapper;
2325
import com.linkedin.datahub.graphql.types.common.mappers.util.MappingHelper;
2426
import com.linkedin.datahub.graphql.types.domain.DomainAssociationMapper;
27+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
2528
import com.linkedin.datahub.graphql.types.glossary.mappers.GlossaryTermsMapper;
2629
import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
2730
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
@@ -82,6 +85,10 @@ public DataProduct apply(@Nonnull final EntityResponse entityResponse) {
8285
((entity, dataMap) ->
8386
entity.setStructuredProperties(
8487
StructuredPropertiesMapper.map(new StructuredProperties(dataMap)))));
88+
mappingHelper.mapToResult(
89+
FORMS_ASPECT_NAME,
90+
((entity, dataMap) ->
91+
entity.setForms(FormsMapper.map(new Forms(dataMap), entityUrn.toString()))));
8592

8693
return result;
8794
}

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/domain/DomainMapper.java

+9
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,17 @@
11
package com.linkedin.datahub.graphql.types.domain;
22

3+
import static com.linkedin.metadata.Constants.FORMS_ASPECT_NAME;
34
import static com.linkedin.metadata.Constants.STRUCTURED_PROPERTIES_ASPECT_NAME;
45

6+
import com.linkedin.common.Forms;
57
import com.linkedin.common.InstitutionalMemory;
68
import com.linkedin.common.Ownership;
79
import com.linkedin.common.urn.Urn;
810
import com.linkedin.datahub.graphql.generated.Domain;
911
import com.linkedin.datahub.graphql.generated.EntityType;
1012
import com.linkedin.datahub.graphql.types.common.mappers.InstitutionalMemoryMapper;
1113
import com.linkedin.datahub.graphql.types.common.mappers.OwnershipMapper;
14+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
1215
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
1316
import com.linkedin.domain.DomainProperties;
1417
import com.linkedin.entity.EntityResponse;
@@ -64,6 +67,12 @@ public static Domain map(final EntityResponse entityResponse) {
6467
new StructuredProperties(envelopedStructuredProps.getValue().data())));
6568
}
6669

70+
final EnvelopedAspect envelopedForms = aspects.get(FORMS_ASPECT_NAME);
71+
if (envelopedForms != null) {
72+
result.setForms(
73+
FormsMapper.map(new Forms(envelopedForms.getValue().data()), entityUrn.toString()));
74+
}
75+
6776
return result;
6877
}
6978

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/domain/DomainType.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ public class DomainType
3939
Constants.DOMAIN_PROPERTIES_ASPECT_NAME,
4040
Constants.OWNERSHIP_ASPECT_NAME,
4141
Constants.INSTITUTIONAL_MEMORY_ASPECT_NAME,
42-
Constants.STRUCTURED_PROPERTIES_ASPECT_NAME);
42+
Constants.STRUCTURED_PROPERTIES_ASPECT_NAME,
43+
Constants.FORMS_ASPECT_NAME);
4344
private final EntityClient _entityClient;
4445

4546
public DomainType(final EntityClient entityClient) {

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/glossary/GlossaryNodeType.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.linkedin.datahub.graphql.types.glossary;
22

3+
import static com.linkedin.metadata.Constants.FORMS_ASPECT_NAME;
34
import static com.linkedin.metadata.Constants.GLOSSARY_NODE_ENTITY_NAME;
45
import static com.linkedin.metadata.Constants.GLOSSARY_NODE_INFO_ASPECT_NAME;
56
import static com.linkedin.metadata.Constants.GLOSSARY_NODE_KEY_ASPECT_NAME;
@@ -33,7 +34,8 @@ public class GlossaryNodeType
3334
GLOSSARY_NODE_KEY_ASPECT_NAME,
3435
GLOSSARY_NODE_INFO_ASPECT_NAME,
3536
OWNERSHIP_ASPECT_NAME,
36-
STRUCTURED_PROPERTIES_ASPECT_NAME);
37+
STRUCTURED_PROPERTIES_ASPECT_NAME,
38+
FORMS_ASPECT_NAME);
3739

3840
private final EntityClient _entityClient;
3941

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/glossary/GlossaryTermType.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ public class GlossaryTermType
5959
BROWSE_PATHS_ASPECT_NAME,
6060
DOMAINS_ASPECT_NAME,
6161
DEPRECATION_ASPECT_NAME,
62-
STRUCTURED_PROPERTIES_ASPECT_NAME);
62+
STRUCTURED_PROPERTIES_ASPECT_NAME,
63+
FORMS_ASPECT_NAME);
6364

6465
private final EntityClient _entityClient;
6566

‎datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/glossary/mappers/GlossaryNodeMapper.java

+6
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static com.linkedin.metadata.Constants.*;
44

5+
import com.linkedin.common.Forms;
56
import com.linkedin.common.Ownership;
67
import com.linkedin.common.urn.Urn;
78
import com.linkedin.data.DataMap;
@@ -11,6 +12,7 @@
1112
import com.linkedin.datahub.graphql.types.common.mappers.CustomPropertiesMapper;
1213
import com.linkedin.datahub.graphql.types.common.mappers.OwnershipMapper;
1314
import com.linkedin.datahub.graphql.types.common.mappers.util.MappingHelper;
15+
import com.linkedin.datahub.graphql.types.form.FormsMapper;
1416
import com.linkedin.datahub.graphql.types.mappers.ModelMapper;
1517
import com.linkedin.datahub.graphql.types.structuredproperty.StructuredPropertiesMapper;
1618
import com.linkedin.entity.EntityResponse;
@@ -51,6 +53,10 @@ public GlossaryNode apply(@Nonnull final EntityResponse entityResponse) {
5153
((entity, dataMap) ->
5254
entity.setStructuredProperties(
5355
StructuredPropertiesMapper.map(new StructuredProperties(dataMap)))));
56+
mappingHelper.mapToResult(
57+
FORMS_ASPECT_NAME,
58+
((entity, dataMap) ->
59+
entity.setForms(FormsMapper.map(new Forms(dataMap), entityUrn.toString()))));
5460

5561
return mappingHelper.getResult();
5662
}

0 commit comments

Comments
 (0)