enable SIM101

Author: sgomezvillamor

metadata-ingestion/pyproject.toml

@@ -43,7 +43,6 @@ extend-ignore = [
     "RUF015", # unnecessary-iterable-allocation-for-first-element
 
     # Can be enabled later if someone wants to fix existing cases or an auto-fix becomes available
-    "SIM101", # Multiple isinstance calls for {name}, merge into a single call
     "SIM102", # Use a single `if` statement instead of nested `if` statements
     "SIM103", # Return the condition directly
     "SIM105", # Use `contextlib.suppress(...)` instead of `try`-`except`-`pass`

metadata-ingestion/src/datahub/ingestion/reporting/datahub_ingestion_run_summary_provider.py

@@ -163,7 +163,7 @@ def _convert_sets_to_lists(obj: Any) -> Any:
                 key: DatahubIngestionRunSummaryProvider._convert_sets_to_lists(value)
                 for key, value in obj.items()
             }
-        elif isinstance(obj, list) or isinstance(obj, set):
+        elif isinstance(obj, (list, set)):
             return [
                 DatahubIngestionRunSummaryProvider._convert_sets_to_lists(element)
                 for element in obj

metadata-ingestion/src/datahub/lite/duckdb_lite.py

@@ -760,9 +760,7 @@ def post_update_hook(
                 entity_id=[str(data_platform_urn), data_platform_instance],
             )
             self._create_edges_from_data_platform_instance(data_platform_instance_urn)
-        elif isinstance(aspect, ChartInfoClass) or isinstance(
-            aspect, DashboardInfoClass
-        ):
+        elif isinstance(aspect, (ChartInfoClass, DashboardInfoClass)):
             urn = Urn.from_string(entity_urn)
             self.add_edge(
                 entity_urn,

metadata-ingestion/src/datahub/sdk/dataset.py

@@ -74,8 +74,8 @@
 def _parse_upstream_input(
     upstream_input: UpstreamInputType,
 ) -> Union[models.UpstreamClass, models.FineGrainedLineageClass]:
-    if isinstance(upstream_input, models.UpstreamClass) or isinstance(
-        upstream_input, models.FineGrainedLineageClass
+    if isinstance(
+        upstream_input, (models.UpstreamClass, models.FineGrainedLineageClass)
     ):
         return upstream_input
     elif isinstance(upstream_input, (str, DatasetUrn)):