Skip to content

Commit fd804ac

Browse files
committed
fix(ingest/powerbi): Update documentation
1 parent 31f030b commit fd804ac

File tree

1 file changed

+12
-1
lines changed
  • metadata-ingestion/src/datahub/ingestion/source/powerbi

1 file changed

+12
-1
lines changed

metadata-ingestion/src/datahub/ingestion/source/powerbi/config.py

+12-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from datahub.ingestion.source.state.stateful_ingestion_base import (
2323
StatefulIngestionConfigBase,
2424
)
25+
from datahub.utilities.global_warning_util import add_global_warning
2526
from datahub.utilities.lossy_collections import LossyList
2627
from datahub.utilities.perf_timer import PerfTimer
2728

@@ -390,7 +391,8 @@ class PowerBiDashboardSourceConfig(
390391
# Enable/Disable extracting dataset schema
391392
extract_dataset_schema: bool = pydantic.Field(
392393
default=True,
393-
description="Whether to ingest PBI Dataset Table columns and measures",
394+
description="Whether to ingest PBI Dataset Table columns and measures."
395+
" Note: this setting must be `true` for schema extraction and column lineage to be enabled.",
394396
)
395397
# Enable/Disable extracting lineage information of PowerBI Dataset
396398
extract_lineage: bool = pydantic.Field(
@@ -526,6 +528,7 @@ def validate_extract_column_level_lineage(cls, values: Dict) -> Dict:
526528
"native_query_parsing",
527529
"enable_advance_lineage_sql_construct",
528530
"extract_lineage",
531+
"extract_dataset_schema",
529532
]
530533

531534
if (
@@ -591,3 +594,11 @@ def raise_error_for_dataset_type_mapping(cls, values: Dict) -> Dict:
591594
)
592595

593596
return values
597+
598+
@root_validator(skip_on_failure=True)
599+
def validate_extract_dataset_schema(cls, values: Dict) -> Dict:
600+
if values.get("extract_dataset_schema") is False:
601+
add_global_warning(
602+
"Please use `extract_dataset_schema: true`, otherwise dataset schema extraction will be skipped."
603+
)
604+
return values

0 commit comments

Comments
 (0)