Create a separate credential helper trampoline #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
niik
force-pushed
the
separate-helper-trampoline
branch
from
085728e to
4d5efaf
Compare
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Co-Authored-By: Sergio Padrino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're being invoked as an askpass handler we can't read from stdin or we'll be blocked forever. But when we're invoked as a credential helper we need to read stdin. So we're creating two binaries here that essentially only differ in whether or not they read stdin.
We're also no longer forwarding the DESKTOP_IDENTIFIER environment variable, that is instead hardcoded at compile time in the two binaries.