Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate @fromparent with Revise #17

Open
disberd opened this issue Jul 11, 2023 · 0 comments · May be fixed by #56
Open

Integrate @fromparent with Revise #17

disberd opened this issue Jul 11, 2023 · 0 comments · May be fixed by #56
Labels
enhancement New feature or request

Comments

@disberd
Copy link
Owner

disberd commented Jul 11, 2023

The current implementation of @frompackage/@fromparent always reloads the full module whenever the button is pressed.

This is fine most of the time but in some cases where function with long compilation time (like those using LoopVectorization) might be redefined even though they did not change.

It would be cool to incorporate Revise and use it to reload the package as much as possible, resorting to a full module reload only upon Revise's failure (like when redefining a struct)

@disberd disberd added the enhancement New feature or request label Jul 11, 2023
@disberd disberd linked a pull request Jun 2, 2024 that will close this issue
@disberd disberd linked a pull request Jun 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant