Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet format in SDK 9.0.200 throws FileNotFoundException for .slnx solutions #47038

Open
ownerer opened this issue Feb 22, 2025 · 6 comments · May be fixed by #47508
Open

dotnet format in SDK 9.0.200 throws FileNotFoundException for .slnx solutions #47038

ownerer opened this issue Feb 22, 2025 · 6 comments · May be fixed by #47508
Assignees
@sharwell
Labels
Area-Format Area-NetSDK Feature Request
Milestone
10.0.1xx

Comments

@ownerer
Copy link

ownerer commented Feb 22, 2025

Describe the bug

dotnet format ConsoleApp1.slnx fails, throwing a FileNotFoundException

To Reproduce

  • Create any new .slnx solution, no need to write any code, just a default console app will do.
  • run dotnet format ConsoleApp1.slnx in a terminal

Exceptions (if any)

Unhandled exception: System.IO.FileNotFoundException: The file 'ConsoleApp1.slnx' does not appear to be a valid project or solution file.
   at Microsoft.CodeAnalysis.Tools.Workspaces.MSBuildWorkspaceFinder.FindFile(String workspacePath)
   at Microsoft.CodeAnalysis.Tools.Workspaces.MSBuildWorkspaceFinder.FindWorkspace(String searchDirectory, String workspacePath)
   at Microsoft.CodeAnalysis.Tools.FormatCommandCommon.ParseWorkspaceOptions(ParseResult parseResult, FormatOptions formatOptions)
   at Microsoft.CodeAnalysis.Tools.Commands.RootFormatCommand.FormatCommandDefaultHandler.InvokeAsync(ParseResult parseResult, CancellationToken cancellationToken)
   at System.CommandLine.Invocation.InvocationPipeline.InvokeAsync(ParseResult parseResult, CancellationToken cancellationToken)

An issue was also raised here, but since this is the main repo apparently I'm opening a new one.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Feb 22, 2025
@ownerer
Copy link
Author

ownerer commented Feb 28, 2025

Tagging format area owners as per the CODEOWNERS file: @sharwell @arunchndr

@arunchndr arunchndr added Feature Request Area-Format and removed untriaged Request triage from a team member labels Mar 7, 2025
@arunchndr arunchndr added this to the 10.0.1xx milestone Mar 7, 2025
@kasperk81
Copy link
Contributor

fixed in 201 #40913 (comment)

@ownerer
Copy link
Author

ownerer commented Mar 12, 2025

I'm afraid that's not the case.
Just installed 201 and I'm still seeing the same error.

@ownerer
Copy link
Author

ownerer commented Mar 12, 2025

dotnet --info output

.NET SDK:
 Version:           9.0.201
 Commit:            071aaccdc2
 Workload version:  9.0.200-manifests.a3a1a094
 MSBuild version:   17.13.13+1c2026462

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.22631
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\9.0.201\

.NET workloads installed:
 [aspire]
   Installation Source: VS 17.13.35825.156
   Manifest Version:    8.2.2/8.0.100
   Manifest Path:       C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.2.2\WorkloadManifest.json
   Install Type:              Msi

Configured to use loose manifests when installing new manifests.

Host:
  Version:      9.0.3
  Architecture: x64
  Commit:       831d23e561

.NET SDKs installed:
  6.0.428 [C:\Program Files\dotnet\sdk]
  9.0.200 [C:\Program Files\dotnet\sdk]
  9.0.201 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 6.0.36 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 8.0.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 9.0.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 9.0.3 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 6.0.36 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 8.0.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 9.0.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 9.0.3 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 6.0.36 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 8.0.13 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 9.0.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 9.0.3 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
  x86   [C:\Program Files (x86)\dotnet]
    registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

dotnet format output

Unhandled exception: System.IO.FileNotFoundException: The file 'ConsoleApp1.slnx' does not appear to be a valid project or solution file.
   at Microsoft.CodeAnalysis.Tools.Workspaces.MSBuildWorkspaceFinder.FindFile(String workspacePath)
   at Microsoft.CodeAnalysis.Tools.Workspaces.MSBuildWorkspaceFinder.FindWorkspace(String searchDirectory, String workspacePath)
   at Microsoft.CodeAnalysis.Tools.FormatCommandCommon.ParseWorkspaceOptions(ParseResult parseResult, FormatOptions formatOptions)
   at Microsoft.CodeAnalysis.Tools.Commands.RootFormatCommand.FormatCommandDefaultHandler.InvokeAsync(ParseResult parseResult, CancellationToken cancellationToken)
   at System.CommandLine.Invocation.InvocationPipeline.InvokeAsync(ParseResult parseResult, CancellationToken cancellationToken)

@ownerer ownerer mentioned this issue Mar 12, 2025
Closed
@sharwell sharwell linked a pull request Mar 12, 2025 that will close this issue
Open
sharwell added a commit to sharwell/sdk that referenced this issue Mar 12, 2025
@sharwell
Fix failure to handle slnx files
b5cb778 
Fixes dotnet#47038
@sharwell
Copy link
Member

@ownerer Note that a workaround here is to specify the directory containing the slnx file instead of specifying the slnx file itself. I've opened up a PR to make both cases work, but does this unblock you in the meantime?

@ownerer
Copy link
Author

ownerer commented Mar 14, 2025

@sharwell aha, thanks for the tip!
Indeed, that works. I can make do with that for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-Format Area-NetSDK Feature Request
Projects
None yet
Milestone
10.0.1xx
Development

Successfully merging a pull request may close this issue.

Fix dotnet format failure to handle slnx files sharwell/sdk
4 participants
@sharwell @ownerer @arunchndr @kasperk81