bin: fix clean scripts after new velero finalizers

Author: anders-elastisys

scripts/clean-sc.sh

@@ -39,22 +39,30 @@ fi
 # Clean up namespaces and any other resources left behind by the apps
 "${here}/.././bin/ck8s" ops kubectl sc delete ns dex opensearch-system harbor fluentd-system gatekeeper-system thanos ingress-nginx monitoring kured falco velero
 
+# Remove finalizers from Velero resources, see breaking changes: https://github.com/vmware-tanzu/velero/releases/tag/v1.12.0
+mapfile -t VELERO_CRDS < <("${here}/.././bin/ck8s" ops kubectl sc get crd -l component=velero -oyaml | \
+    yq4 '.items[] | .metadata.name' | tr -d '"')
+
+for velero_crd in "${VELERO_CRDS[@]}"; do
+    mapfile -t VELERO_RESOURCES < <("${here}/.././bin/ck8s" ops kubectl sc get "${velero_crd}" -oyaml -n velero| \
+        yq4 '.items[] | select(.metadata | has("finalizers")).metadata.name')
+    for velero_resource in "${VELERO_RESOURCES[@]}"; do
+        "${here}/.././bin/ck8s" ops kubectl sc patch "${velero_crd}" "${velero_resource}" -n velero \
+            -p '{"metadata":{"finalizers":null}}' --type=merge
+    done
+done
+
 # Clean up any leftover challenges
 CHALLENGES=$(
-    "${here}/.././bin/ck8s" ops \
-      kubectl sc get challenge -A \
-      "-o=jsonpath='{range .items[*]}{.metadata.name}{\",\"}{.metadata.namespace}{\"\n\"}{end}'"
+    "${here}/.././bin/ck8s" ops kubectl sc get challenge -A \
+        "-o=jsonpath='{range .items[*]}{.metadata.name}{\",\"}{.metadata.namespace}{\"\n\"}{end}'"
   )
-if [ -n "$CHALLENGES" ]; then
-  for challenge in "${CHALLENGES[@]}"; do
-      IFS=, read -r name namespace <<< "$challenge"
-      "${here}/.././bin/ck8s" ops \
-          kubectl sc patch challenge \
-          "$name" -n "$namespace" \
-          "-p '{\"metadata\":{\"finalizers\":null}}'" \
-          --type=merge
-  done
-fi
+for challenge in "${CHALLENGES[@]}"; do
+    IFS=, read -r name namespace <<< "${challenge}"
+    "${here}/.././bin/ck8s" ops \
+        kubectl sc patch challenge "${name}" -n "${namespace}" \
+        -p '{"metadata":{"finalizers":null}}' --type=merge
+done
 
 if [ "${clusterAPIEnabled}" = "false" ]; then
   # Destroy cert-manager helm release

scripts/clean-wc.sh

@@ -51,6 +51,31 @@ fi
 # Clean up namespaces and any other resources left behind by the apps
 "${here}/.././bin/ck8s" ops kubectl wc delete ns alertmanager falco fluentd-system fluentd gatekeeper-system hnc-system ingress-nginx monitoring velero kured
 
+# Remove finalizers from Velero resources, see breaking changes: https://github.com/vmware-tanzu/velero/releases/tag/v1.12.0
+mapfile -t VELERO_CRDS < <("${here}/.././bin/ck8s" ops kubectl wc get crd -l component=velero -oyaml | \
+    yq4 '.items[] | .metadata.name' | tr -d '"')
+
+for velero_crd in "${VELERO_CRDS[@]}"; do
+    mapfile -t VELERO_RESOURCES < <("${here}/.././bin/ck8s" ops kubectl wc get "${velero_crd}" -oyaml -n velero| \
+        yq4 '.items[] | select(.metadata | has("finalizers")).metadata.name')
+    for velero_resource in "${VELERO_RESOURCES[@]}"; do
+        "${here}/.././bin/ck8s" ops kubectl wc patch "${velero_crd}" "${velero_resource}" -n velero \
+            -p '{"metadata":{"finalizers":null}}' --type=merge
+    done
+done
+
+# Clean up any leftover challenges
+CHALLENGES=$(
+    "${here}/.././bin/ck8s" ops kubectl wc get challenge -A \
+        "-o=jsonpath='{range .items[*]}{.metadata.name}{\",\"}{.metadata.namespace}{\"\n\"}{end}'"
+  )
+for challenge in "${CHALLENGES[@]}"; do
+    IFS=, read -r name namespace <<< "${challenge}"
+    "${here}/.././bin/ck8s" ops \
+        kubectl wc patch challenge "${name}" -n "${namespace}" \
+        -p '{"metadata":{"finalizers":null}}' --type=merge
+done
+
 if [ "${clusterAPIEnabled}" = "false" ]; then
   # Destroy cert-manager helm release
   "${here}/.././bin/ck8s" ops helmfile wc -l app=cert-manager destroy