-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the "setup pin code" for test project? (CON-1580) #1308
Comments
You can change the discriminator here: https://github.com/project-chip/connectedhomeip/blob/13da787aeb078fb79587139aef0f266e9d2b7c63/src/include/platform/CHIPDeviceConfig.h#L1233, but for the setup pin code, you shall not change it with the spake2p unchanged. |
I have try that but when discriminator change from 3840 to 3850 code setup code gen using https://github.com/espressif/connectedhomeip/tree/9b8fffe0bb4e7ba7aac319f5905070a3476db7cb/src/setup_payload/python output the same: So I know by reading the code, when changing setup pin code the spake2p must be change. I see in the #760 seem the proper way to change that with code. But the is simple way to change CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODE and re calculate https://github.com/project-chip/connectedhomeip/blob/13da787aeb078fb79587139aef0f266e9d2b7c63/src/include/platform/CHIPDeviceConfig.h#L1282. I try change it but not working, may cause by build cache. You may add if in menu config and gen code for that, it is simpler to change the code when testing, rather simple than using mfg-tool to built the partition like in production. |
@Jerry-ESP I try the example light_switch project and enable:
Commissioning window closed close immediately after boot 1.5s. |
Please apply this patch and have a try. |
Yes, it work now. I can pair using the code and chiptool. |
You can get the QR code by typing the command in device console BTW, the dynamic passcode commissionable data provider could only be used when a device have a display which can show the QR code or you can get the QRCode/ManualCode with other methods(For example, you can make the device connected to the cloud with other provisioning approach and get the QR code from the cloud). For normal usage to use unique Setup-PIN&Discriminator, please refer to https://docs.espressif.com/projects/esp-matter/en/latest/esp32/production.html |
I want to test same matter in the same network, but the problem all setup code is the same for test devices. I want it simple to test so not using chip-tool or mfg-tool to generate partition.
It is:
But there is no config to change that. Seem in examples there is no option to change that.
And the code set by the parent chip code in: CHIP_DEVICE_CONFIG_USE_TEST_SETUP_PIN_CODE https://github.com/lucicop/connectedhomeip/blob/df2c8e9072714273caad5c60ed9ce1b4911cf662/config/standalone/CHIPProjectConfig.h#L42
I see that it include in the
esp-matter/examples/controller/sdkconfig.defaults
Line 12 in a960281
The text was updated successfully, but these errors were encountered: