-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revamp find-wallet header #15054
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
81b4dae
to
37a11e6
Compare
Hi @JoeChenJ! Question: If user selects one persona, can the other personas counter be recalculated based on how many are available with "and" logic? in this example i selected "deggen", and then it shows there are 7 hardware wallets, which isnt true. There are only 4 wallets that include both "degen" tag and "hardware" tag |
No problem! Just did a commit to improve the logic |
@JoeChenJ lastly could you please put back "finance" instead of "degen" ? sorry for having it in figma, I should probably think through that naming more before proposing a change. |
Used the shadow like on home page, thanks for the feedbacks! 🚀 @konopkja |
good catch! Yes I should add some padding to the container |
lgtm! ty again so much for your contribution |
found a bug on some screen sizes. maybe fixed height? Screen.Recording.2025-03-14.at.14.49.15.mov |
one more very small visual bug Can we add some space between the top filter and the other filter? @konopkja this is not a bug, but what do you think about making this a list and not a 2 by 2 grid? or it's better like because of mobile affordance 🧐 |
yeah i think we can keep it 2x2 , but some padding at the bottom is a good idea, good catch! |
Description
Revamp find-wallet header
Preview link
https://deploy-preview-15054--ethereumorg.netlify.app/en/wallets/find-wallet
Related Issue