Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp find-wallet header #15054

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

JoeChenJ
Copy link
Contributor

@JoeChenJ JoeChenJ commented Mar 11, 2025

Description

Revamp find-wallet header

Preview link

https://deploy-preview-15054--ethereumorg.netlify.app/en/wallets/find-wallet

Related Issue

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Mar 11, 2025
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit d12cd32
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67d4631812ea970008860e55
😎 Deploy Preview https://deploy-preview-15054--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🔴 down 12 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 87 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoeChenJ JoeChenJ force-pushed the Revamp_find_wallet_header branch from 81b4dae to 37a11e6 Compare March 11, 2025 17:01
@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Mar 12, 2025
@JoeChenJ JoeChenJ marked this pull request as ready for review March 12, 2025 04:35
@konopkja
Copy link
Contributor

Hi @JoeChenJ! Question: If user selects one persona, can the other personas counter be recalculated based on how many are available with "and" logic?

Screenshot 2025-03-12 at 16 09 01

in this example i selected "deggen", and then it shows there are 7 hardware wallets, which isnt true. There are only 4 wallets that include both "degen" tag and "hardware" tag

@JoeChenJ
Copy link
Contributor Author

Hi @JoeChenJ! Question: If user selects one persona, can the other personas counter be recalculated based on how many are available with "and" logic?

Screenshot 2025-03-12 at 16 09 01

in this example i selected "deggen", and then it shows there are 7 hardware wallets, which isnt true. There are only 4 wallets that include both "degen" tag and "hardware" tag

No problem! Just did a commit to improve the logic

@konopkja
Copy link
Contributor

Screenshot 2025-03-13 at 9 28 33

this padding on mobile 1.5 rem -> 0.75 please

@konopkja
Copy link
Contributor

@JoeChenJ lastly could you please put back "finance" instead of "degen" ? sorry for having it in figma, I should probably think through that naming more before proposing a change.

@konopkja
Copy link
Contributor

did some final testing with a user to see if the dark mode is visible enough and there is a small concern the outline isnt clear enough. Potential suggestion is to add glow behind the cards like on homepage.

Screenshot 2025-03-13 at 15 24 03

@konopkja
Copy link
Contributor

konopkja commented Mar 13, 2025

Screenshot 2025-03-13 at 15 39 20

this message can be removed

@JoeChenJ
Copy link
Contributor Author

Used the shadow like on home page, thanks for the feedbacks! 🚀 @konopkja

@konopkja
Copy link
Contributor

IMG_D609FA52C937-1

looks awesome! thanks for all edits and patience with me :D, last thing i noticed the glow is cut at the bottom probably bcs of container?

@JoeChenJ
Copy link
Contributor Author

JoeChenJ commented Mar 14, 2025

good catch! Yes I should add some padding to the container

@konopkja
Copy link
Contributor

lgtm! ty again so much for your contribution

@nloureiro
Copy link
Contributor

found a bug on some screen sizes.

maybe fixed height?

Screen.Recording.2025-03-14.at.14.49.15.mov

@nloureiro
Copy link
Contributor

nloureiro commented Mar 14, 2025

one more very small visual bug

Can we add some space between the top filter and the other filter?

Screen Shot 2025-03-14 02 55 53 PM

@konopkja this is not a bug, but what do you think about making this a list and not a 2 by 2 grid?

or it's better like because of mobile affordance 🧐

@konopkja
Copy link
Contributor

one more very small visual bug

Can we add some space between the top filter and the other filter?

Screen Shot 2025-03-14 02 55 53 PM

@konopkja this is not a bug, but what do you think about making this a list and not a 2 by 2 grid?

or it's better like because of mobile affordance 🧐

yeah i think we can keep it 2x2 , but some padding at the bottom is a good idea, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Find-wallet header
3 participants