Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Waffle from local environments page (#15098) #15103

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove Waffle from local environments page (#15098) #15103

wants to merge 1 commit into from

Conversation

sumitvekariya
Copy link
Contributor

Remove Waffle from local environments page

Description

This PR removes Waffle from the local environments page as it hasn't been updated for over 2 years and might be deprecated.

Changes made:

  1. Removed the Waffle entry from the frameworksList array in src/lib/api/ghRepoData.ts
  2. Removed the import for the Waffle image in src/lib/api/ghRepoData.ts
  3. Removed the Waffle-related entries (page-local-environment-waffle-desc and page-local-environment-waffle-logo-alt) from all translation files
  4. Removed the Waffle image file

Related Issue

Fixes #15098

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Mar 14, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 14, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8dbf124
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67d3a45d0c6c49000828fb24
😎 Deploy Preview https://deploy-preview-15103--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 45 (🔴 down 12 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 87 (🔴 down 8 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@sumitvekariya
Copy link
Contributor Author

Suggestions to update page-local-environment-solidity-template-desc in page-developers-local-environment.json translation files, because it mentions waffle testing

@Adeniyisue1988
Copy link

Markdown is supported

@Adeniyisue1988
Copy link

Uploading CONTRIBUTING.md…

1 similar comment
@Adeniyisue1988
Copy link

Uploading CONTRIBUTING.md…

@corwintines
Copy link
Member

@Adeniyisue1988 please stop spamming, we will block you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove Waffle from locan-environments
3 participants
@sumitvekariya @Adeniyisue1988 @corwintines