Skip to content

Commit 7aa2651

Browse files
committed
fixup! fixup! IBX-6773: Bookmarks for non-accessible contents cause exception - Changed to ibexa namespace for new classes
1 parent fabbe47 commit 7aa2651

File tree

5 files changed

+16
-9
lines changed

5 files changed

+16
-9
lines changed

eZ/Publish/Core/Repository/BookmarkService.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,13 @@
1414
use eZ\Publish\API\Repository\Values\Bookmark\BookmarkList;
1515
use eZ\Publish\API\Repository\Values\Content\Location;
1616
use eZ\Publish\API\Repository\Values\Content\Query;
17-
use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
18-
use eZ\Publish\API\Repository\Values\Content\Query\SortClause;
1917
use eZ\Publish\API\Repository\Values\Filter\Filter;
2018
use eZ\Publish\Core\Base\Exceptions\InvalidArgumentException;
2119
use eZ\Publish\SPI\Persistence\Bookmark\CreateStruct;
2220
use eZ\Publish\SPI\Persistence\Bookmark\Handler as BookmarkHandler;
21+
use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
22+
use Ibexa\Contracts\Core\Repository\Values\Content\Query\SortClause;
23+
2324

2425
class BookmarkService implements BookmarkServiceInterface
2526
{

eZ/Publish/Core/settings/storage_engines/legacy/filter/query_builders.yaml

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ services:
99
eZ\Publish\Core\Persistence\Legacy\Filter\CriterionQueryBuilder\:
1010
resource: '../../../../Persistence/Legacy/Filter/CriterionQueryBuilder/*'
1111

12+
Ibexa\Core\Persistence\Legacy\Filter\CriterionQueryBuilder\:
13+
resource: '../../../../../../../src/lib/Persistence/Legacy/Filter/CriterionQueryBuilder/*'
14+
1215
eZ\Publish\Core\Persistence\Legacy\Filter\SortClauseQueryBuilder\:
1316
resource: '../../../../Persistence/Legacy/Filter/SortClauseQueryBuilder/*'
1417

18+
Ibexa\Core\Persistence\Legacy\Filter\SortClauseQueryBuilder\:
19+
resource: '../../../../../../../src/lib/Persistence/Legacy/Filter/SortClauseQueryBuilder/*'

src/contracts/Repository/Values/Content/Query/Criterion/IsBookmarked.php

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
namespace Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
1010

1111
use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
12+
use eZ\Publish\API\Repository\Values\Content\Query\Criterion\Operator;
1213
use eZ\Publish\API\Repository\Values\Content\Query\Criterion\Operator\Specifications;
1314
use eZ\Publish\SPI\Repository\Values\Filter\FilteringCriterion;
1415

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
namespace Ibexa\Core\Persistence\Legacy\Filter\SortClauseQueryBuilder\Bookmark;
1010

11-
use eZ\Publish\API\Repository\Values\Content\Query\SortClause\BookmarkId;
11+
use Ibexa\Contracts\Core\Repository\Values\Content\Query\SortClause\BookmarkId;
1212
use eZ\Publish\SPI\Persistence\Filter\Doctrine\FilteringQueryBuilder;
1313
use eZ\Publish\SPI\Repository\Values\Filter\FilteringSortClause;
1414
use eZ\Publish\SPI\Repository\Values\Filter\SortClauseQueryBuilder;

tests/lib/Persistence/Legacy/Filter/CriterionQueryBuilder/Location/BookmarkQueryBuilderTest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,26 @@
88

99
namespace Ibexa\Tests\Core\Persistence\Legacy\Filter\CriterionQueryBuilder\Location;
1010

11-
use eZ\Publish\API\Repository\Values\Content\Query\Criterion as EzCriterion;
11+
use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
1212
use eZ\Publish\Core\Persistence\Legacy\Tests\Filter\BaseCriterionVisitorQueryBuilderTestCase;
13-
use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion;
13+
use Ibexa\Contracts\Core\Repository\Values\Content\Query\Criterion as IbexaCriterion;
1414
use Ibexa\Core\Persistence\Legacy\Filter\CriterionQueryBuilder\Location\BookmarkQueryBuilder;
1515

1616
final class BookmarkQueryBuilderTest extends BaseCriterionVisitorQueryBuilderTestCase
1717
{
1818
public function getFilteringCriteriaQueryData(): iterable
1919
{
2020
yield 'Bookmarks locations for user_id=14' => [
21-
new Criterion\IsBookmarked(14),
21+
new IbexaCriterion\IsBookmarked(14),
2222
'bookmark.user_id = :dcValue1',
2323
['dcValue1' => 14],
2424
];
2525

2626
yield 'Bookmarks locations for user_id=14 OR user_id=7' => [
27-
new EzCriterion\LogicalOr(
27+
new Criterion\LogicalOr(
2828
[
29-
new Criterion\IsBookmarked(14),
30-
new Criterion\IsBookmarked(7),
29+
new IbexaCriterion\IsBookmarked(14),
30+
new IbexaCriterion\IsBookmarked(7),
3131
]
3232
),
3333
'(bookmark.user_id = :dcValue1) OR (bookmark.user_id = :dcValue2)',

0 commit comments

Comments
 (0)