Skip to content

Commit c6c0c22

Browse files
committed
fixup! fixup! IBX-7579:Richtext: Rows are added to ezurl_object_link on every save: Changed unit test into integration test
1 parent 26e6145 commit c6c0c22

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

eZ/Publish/Core/FieldType/Url/UrlStorage/Gateway/DoctrineStorage.php

+2-6
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public function insertUrl($url)
132132
/**
133133
* Return a list of URLs used by the given field and version.
134134
*
135-
* array<string, boolean> An array of URLs, with urls as keys
135+
* string[] An array of URLs
136136
*/
137137
public function getUrlsFromUrlLink(int $fieldId, int $versionNo): array
138138
{
@@ -163,12 +163,8 @@ public function getUrlsFromUrlLink(int $fieldId, int $versionNo): array
163163

164164
$statement = $selectQuery->execute();
165165
$rows = $statement->fetchFirstColumn();
166-
$result = [];
167-
foreach ($rows as $url) {
168-
$result[$url] = true;
169-
}
170166

171-
return $result;
167+
return $rows;
172168
}
173169

174170
/**

tests/integration/Core/FieldType/Url/UrlStorage/Gateway/UrlDoctrineStorageGatewayTest.php

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ public function testGetUrlsFromUrlLink(): void
3131
$gateway->linkUrl($urlIds[1], 12, 2);
3232
$gateway->linkUrl($urlIds[2], 14, 1);
3333

34-
self::assertEquals(['https://ibexa.co/example1' => true, 'https://ibexa.co/example2' => true], $gateway->getUrlsFromUrlLink(10, 1), 'Did not get expected urlS for field 10');
35-
self::assertEquals(['https://ibexa.co/example2' => true], $gateway->getUrlsFromUrlLink(12, 2), 'Did not get expected url for field 12');
36-
self::assertEquals(['https://ibexa.co/example3' => true], $gateway->getUrlsFromUrlLink(14, 1), 'Did not get expected url for field 14');
34+
self::assertEquals(['https://ibexa.co/example1', 'https://ibexa.co/example2'], $gateway->getUrlsFromUrlLink(10, 1), 'Did not get expected urls for field 10');
35+
self::assertEquals(['https://ibexa.co/example2'], $gateway->getUrlsFromUrlLink(12, 2), 'Did not get expected url for field 12');
36+
self::assertEquals(['https://ibexa.co/example3'], $gateway->getUrlsFromUrlLink(14, 1), 'Did not get expected url for field 14');
3737
self::assertEquals([], $gateway->getUrlsFromUrlLink(15, 1), 'Expected no urls for field 15');
3838
}
3939

0 commit comments

Comments
 (0)