Skip to content

Commit 19ff229

Browse files
authoredJul 9, 2024··
IBX-8378: Fixed handling non-indexable field types
For more details see https://issues.ibexa.co/browse/IBX-8378 and #250 Key changes: * Skipped mapping non-searchable fields * Aligned PHPStan baseline with the latest release
1 parent 2fb300d commit 19ff229

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed
 

‎ignore-lte-php7.4-errors.neon

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
parameters:
22
ignoreErrors:
33
-
4-
message: "#^Anonymous function should return array but returns array\\<string\\>\\|false\\.$#"
4+
message: "#^Anonymous function should return array\\<string\\> but returns array\\<string\\>\\|false\\.$#"
55
count: 1
66
path: tests/lib/Search/ResultExtractor/AggregationResultExtractor/TermAggregationResultExtractorTest.php

‎lib/FieldMapper/ContentTranslationFieldMapper/BlockDocumentsContentFields.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public function mapFields(Content $content, $languageCode)
7474
}
7575

7676
foreach ($contentType->fieldDefinitions as $fieldDefinition) {
77-
if ($fieldDefinition->id !== $field->fieldDefinitionId) {
77+
if ($fieldDefinition->id !== $field->fieldDefinitionId || !$fieldDefinition->isSearchable) {
7878
continue;
7979
}
8080

‎lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentFulltextFields.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ private function doMapFields(Content $content, ContentType $contentType, $langua
128128
}
129129

130130
foreach ($contentType->fieldDefinitions as $fieldDefinition) {
131-
if ($fieldDefinition->id !== $field->fieldDefinitionId) {
131+
if ($fieldDefinition->id !== $field->fieldDefinitionId || !$fieldDefinition->isSearchable) {
132132
continue;
133133
}
134134

@@ -140,7 +140,7 @@ private function doMapFields(Content $content, ContentType $contentType, $langua
140140
continue;
141141
}
142142

143-
if (!$indexField->type instanceof FieldType\FullTextField || !$fieldDefinition->isSearchable) {
143+
if (!$indexField->type instanceof FieldType\FullTextField) {
144144
continue;
145145
}
146146

0 commit comments

Comments
 (0)
Please sign in to comment.