Skip to content

Commit 20a46c4

Browse files
committed
build(deps-dev): replace standard with neostandard
1 parent 389ca8d commit 20a46c4

File tree

4 files changed

+101
-104
lines changed

4 files changed

+101
-104
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
[![CI](https://github.com/fastify/fastify-websocket/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/fastify/fastify-websocket/actions/workflows/ci.yml)
44
[![NPM version](https://img.shields.io/npm/v/@fastify/websocket.svg?style=flat)](https://www.npmjs.com/package/@fastify/websocket)
5-
[![js-standard-style](https://img.shields.io/badge/code%20style-standard-brightgreen.svg?style=flat)](https://standardjs.com/)
5+
[![neostandard javascript style](https://img.shields.io/badge/code_style-neostandard-brightgreen?style=flat)](https://github.com/neostandard/neostandard)
66

77
WebSocket support for [Fastify](https://github.com/fastify/fastify).
88
Built upon [ws@8](https://www.npmjs.com/package/ws).

package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"type": "commonjs",
77
"types": "types/index.d.ts",
88
"scripts": {
9-
"lint": "standard",
9+
"lint": "eslint",
10+
"lint:fix": "eslint --fix",
1011
"test": "npm run test:unit && npm run test:typescript",
1112
"test:unit": "tap",
1213
"test:typescript": "tsd"
@@ -32,8 +33,8 @@
3233
"@types/ws": "^8.5.10",
3334
"fastify": "^5.0.0",
3435
"fastify-tsconfig": "^2.0.0",
36+
"neostandard": "^0.11.9",
3537
"split2": "^4.2.0",
36-
"standard": "^17.1.0",
3738
"tap": "^18.7.1",
3839
"tsd": "^0.31.0"
3940
},

types/index.d.ts

+13-13
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
/// <reference types="node" />
2-
import { IncomingMessage, ServerResponse, Server } from 'http';
3-
import { FastifyRequest, FastifyPluginCallback, RawServerBase, RawServerDefault, RawRequestDefaultExpression, RawReplyDefaultExpression, RequestGenericInterface, ContextConfigDefault, FastifyInstance, FastifySchema, FastifyTypeProvider, FastifyTypeProviderDefault, FastifyBaseLogger } from 'fastify';
4-
import * as fastify from 'fastify';
5-
import * as WebSocket from 'ws';
6-
import { FastifyReply } from 'fastify/types/reply';
7-
import { preCloseHookHandler, preCloseAsyncHookHandler } from 'fastify/types/hooks';
8-
import { RouteGenericInterface } from 'fastify/types/route';
2+
import { IncomingMessage, ServerResponse, Server } from 'http'
3+
import { FastifyRequest, FastifyPluginCallback, RawServerBase, RawServerDefault, RawRequestDefaultExpression, RawReplyDefaultExpression, RequestGenericInterface, ContextConfigDefault, FastifyInstance, FastifySchema, FastifyTypeProvider, FastifyTypeProviderDefault, FastifyBaseLogger } from 'fastify'
4+
import * as fastify from 'fastify'
5+
import * as WebSocket from 'ws'
6+
import { FastifyReply } from 'fastify/types/reply'
7+
import { preCloseHookHandler, preCloseAsyncHookHandler } from 'fastify/types/hooks'
8+
import { RouteGenericInterface } from 'fastify/types/route'
99

1010
interface WebsocketRouteOptions<
1111
RawServer extends RawServerBase = RawServerDefault,
@@ -43,7 +43,7 @@ declare module 'fastify' {
4343
RawRequest extends RawRequestDefaultExpression<RawServer> = RawRequestDefaultExpression<RawServer>,
4444
RawReply extends RawReplyDefaultExpression<RawServer> = RawReplyDefaultExpression<RawServer>,
4545
TypeProvider extends FastifyTypeProvider = FastifyTypeProviderDefault,
46-
Logger extends FastifyBaseLogger = FastifyBaseLogger,
46+
Logger extends FastifyBaseLogger = FastifyBaseLogger
4747
> {
4848
<RequestGeneric extends RequestGenericInterface = RequestGenericInterface, ContextConfig = ContextConfigDefault, SchemaCompiler extends FastifySchema = FastifySchema, InnerLogger extends Logger = Logger>(
4949
path: string,
@@ -64,11 +64,11 @@ declare module 'fastify' {
6464
> extends WebsocketRouteOptions<RawServer, RawRequest, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> { }
6565
}
6666

67-
type FastifyWebsocket = FastifyPluginCallback<fastifyWebsocket.WebsocketPluginOptions>;
67+
type FastifyWebsocket = FastifyPluginCallback<fastifyWebsocket.WebsocketPluginOptions>
6868

6969
declare namespace fastifyWebsocket {
7070

71-
interface WebSocketServerOptions extends Omit<WebSocket.ServerOptions, "path"> { }
71+
interface WebSocketServerOptions extends Omit<WebSocket.ServerOptions, 'path'> { }
7272
export type WebsocketHandler<
7373
RawServer extends RawServerBase = RawServerDefault,
7474
RawRequest extends RawRequestDefaultExpression<RawServer> = RawRequestDefaultExpression<RawServer>,
@@ -81,7 +81,7 @@ declare namespace fastifyWebsocket {
8181
this: FastifyInstance<Server, IncomingMessage, ServerResponse>,
8282
socket: WebSocket.WebSocket,
8383
request: FastifyRequest<RequestGeneric, RawServer, RawRequest, SchemaCompiler, TypeProvider, ContextConfig, Logger>
84-
) => void | Promise<any>;
84+
) => void | Promise<any>
8585
export interface WebsocketPluginOptions {
8686
errorHandler?: (this: FastifyInstance, error: Error, socket: WebSocket.WebSocket, request: FastifyRequest, reply: FastifyReply) => void;
8787
options?: WebSocketServerOptions;
@@ -98,11 +98,11 @@ declare namespace fastifyWebsocket {
9898
Logger extends FastifyBaseLogger = FastifyBaseLogger
9999
> extends fastify.RouteOptions<RawServer, RawRequest, RawReply, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger>, WebsocketRouteOptions<RawServer, RawRequest, RouteGeneric, ContextConfig, SchemaCompiler, TypeProvider, Logger> { }
100100

101-
export type WebSocket = WebSocket.WebSocket;
101+
export type WebSocket = WebSocket.WebSocket
102102

103103
export const fastifyWebsocket: FastifyWebsocket
104104
export { fastifyWebsocket as default }
105105
}
106106

107-
declare function fastifyWebsocket(...params: Parameters<FastifyWebsocket>): ReturnType<FastifyWebsocket>
107+
declare function fastifyWebsocket (...params: Parameters<FastifyWebsocket>): ReturnType<FastifyWebsocket>
108108
export = fastifyWebsocket

types/index.test-d.ts

+84-88
Original file line numberDiff line numberDiff line change
@@ -1,116 +1,113 @@
1-
import fastifyWebsocket, { WebsocketHandler, fastifyWebsocket as namedFastifyWebsocket, default as defaultFastifyWebsocket, WebSocket } from '..';
2-
import type { IncomingMessage } from "http";
3-
import fastify, { RouteOptions, FastifyRequest, FastifyInstance, FastifyReply, RequestGenericInterface, FastifyBaseLogger, RawServerDefault, FastifySchema, RawRequestDefaultExpression } from 'fastify';
4-
import { expectType } from 'tsd';
5-
import { Server } from 'ws';
6-
import { RouteGenericInterface } from 'fastify/types/route';
7-
import { TypeBoxTypeProvider } from '@fastify/type-provider-typebox';
1+
import fastifyWebsocket, { WebsocketHandler, fastifyWebsocket as namedFastifyWebsocket, default as defaultFastifyWebsocket, WebSocket } from '..'
2+
import type { IncomingMessage } from 'http'
3+
import fastify, { RouteOptions, FastifyRequest, FastifyInstance, FastifyReply, RequestGenericInterface, FastifyBaseLogger, RawServerDefault, FastifySchema, RawRequestDefaultExpression } from 'fastify'
4+
import { expectType } from 'tsd'
5+
import { Server } from 'ws'
6+
import { RouteGenericInterface } from 'fastify/types/route'
7+
import { TypeBoxTypeProvider } from '@fastify/type-provider-typebox'
88
import { Type } from '@sinclair/typebox'
99

10-
const app: FastifyInstance = fastify();
11-
app.register(fastifyWebsocket);
12-
app.register(fastifyWebsocket, {});
13-
app.register(fastifyWebsocket, { options: { maxPayload: 123 } });
10+
const app: FastifyInstance = fastify()
11+
app.register(fastifyWebsocket)
12+
app.register(fastifyWebsocket, {})
13+
app.register(fastifyWebsocket, { options: { maxPayload: 123 } })
1414
app.register(fastifyWebsocket, {
15-
errorHandler: function errorHandler(error: Error, socket: WebSocket, request: FastifyRequest, reply: FastifyReply): void {
16-
expectType<FastifyInstance>(this);
15+
errorHandler: function errorHandler (error: Error, socket: WebSocket, request: FastifyRequest, reply: FastifyReply): void {
16+
expectType<FastifyInstance>(this)
1717
expectType<Error>(error)
1818
expectType<WebSocket>(socket)
1919
expectType<FastifyRequest>(request)
2020
expectType<FastifyReply>(reply)
2121
}
22-
});
23-
app.register(fastifyWebsocket, { options: { perMessageDeflate: true } });
24-
app.register(fastifyWebsocket, { preClose: function syncPreclose() {} });
25-
app.register(fastifyWebsocket, { preClose: async function asyncPreclose(){} });
22+
})
23+
app.register(fastifyWebsocket, { options: { perMessageDeflate: true } })
24+
app.register(fastifyWebsocket, { preClose: function syncPreclose () {} })
25+
app.register(fastifyWebsocket, { preClose: async function asyncPreclose () {} })
2626

2727
app.get('/websockets-via-inferrence', { websocket: true }, async function (socket, request) {
28-
expectType<FastifyInstance>(this);
29-
expectType<WebSocket>(socket);
30-
expectType<Server>(app.websocketServer);
28+
expectType<FastifyInstance>(this)
29+
expectType<WebSocket>(socket)
30+
expectType<Server>(app.websocketServer)
3131
expectType<FastifyRequest<RequestGenericInterface>>(request)
32-
expectType<boolean>(request.ws);
33-
expectType<FastifyBaseLogger>(request.log);
34-
});
32+
expectType<boolean>(request.ws)
33+
expectType<FastifyBaseLogger>(request.log)
34+
})
3535

3636
const handler: WebsocketHandler = async (socket, request) => {
37-
expectType<WebSocket>(socket);
38-
expectType<Server>(app.websocketServer);
37+
expectType<WebSocket>(socket)
38+
expectType<Server>(app.websocketServer)
3939
expectType<FastifyRequest<RequestGenericInterface>>(request)
4040
}
4141

42-
app.get('/websockets-via-annotated-const', { websocket: true }, handler);
42+
app.get('/websockets-via-annotated-const', { websocket: true }, handler)
4343

4444
app.get('/not-specifed', async (request, reply) => {
45-
expectType<FastifyRequest>(request);
45+
expectType<FastifyRequest>(request)
4646
expectType<FastifyReply>(reply)
47-
expectType<boolean>(request.ws);
48-
});
47+
expectType<boolean>(request.ws)
48+
})
4949

5050
app.get('/not-websockets', { websocket: false }, async (request, reply) => {
51-
expectType<FastifyRequest>(request);
52-
expectType<FastifyReply>(reply);
53-
});
51+
expectType<FastifyRequest>(request)
52+
expectType<FastifyReply>(reply)
53+
})
5454

5555
app.route({
5656
method: 'GET',
5757
url: '/route-full-declaration-syntax',
5858
handler: (request, reply) => {
59-
expectType<FastifyRequest>(request);
60-
expectType<FastifyReply>(reply);
61-
expectType<boolean>(request.ws);
59+
expectType<FastifyRequest>(request)
60+
expectType<FastifyReply>(reply)
61+
expectType<boolean>(request.ws)
6262
},
6363
wsHandler: (socket, request) => {
64-
expectType<WebSocket>(socket);
65-
expectType<FastifyRequest<RouteGenericInterface>>(request);
66-
expectType<boolean>(request.ws);
64+
expectType<WebSocket>(socket)
65+
expectType<FastifyRequest<RouteGenericInterface>>(request)
66+
expectType<boolean>(request.ws)
6767
},
68-
});
68+
})
6969

7070
const augmentedRouteOptions: RouteOptions = {
7171
method: 'GET',
7272
url: '/route-with-exported-augmented-route-options',
7373
handler: (request, reply) => {
74-
expectType<FastifyRequest>(request);
75-
expectType<FastifyReply>(reply);
74+
expectType<FastifyRequest>(request)
75+
expectType<FastifyReply>(reply)
7676
},
7777
wsHandler: (socket, request) => {
78-
expectType<WebSocket>(socket);
78+
expectType<WebSocket>(socket)
7979
expectType<FastifyRequest<RouteGenericInterface>>(request)
8080
},
81-
};
82-
app.route(augmentedRouteOptions);
83-
81+
}
82+
app.route(augmentedRouteOptions)
8483

8584
app.get<{ Params: { foo: string }, Body: { bar: string }, Querystring: { search: string }, Headers: { auth: string } }>('/shorthand-explicit-types', {
8685
websocket: true
8786
}, async (socket, request) => {
88-
expectType<WebSocket>(socket);
89-
expectType<{ foo: string }>(request.params);
90-
expectType<{ bar: string }>(request.body);
91-
expectType<{ search: string }>(request.query);
92-
expectType< IncomingMessage['headers'] & { auth: string }>(request.headers);
93-
});
94-
87+
expectType<WebSocket>(socket)
88+
expectType<{ foo: string }>(request.params)
89+
expectType<{ bar: string }>(request.body)
90+
expectType<{ search: string }>(request.query)
91+
expectType< IncomingMessage['headers'] & { auth: string }>(request.headers)
92+
})
9593

9694
app.route<{ Params: { foo: string }, Body: { bar: string }, Querystring: { search: string }, Headers: { auth: string } }>({
9795
method: 'GET',
9896
url: '/longhand-explicit-types',
9997
handler: (request, _reply) => {
100-
expectType<{ foo: string }>(request.params);
101-
expectType<{ bar: string }>(request.body);
102-
expectType<{ search: string }>(request.query);
103-
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers);
98+
expectType<{ foo: string }>(request.params)
99+
expectType<{ bar: string }>(request.body)
100+
expectType<{ search: string }>(request.query)
101+
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers)
104102
},
105103
wsHandler: (socket, request) => {
106-
expectType<WebSocket>(socket);
107-
expectType<{ foo: string }>(request.params);
108-
expectType<{ bar: string }>(request.body);
109-
expectType<{ search: string }>(request.query);
110-
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers);
104+
expectType<WebSocket>(socket)
105+
expectType<{ foo: string }>(request.params)
106+
expectType<{ bar: string }>(request.body)
107+
expectType<{ search: string }>(request.query)
108+
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers)
111109
},
112-
});
113-
110+
})
114111

115112
const schema = {
116113
params: Type.Object({
@@ -125,43 +122,42 @@ const schema = {
125122
headers: Type.Object({
126123
auth: Type.String()
127124
})
128-
};
125+
}
129126

130-
const server = app.withTypeProvider<TypeBoxTypeProvider>();
127+
const server = app.withTypeProvider<TypeBoxTypeProvider>()
131128

132129
server.route({
133130
method: 'GET',
134131
url: '/longhand-type-inference',
135132
schema,
136133
handler: (request, _reply) => {
137-
expectType<{ foo: string }>(request.params);
138-
expectType<{ bar: string }>(request.body);
139-
expectType<{ search: string }>(request.query);
140-
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers);
134+
expectType<{ foo: string }>(request.params)
135+
expectType<{ bar: string }>(request.body)
136+
expectType<{ search: string }>(request.query)
137+
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers)
141138
},
142139
wsHandler: (socket, request) => {
143-
expectType<WebSocket>(socket);
144-
expectType<{ foo: string }>(request.params);
145-
expectType<{ bar: string }>(request.body);
146-
expectType<{ search: string }>(request.query);
147-
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers);
140+
expectType<WebSocket>(socket)
141+
expectType<{ foo: string }>(request.params)
142+
expectType<{ bar: string }>(request.body)
143+
expectType<{ search: string }>(request.query)
144+
expectType<IncomingMessage['headers'] & { auth: string }>(request.headers)
148145
},
149-
});
146+
})
150147

151148
server.get('/websockets-no-type-inference',
152149
{ websocket: true },
153150
async function (socket, request) {
154-
expectType<FastifyInstance>(this);
155-
expectType<WebSocket>(socket);
156-
expectType<Server>(app.websocketServer);
157-
expectType<FastifyRequest<RequestGenericInterface, RawServerDefault, RawRequestDefaultExpression, FastifySchema, TypeBoxTypeProvider, unknown, FastifyBaseLogger>>(request);
158-
expectType<boolean>(request.ws);
159-
expectType<unknown>(request.params);
160-
expectType<unknown>(request.body);
161-
expectType<unknown>(request.query);
162-
expectType<IncomingMessage['headers']>(request.headers);
163-
});
164-
165-
expectType<typeof fastifyWebsocket>(namedFastifyWebsocket);
166-
expectType<typeof fastifyWebsocket>(defaultFastifyWebsocket);
151+
expectType<FastifyInstance>(this)
152+
expectType<WebSocket>(socket)
153+
expectType<Server>(app.websocketServer)
154+
expectType<FastifyRequest<RequestGenericInterface, RawServerDefault, RawRequestDefaultExpression, FastifySchema, TypeBoxTypeProvider, unknown, FastifyBaseLogger>>(request)
155+
expectType<boolean>(request.ws)
156+
expectType<unknown>(request.params)
157+
expectType<unknown>(request.body)
158+
expectType<unknown>(request.query)
159+
expectType<IncomingMessage['headers']>(request.headers)
160+
})
167161

162+
expectType<typeof fastifyWebsocket>(namedFastifyWebsocket)
163+
expectType<typeof fastifyWebsocket>(defaultFastifyWebsocket)

0 commit comments

Comments
 (0)