Skip to content

Commit 1ad960a

Browse files
committed
session: Handle server fqdn/ip on #initailize
This is because server name or ip should be needed to connect remote Windows box. Signed-off-by: Hiroshi Hatake <[email protected]>
1 parent 1a438b4 commit 1ad960a

File tree

5 files changed

+19
-7
lines changed

5 files changed

+19
-7
lines changed

example/eventlog.rb

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
require 'winevt'
22

3-
@session = Winevt::EventLog::Session.new
4-
@session.server = "127.0.0.1" # Or remote box ip
3+
@session = Winevt::EventLog::Session.new("127.0.0.1") # Or remote box ip
54
# @session.domain = "<EXAMPLEGROUP>"
65
# @session.username = "<username>"
76
# @session.password = "<password>"

example/tailing.rb

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
require 'winevt'
22

3-
@session = Winevt::EventLog::Session.new
4-
@session.server = "127.0.0.1" # Or remote box ip
3+
@session = Winevt::EventLog::Session.new("127.0.0.1") # Or remote box ip
54
# @session.domain = "<EXAMPLEGROUP>"
65
# @session.username = "<username>"
76
# @session.password = "<password>"

lib/winevt.rb

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
require "winevt/query"
88
require "winevt/subscribe"
99
require "winevt/version"
10+
require "winevt/session"
1011

1112
module Winevt
1213
# Your code goes here...

lib/winevt/session.rb

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
module Winevt
2+
class EventLog
3+
class Session
4+
alias_method :initialize_raw, :initialize
5+
6+
def initialize(server, domain = nil, username = nil, password = nil)
7+
initialize_raw
8+
self.server = server
9+
self.domain = domain if domain.is_a?(String)
10+
self.username = username if username.is_a?(String)
11+
self.password = password if password.is_a?(String)
12+
end
13+
end
14+
end
15+
end

test/test_winevt.rb

+1-3
Original file line numberDiff line numberDiff line change
@@ -285,12 +285,10 @@ def test_each
285285

286286
class SessionTest < self
287287
def setup
288-
@session = Winevt::EventLog::Session.new
288+
@session = Winevt::EventLog::Session.new("127.0.0.1")
289289
end
290290

291291
def test_server
292-
assert_equal("(NULL)", @session.server)
293-
@session.server = "127.0.0.1"
294292
assert_equal("127.0.0.1", @session.server)
295293
end
296294

0 commit comments

Comments
 (0)