🛠️ apply pre-commit fixes

Author: getsantry[bot]

src/migrations/versions/8b858da8ed27_migration.py

@@ -5,49 +5,66 @@
 Create Date: 2025-03-06 13:24:21.106144
 
 """
-from alembic import op
+
 import sqlalchemy as sa
-from sqlalchemy.dialects import postgresql
+from alembic import op
 from pgvector.sqlalchemy import Vector  # type: ignore
-
+from sqlalchemy.dialects import postgresql
 
 # revision identifiers, used by Alembic.
-revision = '8b858da8ed27'
-down_revision = 'e0fcdc14251c'
+revision = "8b858da8ed27"
+down_revision = "e0fcdc14251c"
 branch_labels = None
 depends_on = None
 
 
 def upgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.create_table('codegen_review_comments_pattern_store',
-    sa.Column('id', sa.Integer(), nullable=False),
-    sa.Column('provider', sa.String(), nullable=False),
-    sa.Column('owner', sa.String(), nullable=False),
-    sa.Column('repo', sa.String(), nullable=False),
-    sa.Column('pr_id', sa.BigInteger(), nullable=False),
-    sa.Column('body', sa.String(), nullable=False),
-    sa.Column('is_good_pattern', sa.Boolean(), nullable=False),
-    sa.Column('embedding', Vector(dim=768), nullable=False),
-    sa.Column('comment_metadata', postgresql.JSONB(astext_type=sa.Text()), nullable=False),
-    sa.Column('created_at', sa.DateTime(), nullable=False),
-    sa.PrimaryKeyConstraint('id'),
-    sa.UniqueConstraint('provider', 'pr_id', 'repo', 'owner')
+    op.create_table(
+        "codegen_review_comments_pattern_store",
+        sa.Column("id", sa.Integer(), nullable=False),
+        sa.Column("provider", sa.String(), nullable=False),
+        sa.Column("owner", sa.String(), nullable=False),
+        sa.Column("repo", sa.String(), nullable=False),
+        sa.Column("pr_id", sa.BigInteger(), nullable=False),
+        sa.Column("body", sa.String(), nullable=False),
+        sa.Column("is_good_pattern", sa.Boolean(), nullable=False),
+        sa.Column("embedding", Vector(dim=768), nullable=False),
+        sa.Column("comment_metadata", postgresql.JSONB(astext_type=sa.Text()), nullable=False),
+        sa.Column("created_at", sa.DateTime(), nullable=False),
+        sa.PrimaryKeyConstraint("id"),
+        sa.UniqueConstraint("provider", "pr_id", "repo", "owner"),
     )
-    with op.batch_alter_table('codegen_review_comments_pattern_store', schema=None) as batch_op:
-        batch_op.create_index('ix_review_comments_embedding_hnsw', ['embedding'], unique=False, postgresql_using='hnsw', postgresql_with={'m': 16, 'ef_construction': 64}, postgresql_ops={'embedding': 'vector_cosine_ops'})
-        batch_op.create_index('ix_review_comments_is_good_pattern', ['is_good_pattern'], unique=False)
-        batch_op.create_index('ix_review_comments_repo_owner_pr', ['owner', 'repo', 'pr_id'], unique=False)
+    with op.batch_alter_table("codegen_review_comments_pattern_store", schema=None) as batch_op:
+        batch_op.create_index(
+            "ix_review_comments_embedding_hnsw",
+            ["embedding"],
+            unique=False,
+            postgresql_using="hnsw",
+            postgresql_with={"m": 16, "ef_construction": 64},
+            postgresql_ops={"embedding": "vector_cosine_ops"},
+        )
+        batch_op.create_index(
+            "ix_review_comments_is_good_pattern", ["is_good_pattern"], unique=False
+        )
+        batch_op.create_index(
+            "ix_review_comments_repo_owner_pr", ["owner", "repo", "pr_id"], unique=False
+        )
 
     # ### end Alembic commands ###
 
 
 def downgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    with op.batch_alter_table('codegen_review_comments_pattern_store', schema=None) as batch_op:
-        batch_op.drop_index('ix_review_comments_repo_owner_pr')
-        batch_op.drop_index('ix_review_comments_is_good_pattern')
-        batch_op.drop_index('ix_review_comments_embedding_hnsw', postgresql_using='hnsw', postgresql_with={'m': 16, 'ef_construction': 64}, postgresql_ops={'embedding': 'vector_cosine_ops'})
+    with op.batch_alter_table("codegen_review_comments_pattern_store", schema=None) as batch_op:
+        batch_op.drop_index("ix_review_comments_repo_owner_pr")
+        batch_op.drop_index("ix_review_comments_is_good_pattern")
+        batch_op.drop_index(
+            "ix_review_comments_embedding_hnsw",
+            postgresql_using="hnsw",
+            postgresql_with={"m": 16, "ef_construction": 64},
+            postgresql_ops={"embedding": "vector_cosine_ops"},
+        )
 
-    op.drop_table('codegen_review_comments_pattern_store')
+    op.drop_table("codegen_review_comments_pattern_store")
     # ### end Alembic commands ###

src/seer/app.py

@@ -25,6 +25,7 @@
     AutofixRequest,
     AutofixStateRequest,
     AutofixStateResponse,
+    AutofixUpdateEndpointResponse,
     AutofixUpdateRequest,
     AutofixUpdateType,
 )
@@ -34,6 +35,7 @@
     get_autofix_state,
     get_autofix_state_from_pr_id,
     receive_user_message,
+    resolve_comment_thread,
     restart_from_point_with_feedback,
     run_autofix_coding,
     run_autofix_evaluation,
@@ -48,6 +50,7 @@
     CodecovTaskRequest,
     CodegenBaseRequest,
     CodegenBaseResponse,
+    CodegenPrClosedResponse,
     CodegenPrReviewResponse,
     CodegenPrReviewStateRequest,
     CodegenPrReviewStateResponse,
@@ -56,14 +59,13 @@
     CodegenUnitTestsResponse,
     CodegenUnitTestsStateRequest,
     CodegenUnitTestsStateResponse,
-    CodegenPrClosedResponse,
 )
 from seer.automation.codegen.tasks import (
+    codegen_pr_closed,
     codegen_pr_review,
     codegen_relevant_warnings,
     codegen_unittest,
     get_unittest_state,
-    codegen_pr_closed
 )
 from seer.automation.summarize.issue import run_summarize_issue
 from seer.automation.summarize.models import SummarizeIssueRequest, SummarizeIssueResponse
@@ -186,15 +188,15 @@ def autofix_start_endpoint(data: AutofixRequest) -> AutofixEndpointResponse:
 @json_api(blueprint, "/v1/automation/autofix/update")
 def autofix_update_endpoint(
     data: AutofixUpdateRequest,
-) -> AutofixEndpointResponse:
+) -> AutofixUpdateEndpointResponse:
     if data.payload.type == AutofixUpdateType.SELECT_ROOT_CAUSE:
         run_autofix_solution(data)
     elif data.payload.type == AutofixUpdateType.SELECT_SOLUTION:
         run_autofix_coding(data)
     elif data.payload.type == AutofixUpdateType.CREATE_PR:
-        run_autofix_push_changes(data)
+        return run_autofix_push_changes(data)
     elif data.payload.type == AutofixUpdateType.CREATE_BRANCH:
-        run_autofix_push_changes(data)
+        return run_autofix_push_changes(data)
     elif data.payload.type == AutofixUpdateType.USER_MESSAGE:
         receive_user_message(data)
     elif data.payload.type == AutofixUpdateType.RESTART_FROM_POINT_WITH_FEEDBACK:
@@ -203,7 +205,10 @@ def autofix_update_endpoint(
         update_code_change(data)
     elif data.payload.type == AutofixUpdateType.COMMENT_THREAD:
         comment_on_thread(data)
-    return AutofixEndpointResponse(started=True, run_id=data.run_id)
+    elif data.payload.type == AutofixUpdateType.RESOLVE_COMMENT_THREAD:
+        resolve_comment_thread(data)
+
+    return AutofixUpdateEndpointResponse(run_id=data.run_id)
 
 
 @json_api(blueprint, "/v1/automation/autofix/state")
@@ -383,7 +388,6 @@ def ready_check(app_config: AppConfig = injected):
     from seer.inference_models import models_loading_status
 
     status = models_loading_status()
-    logger.info(f"Model loading status: {status}")
     if app_config.SMOKE_CHECK:
         smoke_status = check_smoke_test()
         logger.info(f"Celery smoke status: {smoke_status}")

src/seer/automation/codegen/models.py

@@ -160,18 +160,19 @@ class PrFile(BaseModel):
     # https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28
     filename: str
     patch: str
-    status: Literal[
-        "added",
-        "removed",
-        "modified",
-        "renamed",
-        "copied",
-        "changed",
-        "unchanged",
-    ]
+    status: Literal["added", "removed", "modified", "renamed", "copied", "changed", "unchanged"]
     changes: int
 
 
+class FilterWarningsRequest(BaseComponentRequest):
+    warnings: list[StaticAnalysisWarning]
+    target_filenames: list[str]
+
+
+class FilterWarningsOutput(BaseComponentOutput):
+    warnings: list[StaticAnalysisWarning]
+
+
 class CodeFetchIssuesRequest(BaseComponentRequest):
     organization_id: int
     pr_files: list[PrFile]
@@ -214,6 +215,11 @@ class CodePredictRelevantWarningsOutput(BaseComponentOutput):
 
 
 class CodecovTaskRequest(BaseModel):
-    data: CodegenUnitTestsRequest | CodegenPrReviewRequest | CodegenRelevantWarningsRequest | CodegenPrClosedRequest
+    data: (
+        CodegenUnitTestsRequest
+        | CodegenPrReviewRequest
+        | CodegenRelevantWarningsRequest
+        | CodegenPrClosedRequest
+    )
     external_owner_id: str
     request_type: Literal["unit-tests", "pr-review", "relevant-warnings", "pr-closed"]

src/seer/automation/codegen/pr_closed_step.py

@@ -1,13 +1,15 @@
+import datetime
 from asyncio.log import logger
 from typing import Any
+
 from github.PaginatedList import PaginatedList
 from github.PullRequestComment import PullRequestComment
-import datetime
-
 from langfuse.decorators import observe
 from sentry_sdk.ai.monitoring import ai_track
+from sqlalchemy.dialects.postgresql import insert
 
 from celery_app.app import celery_app
+from seer.automation.agent.embeddings import GoogleProviderEmbeddings
 from seer.automation.autofix.config import (
     AUTOFIX_EXECUTION_HARD_TIME_LIMIT_SECS,
     AUTOFIX_EXECUTION_SOFT_TIME_LIMIT_SECS,
@@ -18,8 +20,6 @@
 from seer.automation.pipeline import PipelineStepTaskRequest
 from seer.automation.state import DbStateRunTypes
 from seer.db import DbReviewCommentEmbedding, Session
-from seer.automation.agent.embeddings import GoogleProviderEmbeddings
-from sqlalchemy.dialects.postgresql import insert
 
 
 class PrClosedStepRequest(PipelineStepTaskRequest):
@@ -31,6 +31,7 @@ class CommentAnalyzer:
     """
     Handles comment analysis logic
     """
+
     def __init__(self, bot_username: str = "codecov-ai-reviewer[bot]"):
         self.bot_username = bot_username
 
@@ -44,10 +45,10 @@ def analyze_reactions(self, comment: PullRequestComment) -> tuple[bool, bool]:
         Returns: (is_good_pattern, is_bad_pattern)
         """
         reactions = comment.get_reactions()
-        upvotes = sum(1 for r in reactions if r.content == '+1')
-        downvotes = sum(1 for r in reactions if r.content == '-1')
-        
-        is_good_pattern = upvotes >= downvotes 
+        upvotes = sum(1 for r in reactions if r.content == "+1")
+        downvotes = sum(1 for r in reactions if r.content == "-1")
+
+        is_good_pattern = upvotes >= downvotes
         is_bad_pattern = downvotes > upvotes
         return is_good_pattern, is_bad_pattern
 
@@ -84,16 +85,15 @@ def __init__(self, request: dict[str, Any], type: DbStateRunTypes):
     def _process_comment(self, comment: PullRequestComment, pr):
         try:
             is_good_pattern, is_bad_pattern = self.analyzer.analyze_reactions(comment)
-            
+
             logger.info(
                 f"Processing bot comment id {comment.id} on PR {pr.url}: "
                 f"good_pattern={is_good_pattern}, "
                 f"bad_pattern={is_bad_pattern}"
             )
 
             model = GoogleProviderEmbeddings.model(
-                "text-embedding-005", 
-                task_type="CODE_RETRIEVAL_QUERY"
+                "text-embedding-005", task_type="CODE_RETRIEVAL_QUERY"
             )
             # Returns a 2D array, even for a single text input
             embedding = model.encode(comment.body)[0]
@@ -109,17 +109,18 @@ def _process_comment(self, comment: PullRequestComment, pr):
                     comment_metadata={
                         "url": comment.html_url,
                         "comment_id": comment.id,
-                        "location": {
-                            "file_path": comment.path,
-                            "line_number": comment.position
-                        } if hasattr(comment, "path") else None,
+                        "location": (
+                            {"file_path": comment.path, "line_number": comment.position}
+                            if hasattr(comment, "path")
+                            else None
+                        ),
                         "timestamps": {
                             "created_at": comment.created_at.isoformat(),
                             "updated_at": comment.updated_at.isoformat(),
-                        }
+                        },
                     },
                     embedding=embedding,
-                    created_at=datetime.datetime.now()
+                    created_at=datetime.datetime.now(),
                 )
 
                 session.execute(
@@ -128,11 +129,9 @@ def _process_comment(self, comment: PullRequestComment, pr):
                     )
                 )
                 session.commit()
-            
+
         except Exception as e:
-            self.logger.error(
-                f"Error processing comment {comment.id} on PR {pr.url}: {e}"
-            )
+            self.logger.error(f"Error processing comment {comment.id} on PR {pr.url}: {e}")
             raise
 
     @observe(name="Codegen - PR Closed")
@@ -152,7 +151,7 @@ def _invoke(self, **kwargs):
                     self._process_comment(comment, pr)
 
             self.context.event_manager.mark_completed()
-            
+
         except Exception as e:
             self.logger.error(f"Error processing closed PR {pr.url}: {e}")
-            raise 
+            raise

src/seer/automation/codegen/tasks.py

@@ -48,6 +48,7 @@ def create_initial_pr_review_run(request: CodegenBaseRequest) -> DbState[Codegen
 
     return state
 
+
 def create_initial_pr_closed_run(request: CodegenPrClosedRequest) -> DbState[CodegenContinuation]:
     state = CodegenContinuationState.new(
         CodegenContinuation(request=request), group_id=request.pr_id, t=DbStateRunTypes.PR_CLOSED
@@ -59,7 +60,6 @@ def create_initial_pr_closed_run(request: CodegenPrClosedRequest) -> DbState[Cod
         cur.mark_triggered()
 
     return state
-    
 
 
 def create_initial_relevant_warnings_run(
@@ -109,16 +109,15 @@ def codegen_pr_closed(request: CodegenBaseRequest, app_config: AppConfig = injec
         run_id=cur_state.run_id,
         pr_id=request.pr_id,
         repo_definition=request.repo,
-    )   
-    
+    )
+
     PrClosedStep.get_signature(
         pr_closed_request, queue=app_config.CELERY_WORKER_QUEUE
     ).apply_async()
 
     return CodegenPrClosedResponse(run_id=cur_state.run_id)
 
 
-
 def get_unittest_state(request: CodegenUnitTestsStateRequest):
     state = CodegenContinuationState(request.run_id)
     return state.get()