Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Hangs: Rename client.captureCrashEvent #4936

Closed
philipphofmann opened this issue Mar 4, 2025 · 0 comments · Fixed by #5002
Closed

App Hangs: Rename client.captureCrashEvent #4936

philipphofmann opened this issue Mar 4, 2025 · 0 comments · Fixed by #5002
Assignees
@philipphofmann
Labels
Platform: Cocoa

Comments

@philipphofmann
Copy link
Member

Description

Capturing fatal app hang events use client.captureCrashEvent. Rename the method so it communicates it's not only about capturing crashes. Maybe captureFatalEvent does the trick.
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile SDKs Mar 4, 2025
@philipphofmann philipphofmann self-assigned this Mar 4, 2025
@philipphofmann philipphofmann mentioned this issue Mar 4, 2025
Merged
7 tasks
@philipphofmann philipphofmann moved this from Needs Discussion to Backlog in Mobile SDKs Mar 5, 2025
@philipphofmann philipphofmann moved this from Backlog to In Progress in Mobile SDKs Mar 20, 2025
@philipphofmann philipphofmann mentioned this issue Mar 20, 2025
Merged
philipphofmann added a commit that referenced this issue Mar 20, 2025
@philipphofmann
ref: Rename captureCrashEvent to captureFatalEvent
cca9bca 
The captureCrashEvent is also used for capturing watchdog terminations
and fatal app hangs. Therefore, we rename it to captureFatalEvent to
clearly communicate its about fatal events and not only crashes.

Fixes GH-4936
@philipphofmann philipphofmann mentioned this issue Mar 20, 2025
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile SDKs Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Platform: Cocoa
Projects
Mobile SDKs
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: Rename captureCrashEvent to captureFatalEvent getsentry/sentry-cocoa
1 participant
@philipphofmann