Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Hub should resolve the SentryClient in a consistent way #2962

Closed
jamescrosswell opened this issue Dec 11, 2023 · 0 comments · Fixed by #3435
Closed

The Hub should resolve the SentryClient in a consistent way #2962

jamescrosswell opened this issue Dec 11, 2023 · 0 comments · Fixed by #3435
Assignees
@jamescrosswell
Labels
Optimization

Comments

@jamescrosswell
Copy link
Collaborator

jamescrosswell commented Dec 11, 2023 •
edited
Loading

Not introduced in this PR but reading it made me realize and wonder why we have _ownedClient, and use it in some methods (CaptureUserFeedback and CaptureSession but everywhere else we take the client from the (Scope,SentryClient) tuple (which can change with PushScope and BindClient. It's inconsistent.

Originally posted by @bruno-garcia in #2949 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamescrosswell jamescrosswell

Labels
Optimization
Projects
GDX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactored Hub to always use the SentryScopeManager client getsentry/sentry-dotnet
2 participants
@jamescrosswell @bitsandfoxes