-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When running sentry.init with opentelemetry in next.js instrumentation, next.route span attributes is lost #15634
Comments
Link to issue that looks similar to this: #14660 |
Hi, I looked into this a bit and can reproduce. I don't think we are stomping on the attribute directly. Instead what we're doing is hoisting spans above the Here are the attributes for the same req span before and after adding Sentry. Before:
After:
I am backlogging for now but also don't think we will fix this soon. |
Hello! Before I begin, i would like to express my gratitude for quickly checking my issue and for the effort you put into maintaining this project. I fully understand that it may not be possible to fix this issue immediately. Houwever, I hope this problem can be resolved as soon as possible. Although it was unintentional, the interaction between various libraries may add new values, but it seems necessary to improve the situation where they interface with each other and affect the original data. This is very important metric for monitoring the state and improving the performance of many applications at my current company. While it is not an issue with Sentry or OpenTelemetry, if we cannot record query string or path parameters by pattern, the cardinality of data in the application memory will continuously increase, which may put a load on the application. Of course, using regular expressions or specific path patterns can alleviate this to dome extent, but it is not easy for all developers in other teams to create it according to the requirements of the applications they are developing. I would be very grateful if this could be improved. I hope this issue can be resolved, even if it takes time. Can you notify me when you start working on it? Once again, thank you for your hard work. |
Hi, I fear we wont be able to pick this up anytime soon. Feel free to contribute a fix to the SDK or Next.js itself! |
Is there an existing issue for this?
How do you use Sentry?
Self-hosted/on-premise
Which SDK are you using?
@sentry/nextjs
SDK Version
8.42.0, 9.5.0
It is reproduced in both versions.
Framework Version
next@15.1.7
Link to Sentry event
No response
Reproduction Example/SDK Setup
github repository link
DSN is internal information so it is not published, but it does not have any effect on reproducing the issue.
Steps to Reproduce
Running pnpm dev and build after that gives the same result.
Expected Result
next.route must remain in BaseServer.handleRequest span_type regardless of whether sentry.init is included in the code or not
Actual Result
Additional Details
You can easily reproduce this by cloning the above repository and running the project.
Actual Result
The text was updated successfully, but these errors were encountered: