Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client_address into standalone spans #15643

Open
DominikB2014 opened this issue Mar 13, 2025 · 2 comments
Open

Add client_address into standalone spans #15643

DominikB2014 opened this issue Mar 13, 2025 · 2 comments
Assignees

Comments

@DominikB2014
Copy link
Contributor

Problem Statement

In getsentry/relay#4047 we started extracting user information from standalone spans. However, in order for this to fully work, client_address must be sent in the data section of a span from the SDKs.

In the end, all this is to support the subregion selector in the web vitals module getsentry/sentry#75230

Solution Brainstorm

Add a new property to span.data, client_address. This is set to either the client itself, or {{auto}} if we want relay to derive it. We already do something similar under the the user section of a transaction

@AbhiPrasad
Copy link
Member

Hmm @cleptric how do we want to approach the auto detection stuff for ips and similar in standalone spans considering what we've run into for transactions/errors?

@cleptric cleptric self-assigned this Mar 17, 2025
@cleptric
Copy link
Member

I'll get back to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants