Skip to content

Commit e1f5c20

Browse files
authored
Make jruby CI work with explicit jar-dependencies install (#2550)
1 parent e292d0e commit e1f5c20

File tree

13 files changed

+71
-27
lines changed

13 files changed

+71
-27
lines changed

.github/workflows/sentry_delayed_job_test.yml

+8-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
ruby-versions:
1717
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
1818
with:
19-
engine: cruby
19+
engine: cruby-jruby
2020
min_version: 2.4
2121
test:
2222
needs: ruby-versions
@@ -45,6 +45,7 @@ jobs:
4545
# LoadError:
4646
# cannot load such file -- mutex_m
4747
- { ruby_version: "head" }
48+
- { ruby_version: 'jruby-head' }
4849
steps:
4950
- uses: actions/checkout@v4
5051
- name: Install sqlite
@@ -58,7 +59,12 @@ jobs:
5859
uses: ruby/setup-ruby@v1
5960
with:
6061
ruby-version: ${{ matrix.ruby_version }}
61-
bundler-cache: true
62+
bundler-cache: ${{ ! contains(matrix.ruby_version, 'jruby') }}
63+
64+
# https://github.com/jruby/jruby/issues/8606#issuecomment-2641501008
65+
- name: Bundle Jruby
66+
if: ${{ contains(matrix.ruby_version, 'jruby') }}
67+
run: gem install jar-dependencies && bundle
6268

6369
- name: Run specs
6470
run: bundle exec rake

.github/workflows/sentry_opentelemetry_test.yml

+9-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
ruby-versions:
1717
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
1818
with:
19-
engine: cruby
19+
engine: cruby-jruby
2020
min_version: 2.6
2121
test:
2222
needs: ruby-versions
@@ -39,14 +39,21 @@ jobs:
3939
- ruby_version: 3.2
4040
options:
4141
rubyopt: "--enable-frozen-string-literal --debug=frozen-string-literal"
42+
exclude:
43+
- { ruby_version: 'jruby-head' }
4244
steps:
4345
- uses: actions/checkout@v4
4446

4547
- name: Set up Ruby ${{ matrix.ruby_version }}
4648
uses: ruby/setup-ruby@v1
4749
with:
4850
ruby-version: ${{ matrix.ruby_version }}
49-
bundler-cache: true
51+
bundler-cache: ${{ ! contains(matrix.ruby_version, 'jruby') }}
52+
53+
# https://github.com/jruby/jruby/issues/8606#issuecomment-2641501008
54+
- name: Bundle Jruby
55+
if: ${{ contains(matrix.ruby_version, 'jruby') }}
56+
run: gem install jar-dependencies && bundle
5057

5158
- name: Run specs
5259
run: bundle exec rake

.github/workflows/sentry_rails_test.yml

+8-1
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ jobs:
8080
rails_version: "8.0.0"
8181
- ruby_version: "3.4"
8282
rails_version: "8.0.0"
83+
- ruby_version: "jruby"
84+
rails_version: 6.1.0
8385
- ruby_version: "3.2"
8486
rails_version: 7.1.0
8587
options:
@@ -98,7 +100,12 @@ jobs:
98100
uses: ruby/setup-ruby@v1
99101
with:
100102
ruby-version: ${{ matrix.ruby_version }}
101-
bundler-cache: true
103+
bundler-cache: ${{ ! contains(matrix.ruby_version, 'jruby') }}
104+
105+
# https://github.com/jruby/jruby/issues/8606#issuecomment-2641501008
106+
- name: Bundle Jruby
107+
if: ${{ contains(matrix.ruby_version, 'jruby') }}
108+
run: gem install jar-dependencies && bundle
102109

103110
- name: Build with Rails ${{ matrix.rails_version }}
104111
run: bundle exec rake

.github/workflows/sentry_resque_test.yml

+9-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
ruby-versions:
1717
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
1818
with:
19-
engine: cruby
19+
engine: cruby-jruby
2020
min_version: 2.4
2121
test:
2222
needs: ruby-versions
@@ -37,13 +37,20 @@ jobs:
3737
- ruby_version: "3.2"
3838
options:
3939
rubyopt: "--enable-frozen-string-literal --debug=frozen-string-literal"
40+
exclude:
41+
- { ruby_version: 'jruby-head' }
4042
steps:
4143
- uses: actions/checkout@v4
4244
- name: Set up Ruby ${{ matrix.ruby_version }}
4345
uses: ruby/setup-ruby@v1
4446
with:
4547
ruby-version: ${{ matrix.ruby_version }}
46-
bundler-cache: true
48+
bundler-cache: ${{ ! contains(matrix.ruby_version, 'jruby') }}
49+
50+
# https://github.com/jruby/jruby/issues/8606#issuecomment-2641501008
51+
- name: Bundle Jruby
52+
if: ${{ contains(matrix.ruby_version, 'jruby') }}
53+
run: gem install jar-dependencies && bundle
4754

4855
- name: Start Redis
4956
uses: supercharge/[email protected]

.github/workflows/sentry_ruby_test.yml

+9-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
ruby-versions:
1717
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
1818
with:
19-
engine: cruby
19+
engine: cruby-jruby
2020
min_version: 2.4
2121
test:
2222
needs: ruby-versions
@@ -58,14 +58,21 @@ jobs:
5858
- ruby_version: 3.4
5959
rack_version: 3.1
6060
redis_rb_version: 5.3
61+
exclude:
62+
- { ruby_version: 'jruby-head' }
6163
steps:
6264
- uses: actions/checkout@v4
6365

6466
- name: Set up Ruby ${{ matrix.ruby_version }}
6567
uses: ruby/setup-ruby@v1
6668
with:
6769
ruby-version: ${{ matrix.ruby_version }}
68-
bundler-cache: true
70+
bundler-cache: ${{ ! contains(matrix.ruby_version, 'jruby') }}
71+
72+
# https://github.com/jruby/jruby/issues/8606#issuecomment-2641501008
73+
- name: Bundle Jruby
74+
if: ${{ contains(matrix.ruby_version, 'jruby') }}
75+
run: gem install jar-dependencies && bundle
6976

7077
- name: Start Redis
7178
uses: supercharge/redis-github-action@c169aa53af4cd5d9321e9114669dbd11be08d307

.github/workflows/sentry_sidekiq_test.yml

+13-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
sidekiq_version: ["5.0", "6.5", "7.0"]
31-
ruby_version: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
31+
ruby_version: ["2.7", "3.0", "3.1", "3.2", "3.3", "3.4", jruby]
3232
include:
3333
- ruby_version: 2.4
3434
sidekiq_version: 5.0
@@ -40,6 +40,12 @@ jobs:
4040
sidekiq_version: 5.0
4141
- ruby_version: 2.6
4242
sidekiq_version: 6.0
43+
- ruby_version: jruby
44+
sidekiq_version: 5.0
45+
- ruby_version: jruby
46+
sidekiq_version: 6.0
47+
- ruby_version: jruby
48+
sidekiq_version: 7.0
4349
- ruby_version: "3.2"
4450
sidekiq_version: 7.0
4551
options:
@@ -57,7 +63,12 @@ jobs:
5763
uses: ruby/setup-ruby@v1
5864
with:
5965
ruby-version: ${{ matrix.ruby_version }}
60-
bundler-cache: true
66+
bundler-cache: ${{ ! contains(matrix.ruby_version, 'jruby') }}
67+
68+
# https://github.com/jruby/jruby/issues/8606#issuecomment-2641501008
69+
- name: Bundle Jruby
70+
if: ${{ contains(matrix.ruby_version, 'jruby') }}
71+
run: gem install jar-dependencies && bundle
6172

6273
- name: Start Redis
6374
uses: supercharge/[email protected]

Gemfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6+
gem "jar-dependencies", "0.5.4" if RUBY_PLATFORM == "java"
67
gem "rake", "~> 12.0"
78

89
ruby_version = Gem::Version.new(RUBY_VERSION)
910

10-
gem "jar-dependencies", "0.4.1" if RUBY_PLATFORM == "java"
11-
1211
# Development tools
1312
if ruby_version >= Gem::Version.new("2.7.0")
1413
gem "debug", github: "ruby/debug", platform: :ruby

sentry-delayed_job/Gemfile

+3-4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6+
eval_gemfile "../Gemfile"
7+
68
# Specify your gem's dependencies in sentry-ruby.gemspec
79
gemspec
810
gem "sentry-ruby", path: "../sentry-ruby"
@@ -14,8 +16,7 @@ gem "delayed_job_active_record"
1416
gem "rails", "> 5.0.0"
1517

1618
platform :jruby do
17-
# See https://github.com/jruby/activerecord-jdbc-adapter/issues/1139
18-
gem "activerecord-jdbcmysql-adapter", "<71.0", github: "jruby/activerecord-jdbc-adapter", ref: "6b3983bbbfda75ee2a1f5bc4c8d35efd7b71d84b"
19+
gem "activerecord-jdbcmysql-adapter"
1920
gem "jdbc-sqlite3"
2021
end
2122

@@ -30,5 +31,3 @@ elsif ruby_version >= Gem::Version.new("3.0.0") && ruby_version < Gem::Version.n
3031
elsif ruby_version >= Gem::Version.new("3.1.0")
3132
gem "sqlite3", "~> 2.2", platform: :ruby
3233
end
33-
34-
eval_gemfile "../Gemfile"

sentry-opentelemetry/Gemfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6+
eval_gemfile "../Gemfile"
7+
68
# Specify your gem's dependencies in sentry-ruby.gemspec
79
gemspec
810

@@ -12,5 +14,3 @@ gem "opentelemetry-sdk"
1214
gem "opentelemetry-instrumentation-rails"
1315

1416
gem "sentry-ruby", path: "../sentry-ruby"
15-
16-
eval_gemfile "../Gemfile"

sentry-rails/Gemfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6+
eval_gemfile "../Gemfile"
7+
68
# Specify your gem's dependencies in sentry-ruby.gemspec
79
gemspec
810
gem "sentry-ruby", path: "../sentry-ruby"
@@ -59,5 +61,3 @@ gem "benchmark-ips"
5961
gem "benchmark_driver"
6062
gem "benchmark-ipsa"
6163
gem "benchmark-memory"
62-
63-
eval_gemfile "../Gemfile"

sentry-resque/Gemfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6+
eval_gemfile "../Gemfile"
7+
68
# Specify your gem's dependencies in sentry-ruby.gemspec
79
gemspec
810

@@ -12,8 +14,6 @@ gem "sentry-ruby", path: "../sentry-ruby"
1214

1315
gem "resque-retry", "~> 1.8"
1416

15-
eval_gemfile "../Gemfile"
16-
1717
group :rails do
1818
gem "sentry-rails", path: "../sentry-rails"
1919
gem "rails"

sentry-ruby/Gemfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6+
eval_gemfile "../Gemfile"
7+
68
gem "sentry-ruby", path: "./"
79

810
rack_version = ENV["RACK_VERSION"]
@@ -31,5 +33,3 @@ gem "yard", github: "lsegal/yard"
3133
gem "webrick"
3234
gem "faraday"
3335
gem "excon"
34-
35-
eval_gemfile "../Gemfile"

sentry-sidekiq/Gemfile

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
source "https://rubygems.org"
44
git_source(:github) { |name| "https://github.com/#{name}.git" }
55

6+
eval_gemfile "../Gemfile"
7+
68
# Specify your gem's dependencies in sentry-ruby.gemspec
79
gemspec
10+
811
gem "sentry-ruby", path: "../sentry-ruby"
912
gem "sentry-rails", path: "../sentry-rails"
1013

@@ -26,5 +29,3 @@ end
2629
gem "rails", "> 5.0.0"
2730

2831
gem "timecop"
29-
30-
eval_gemfile "../Gemfile"

0 commit comments

Comments
 (0)