Properly detach retry_stopped.active_job subscriber

Otherwise specs would be failing randomly

Author: solnic

sentry-rails/lib/sentry/rails/active_job.rb

@@ -68,8 +68,17 @@ def capture_exception(job, e)
           end
 
           def register_retry_stopped_subscriber
-            ActiveSupport::Notifications.subscribe(NOTIFICATION_NAME) do |*args|
-              retry_stopped_handler(*args)
+            unless @retry_stopped_subscriber
+              @retry_stopped_subscriber = ActiveSupport::Notifications.subscribe(NOTIFICATION_NAME) do |*args|
+                retry_stopped_handler(*args)
+              end
+            end
+          end
+
+          def detach_retry_stopped_subscriber
+            if @retry_stopped_subscriber
+              ActiveSupport::Notifications.unsubscribe(@retry_stopped_subscriber)
+              @retry_stopped_subscriber = nil
             end
           end
 

sentry-rails/lib/sentry/rails/railtie.rb

@@ -4,6 +4,8 @@
 require "sentry/rails/rescued_exception_interceptor"
 require "sentry/rails/backtrace_cleaner"
 
+require "active_job/railtie" rescue LoadError
+
 module Sentry
   class Railtie < ::Rails::Railtie
     # middlewares can't be injected after initialize

sentry-rails/spec/sentry/rails/activejob_spec.rb

@@ -463,7 +463,7 @@ def perform(event, hint)
         allow(Sentry::Rails::ActiveJobExtensions::SentryReporter)
           .to receive(:capture_exception).and_call_original
 
-        assert_performed_jobs 1 do
+        assert_performed_jobs 3 do
           FailedJobWithRetryOn.perform_later rescue nil
         end
 

sentry-rails/spec/spec_helper.rb

@@ -52,6 +52,10 @@
     expect(Sentry::Rails::Tracing.subscribed_tracing_events).to be_empty
     Sentry::Rails::Tracing.remove_active_support_notifications_patch
 
+    if defined?(Sentry::Rails::ActiveJobExtensions::SentryReporter)
+      Sentry::Rails::ActiveJobExtensions::SentryReporter.detach_retry_stopped_subscriber
+    end
+
     reset_sentry_globals!
   end