Skip to content

Commit b80a9e7

Browse files
committed
Fix issue with options.error_types discovered in #72
1 parent 5fe98b5 commit b80a9e7

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
66

77
## [Unreleased]
88

9+
## 0.8.6 - 2017-08-24
10+
### Fixed
11+
- Fix expected type of the `options.error_types` config value (scalar instead of array, discovered in #72)
12+
913
## 0.8.5 - 2017-08-22
1014
### Fixed
1115
- `trim()` DSN value from config, to avoid issues with .env files on BitBucket (see https://github.com/getsentry/sentry-symfony/pull/21#issuecomment-323673938)

src/Sentry/SentryBundle/DependencyInjection/Configuration.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ public function getConfigTreeBuilder()
8585
->scalarNode('curl_ssl_version')->defaultNull()->end()
8686
->scalarNode('trust_x_forwarded_proto')->defaultFalse()->end()
8787
->scalarNode('mb_detect_order')->defaultNull()->end()
88-
->arrayNode('error_types')
89-
->prototype('scalar')->end()
88+
->scalarNode('error_types')
89+
->defaultNull()
9090
->end()
9191
->scalarNode('app_path')->defaultValue('%kernel.root_dir%/..')->end()
9292
->arrayNode('excluded_app_paths')

test/DependencyInjection/SentryExtensionTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ public function test_that_it_sets_all_options()
557557
'curl_ssl_version' => 'curl_ssl_version',
558558
'trust_x_forwarded_proto' => true,
559559
'mb_detect_order' => 'mb_detect_order',
560-
'error_types' => array('error_types1' => 'error_types1'),
560+
'error_types' => 'E_ALL & ~E_DEPRECATED & ~E_NOTICE',
561561
'app_path' => 'app_path',
562562
'excluded_app_paths' => array('excluded_app_path1', 'excluded_app_path2'),
563563
'prefixes' => array('prefix1', 'prefix2'),

0 commit comments

Comments
 (0)