🔧 chore: change up slack thread util method

Author: iamrajjoshi

src/sentry/integrations/slack/actions/notification.py

@@ -394,19 +394,27 @@ def _send_notification_action_notification(
             open_period_start = open_period_start_for_group(event.group)
             new_notification_message_object.open_period_start = open_period_start
 
+        thread_ts = None
         with MessagingInteractionEvent(
             MessagingInteractionType.GET_PARENT_NOTIFICATION, SlackMessagingSpec()
         ).capture() as lifecycle:
-            thread_ts = NotificationActionThreadUtils._get_notification_action_thread_ts(
-                lifecycle=lifecycle,
-                event=event,
-                new_notification_message_object=new_notification_message_object,
-                organization=self.project.organization,
-                action=action,
-                open_period_start=open_period_start,
-                thread_option_default=ISSUE_ALERTS_THREAD_DEFAULT,
+            parent_notification_message = (
+                NotificationActionThreadUtils._get_notification_action_for_notification_action(
+                    lifecycle=lifecycle,
+                    action=action,
+                    group=event.group,
+                    organization=self.project.organization,
+                    open_period_start=open_period_start,
+                    thread_option_default=ISSUE_ALERTS_THREAD_DEFAULT,
+                )
             )
 
+            if parent_notification_message is not None:
+                new_notification_message_object.parent_notification_message_id = (
+                    parent_notification_message.id
+                )
+                thread_ts = parent_notification_message.message_identifier
+
         self._send_notification(
             event=event,
             futures=futures,

src/sentry/integrations/slack/utils/threads.py

@@ -1,14 +1,15 @@
 import logging
 from datetime import datetime
 
-from sentry.eventstore.models import GroupEvent
 from sentry.integrations.repository import get_default_notification_action_repository
 from sentry.integrations.repository.base import NotificationMessageValidationError
 from sentry.integrations.repository.notification_action import (
     NewNotificationActionNotificationMessage,
+    NotificationActionNotificationMessage,
     NotificationActionNotificationMessageRepository,
 )
 from sentry.integrations.utils.metrics import EventLifecycle
+from sentry.models.group import Group
 from sentry.models.options.organization_option import OrganizationOption
 from sentry.models.organization import Organization
 from sentry.workflow_engine.models.action import Action
@@ -46,16 +47,15 @@ def _save_notification_action_message(
             pass
 
     @classmethod
-    def _get_notification_action_thread_ts(
+    def _get_notification_action_for_notification_action(
         cls,
         organization: Organization,
         lifecycle: EventLifecycle,
         action: Action,
-        event: GroupEvent,
+        group: Group,
         open_period_start: datetime | None,
-        new_notification_message_object: NewNotificationActionNotificationMessage,
         thread_option_default: bool,
-    ) -> str | None:
+    ) -> NotificationActionNotificationMessage | None:
         """Find the thread in which to post a notification action notification as a reply.
 
         Return None to post the notification as a top-level message.
@@ -69,23 +69,18 @@ def _get_notification_action_thread_ts(
         ):
             return None
 
+        parent_notification_message: NotificationActionNotificationMessage | None = None
         try:
             action_repository: NotificationActionNotificationMessageRepository = (
                 get_default_notification_action_repository()
             )
             parent_notification_message = action_repository.get_parent_notification_message(
                 action=action,
-                group=event.group,
+                group=group,
                 open_period_start=open_period_start,
             )
         except Exception as e:
             lifecycle.record_halt(e)
             return None
 
-        if parent_notification_message is None:
-            return None
-
-        new_notification_message_object.parent_notification_message_id = (
-            parent_notification_message.id
-        )
-        return parent_notification_message.message_identifier
+        return parent_notification_message