Skip to content

Commit 1e4de79

Browse files
authored
chore(alerts): Remove unused logging (#87216)
Remove some logging we're not using anymore - while there is still an open GH issue about failure rate alerting, we have not been able to dedicate the time to investigating it and collecting logs we don't look at for 6 months is wasteful. The more recent part @mifu67 added we have solved, but we kind of piggybacked on the feature flag for a different problem.
1 parent e8e70f9 commit 1e4de79

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

src/sentry/incidents/subscription_processor.py

-24
Original file line numberDiff line numberDiff line change
@@ -411,18 +411,6 @@ def process_update(self, subscription_update: QuerySubscriptionUpdate) -> None:
411411
)
412412

413413
aggregation_value = self.get_aggregation_value(subscription_update)
414-
if features.has(
415-
"organizations:failure-rate-metric-alert-logging",
416-
self.subscription.project.organization,
417-
):
418-
logger.info(
419-
"Update value in subscription processor",
420-
extra={
421-
"result": subscription_update,
422-
"aggregation_value": aggregation_value,
423-
"rule_id": self.alert_rule.id,
424-
},
425-
)
426414

427415
has_anomaly_detection = features.has(
428416
"organizations:anomaly-detection-alerts", self.subscription.project.organization
@@ -444,18 +432,6 @@ def process_update(self, subscription_update: QuerySubscriptionUpdate) -> None:
444432
last_update=self.last_update.timestamp(),
445433
aggregation_value=aggregation_value,
446434
)
447-
# XXX (mifu67): log problematic rule, to be deleted later
448-
if features.has(
449-
"feature.organizations:failure-rate-metric-alert-logging",
450-
self.subscription.project.organization,
451-
):
452-
logger.info(
453-
"Received this response from Seer",
454-
extra={
455-
"potential_anomalies": potential_anomalies,
456-
"alert_rule_id": self.alert_rule.id,
457-
},
458-
)
459435
if potential_anomalies is None:
460436
logger.info(
461437
"No potential anomalies found",

0 commit comments

Comments
 (0)