Skip to content

Commit 1fc2128

Browse files
authored
ref(insights): Session Health tab should be labelled new (#87349)
Back basics with 'new' instead of 'beta' The data is not beta or anything, it's just a new tab to visualize things. I think new fits better. ![SCR-20250318-nhxn](https://github.com/user-attachments/assets/f3749856-c5c3-46ba-999a-63968e260899)
1 parent c08c885 commit 1fc2128

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

static/app/views/insights/pages/domainViewHeader.tsx

+1-7
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import {
2222
import {useIsLaravelInsightsEnabled} from 'sentry/views/insights/pages/backend/laravel/features';
2323
import {OVERVIEW_PAGE_TITLE} from 'sentry/views/insights/pages/settings';
2424
import {
25-
isModuleConsideredBeta,
2625
isModuleConsideredNew,
2726
isModuleEnabled,
2827
isModuleVisible,
@@ -145,15 +144,10 @@ function TabLabel({moduleName}: TabLabelProps) {
145144
const organization = useOrganization();
146145
const showBusinessIcon = !isModuleEnabled(moduleName, organization);
147146

148-
if (
149-
showBusinessIcon ||
150-
isModuleConsideredBeta(moduleName) ||
151-
isModuleConsideredNew(moduleName)
152-
) {
147+
if (showBusinessIcon || isModuleConsideredNew(moduleName)) {
153148
return (
154149
<TabContainer>
155150
{moduleTitles[moduleName]}
156-
{isModuleConsideredBeta(moduleName) && <Badge type="beta">{t('Beta')}</Badge>}
157151
{isModuleConsideredNew(moduleName) && <Badge type="new">{t('New')}</Badge>}
158152
{showBusinessIcon && <IconBusiness />}
159153
</TabContainer>

static/app/views/insights/pages/utils.ts

-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import type {DomainView} from 'sentry/views/insights/pages/useFilters';
44
import {
55
MODULE_FEATURE_MAP,
66
MODULE_FEATURE_VISIBLE_MAP,
7-
MODULES_CONSIDERED_BETA,
87
MODULES_CONSIDERED_NEW,
98
} from 'sentry/views/insights/settings';
109
import type {ModuleName} from 'sentry/views/insights/types';
@@ -15,9 +14,6 @@ export const isModuleEnabled = (module: ModuleName, organization: Organization)
1514
export const isModuleVisible = (module: ModuleName, organization: Organization) =>
1615
MODULE_FEATURE_VISIBLE_MAP[module].every(f => organization.features.includes(f));
1716

18-
export const isModuleConsideredBeta = (module: ModuleName) =>
19-
MODULES_CONSIDERED_BETA.has(module);
20-
2117
export const isModuleConsideredNew = (module: ModuleName) =>
2218
MODULES_CONSIDERED_NEW.has(module);
2319

static/app/views/insights/settings.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,9 @@ export const MODULE_FEATURE_VISIBLE_MAP: Record<ModuleName, string[]> = {
238238
/**
239239
* Modules that are considered "new", e.g. used to show a badge on the tab.
240240
*/
241-
export const MODULES_CONSIDERED_BETA: Set<ModuleName> = new Set([ModuleName.SESSIONS]);
242241
export const MODULES_CONSIDERED_NEW: Set<ModuleName> = new Set([
243242
ModuleName.MOBILE_VITALS,
243+
ModuleName.SESSIONS,
244244
]);
245245

246246
export const INGESTION_DELAY = 90;

0 commit comments

Comments
 (0)