🐛 fix: tests

Author: iamrajjoshi

tests/sentry/integrations/slack/test_message_builder.py

@@ -17,7 +17,7 @@
     AlertRuleSensitivity,
 )
 from sentry.incidents.models.incident import IncidentStatus
-from sentry.incidents.typings.metric_detector import AlertContext
+from sentry.incidents.typings.metric_detector import AlertContext, MetricIssueContext
 from sentry.integrations.messaging.message_builder import (
     build_attachment_text,
     build_attachment_title,
@@ -807,11 +807,10 @@ def test_no_description_in_notification(self):
         )
         assert SlackIncidentsMessageBuilder(
             alert_context=AlertContext.from_alert_rule_incident(alert_rule),
-            open_period_identifier=incident.identifier,
+            metric_issue_context=MetricIssueContext.from_legacy_models(
+                incident, IncidentStatus.CRITICAL, 0
+            ),
             organization=self.organization,
-            snuba_query=alert_rule.snuba_query,
-            new_status=IncidentStatus.CRITICAL,
-            metric_value=0,
             date_started=incident.date_started,
         ).build() == {
             "blocks": [
@@ -879,12 +878,11 @@ def test_simple(self):
         )
         assert SlackIncidentsMessageBuilder(
             alert_context=AlertContext.from_alert_rule_incident(alert_rule),
-            open_period_identifier=incident.identifier,
+            metric_issue_context=MetricIssueContext.from_legacy_models(
+                incident, IncidentStatus.CLOSED, 0
+            ),
             organization=self.organization,
-            snuba_query=alert_rule.snuba_query,
             date_started=incident.date_started,
-            new_status=IncidentStatus.CLOSED,
-            metric_value=0,
         ).build() == {
             "blocks": [
                 {
@@ -924,11 +922,10 @@ def test_metric_value(self):
         # This should fail because it pulls status from `action` instead of `incident`
         assert SlackIncidentsMessageBuilder(
             alert_context=AlertContext.from_alert_rule_incident(alert_rule),
-            open_period_identifier=incident.identifier,
+            metric_issue_context=MetricIssueContext.from_legacy_models(
+                incident, IncidentStatus.CRITICAL, metric_value
+            ),
             organization=self.organization,
-            snuba_query=alert_rule.snuba_query,
-            new_status=IncidentStatus.CRITICAL,
-            metric_value=metric_value,
             date_started=incident.date_started,
         ).build() == {
             "blocks": [
@@ -965,11 +962,10 @@ def test_chart(self):
         )
         assert SlackIncidentsMessageBuilder(
             alert_context=AlertContext.from_alert_rule_incident(alert_rule),
-            open_period_identifier=incident.identifier,
+            metric_issue_context=MetricIssueContext.from_legacy_models(
+                incident, IncidentStatus.CLOSED, 0
+            ),
             organization=self.organization,
-            snuba_query=alert_rule.snuba_query,
-            new_status=IncidentStatus.CLOSED,
-            metric_value=0,
             date_started=incident.date_started,
             chart_url="chart-url",
         ).build() == {
@@ -1021,11 +1017,10 @@ def test_metric_alert_with_anomaly_detection(self, mock_seer_request):
         )
         assert SlackIncidentsMessageBuilder(
             alert_context=AlertContext.from_alert_rule_incident(alert_rule),
-            open_period_identifier=incident.identifier,
+            metric_issue_context=MetricIssueContext.from_legacy_models(
+                incident, IncidentStatus.CRITICAL, 0
+            ),
             organization=self.organization,
-            snuba_query=alert_rule.snuba_query,
-            new_status=IncidentStatus.CRITICAL,
-            metric_value=0,
             date_started=incident.date_started,
         ).build() == {
             "blocks": [