feat(metric-issues): Add threshold to metric issue title (#86301)

Specify the threshold if possible for the metric issue title string

Author: snigdhas

src/sentry/incidents/utils/metric_issue_poc.py

@@ -6,8 +6,9 @@
 from django.utils.translation import gettext as _
 
 from sentry import features
-from sentry.incidents.models.alert_rule import AlertRule, AlertRuleThresholdType
-from sentry.incidents.models.incident import Incident, IncidentStatus
+from sentry.constants import CRASH_RATE_ALERT_AGGREGATE_ALIAS
+from sentry.incidents.models.alert_rule import AlertRule, AlertRuleThresholdType, AlertRuleTrigger
+from sentry.incidents.models.incident import INCIDENT_STATUS, Incident, IncidentStatus
 from sentry.incidents.utils.format_duration import format_duration_idiomatic
 from sentry.integrations.metric_alerts import TEXT_COMPARISON_DELTA
 from sentry.issues.grouptype import MetricIssuePOC
@@ -43,16 +44,21 @@ def to_dict(self) -> dict[str, Any]:
     "count_unique(tags[sentry:user])": "Number of users affected",
     "percentage(sessions_crashed, sessions)": "Crash free session rate",
     "percentage(users_crashed, users)": "Crash free user rate",
+    "failure_rate()": "Failure rate",
+    "apdex()": "Apdex score",
 }
 
 
-def construct_title(alert_rule: AlertRule) -> str:
+def construct_title(alert_rule: AlertRule, status: int) -> str:
     # Parse the aggregate key from the alert rule
     agg_display_key = alert_rule.snuba_query.aggregate
     if is_mri_field(agg_display_key):
-        agg_text = format_mri_field(agg_display_key)
+        aggregate = format_mri_field(agg_display_key)
+    elif CRASH_RATE_ALERT_AGGREGATE_ALIAS in agg_display_key:
+        agg_display_key = agg_display_key.split(f"AS {CRASH_RATE_ALERT_AGGREGATE_ALIAS}")[0].strip()
+        aggregate = QUERY_AGGREGATION_DISPLAY.get(agg_display_key, agg_display_key)
     else:
-        agg_text = QUERY_AGGREGATION_DISPLAY.get(agg_display_key, alert_rule.snuba_query.aggregate)
+        aggregate = QUERY_AGGREGATION_DISPLAY.get(agg_display_key, alert_rule.snuba_query.aggregate)
 
     # Determine the higher or lower comparison
     higher_or_lower = ""
@@ -61,19 +67,35 @@ def construct_title(alert_rule: AlertRule) -> str:
     else:
         higher_or_lower = "less than" if alert_rule.comparison_delta else "below"
 
+    label = INCIDENT_STATUS[IncidentStatus(status)]
+
     # Format the time window for the threshold
-    time_window = alert_rule.snuba_query.time_window // 60
-    title = f"{agg_text} in the last {format_duration_idiomatic(time_window)} {higher_or_lower}"
+    time_window = format_duration_idiomatic(alert_rule.snuba_query.time_window // 60)
 
     # If the alert rule has a comparison delta, format the comparison string
+    comparison: str | int | float = "threshold"
     if alert_rule.comparison_delta:
         comparison_delta_minutes = alert_rule.comparison_delta // 60
-        comparison_string = TEXT_COMPARISON_DELTA.get(
-            comparison_delta_minutes, f"same time {comparison_delta_minutes} minutes ago"
+        comparison = TEXT_COMPARISON_DELTA.get(
+            comparison_delta_minutes, f"same time {comparison_delta_minutes} minutes ago "
         )
-        return _(f"{title} {comparison_string}")
-
-    return _(f"{title} threshold")
+    else:
+        # Otherwise, check if there is a trigger with a threshold
+        trigger = AlertRuleTrigger.objects.filter(id=alert_rule.id, label=label.lower()).first()
+        if trigger:
+            threshold = trigger.alert_threshold
+            comparison = int(threshold) if threshold % 1 == 0 else threshold
+
+    template = "{label}: {metric} in the last {time_window} {higher_or_lower} {comparison}"
+    return _(
+        template.format(
+            label=label.capitalize(),
+            metric=aggregate,
+            higher_or_lower=higher_or_lower,
+            comparison=comparison,
+            time_window=time_window,
+        )
+    )
 
 
 def _build_occurrence_from_incident(
@@ -88,7 +110,7 @@ def _build_occurrence_from_incident(
         else PriorityLevel.MEDIUM
     )
     fingerprint = [str(incident.alert_rule.id)]
-    title = construct_title(incident.alert_rule)
+    title = construct_title(incident.alert_rule, incident.status)
     return IssueOccurrence(
         id=uuid4().hex,
         project_id=project.id,

tests/sentry/incidents/utils/test_metric_issue_poc.py

@@ -91,8 +91,8 @@ def test_resolved_incident(self):
         assert group.priority == PriorityLevel.MEDIUM
 
     def test_construct_title(self):
-        title = construct_title(self.alert_rule)
-        assert title == "Number of events in the last 10 minutes above threshold"
+        title = construct_title(self.alert_rule, self.incident.status)
+        assert title == "Critical: Number of events in the last 10 minutes above threshold"
 
         alert_rule = self.create_alert_rule(
             organization=self.organization,
@@ -105,10 +105,10 @@ def test_construct_title(self):
             comparison_delta=60,
         )
 
-        title = construct_title(alert_rule)
+        title = construct_title(alert_rule, self.incident.status)
         assert (
             title
-            == "Number of users affected in the last 10 minutes greater than same time one hour ago"
+            == "Critical: Number of users affected in the last 10 minutes greater than same time one hour ago"
         )
 
         alert_rule = self.create_alert_rule(
@@ -121,5 +121,5 @@ def test_construct_title(self):
             threshold_type=AlertRuleThresholdType.BELOW,
         )
 
-        title = construct_title(alert_rule)
-        assert title == "Crash free session rate in the last 10 minutes below threshold"
+        title = construct_title(alert_rule, 10)
+        assert title == "Warning: Crash free session rate in the last 10 minutes below threshold"