Skip to content

Commit 2555714

Browse files
committed
Merge branch 'mz/add-flags-audit-log-drawer' of github.com:getsentry/sentry into aliu/ff-dist-cta
2 parents e3c6f06 + 24d9343 commit 2555714

File tree

3 files changed

+43
-5
lines changed

3 files changed

+43
-5
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
import styled from '@emotion/styled';
2+
3+
import Link from 'sentry/components/links/link';
4+
import {useLocation} from 'sentry/utils/useLocation';
5+
import type {GroupTag} from 'sentry/views/issueDetails/groupTags/useGroupTags';
6+
7+
export default function FlagDetailsLink({
8+
tag,
9+
children,
10+
}: {
11+
children: React.ReactNode;
12+
tag: GroupTag;
13+
}) {
14+
const location = useLocation();
15+
16+
return (
17+
<StyledLink
18+
to={{
19+
pathname: `${location.pathname}${tag.key}/`,
20+
query: location.query,
21+
}}
22+
>
23+
{children}
24+
</StyledLink>
25+
);
26+
}
27+
28+
const StyledLink = styled(Link)`
29+
border-radius: ${p => p.theme.borderRadius};
30+
display: block;
31+
32+
&:hover h5 {
33+
text-decoration: underline;
34+
}
35+
`;

static/app/views/issueDetails/groupFeatureFlags/groupFeatureFlagsDrawerContent.tsx

+7-5
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ import {t} from 'sentry/locale';
77
import type {Group} from 'sentry/types/group';
88
import useOrganization from 'sentry/utils/useOrganization';
99
import useProjectFromSlug from 'sentry/utils/useProjectFromSlug';
10+
import FlagDetailsLink from 'sentry/views/issueDetails/groupFeatureFlags/flagDetailsLink';
1011
import FlagDrawerCTA from 'sentry/views/issueDetails/groupFeatureFlags/flagDrawerCTA';
1112
import useGroupFeatureFlags from 'sentry/views/issueDetails/groupFeatureFlags/useGroupFeatureFlags';
1213
import {
1314
Container,
1415
StyledEmptyStateWarning,
1516
} from 'sentry/views/issueDetails/groupTags/groupTagsDrawer';
16-
import TagDetailsLink from 'sentry/views/issueDetails/groupTags/tagDetailsLink';
1717
import {TagDistribution} from 'sentry/views/issueDetails/groupTags/tagDistribution';
1818
import type {GroupTag} from 'sentry/views/issueDetails/groupTags/useGroupTags';
1919

@@ -87,10 +87,12 @@ export default function GroupFeatureFlagsDrawerContent({
8787
</StyledEmptyStateWarning>
8888
) : (
8989
<Container>
90-
{displayTags.map((tag, tagIdx) => (
91-
<TagDetailsLink tag={tag} groupId={group.id} key={tagIdx}>
92-
<TagDistribution tag={tag} key={tagIdx} />
93-
</TagDetailsLink>
90+
{displayTags.map(tag => (
91+
<div key={tag.name}>
92+
<FlagDetailsLink tag={tag} key={tag.name}>
93+
<TagDistribution tag={tag} key={tag.name} />
94+
</FlagDetailsLink>
95+
</div>
9496
))}
9597
</Container>
9698
);

static/app/views/issueDetails/groupTags/useGroupTagsDrawer.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export function useGroupTagsDrawer({
3535
...location.query,
3636
tagDrawerSort: undefined,
3737
tab: undefined,
38+
flagDrawerCursor: undefined,
3839
},
3940
},
4041
{replace: true}

0 commit comments

Comments
 (0)