cap at 3 actions, simplify description

Author: ceorourke

src/sentry/workflow_engine/migration_helpers/utils.py

@@ -4,18 +4,18 @@
 from sentry.models.team import Team
 from sentry.users.services.user import RpcUser
 
-MAX_CHARS = 248  # (256 minus space for '...(+3_)')
+MAX_ACTIONS = 3
 
 
 def get_action_description(action: AlertRuleTriggerAction) -> str:
     """
     Returns a human readable action description
     """
-    action_type_to_string = {
-        AlertRuleTriggerAction.Type.PAGERDUTY.value: f"PagerDuty to {action.target_display}",
-        AlertRuleTriggerAction.Type.SLACK.value: f"Slack {action.target_display}",
-        AlertRuleTriggerAction.Type.MSTEAMS.value: f"Microsoft Teams {action.target_display}",
-        AlertRuleTriggerAction.Type.SENTRY_APP.value: f"Notify {action.target_display}",
+    ACTION_TYPE_TO_STRING = {
+        AlertRuleTriggerAction.Type.PAGERDUTY.value: "PagerDuty",
+        AlertRuleTriggerAction.Type.SLACK.value: "Slack",
+        AlertRuleTriggerAction.Type.MSTEAMS.value: "Microsoft Teams",
+        AlertRuleTriggerAction.Type.OPSGENIE.value: "Opsgenie",
     }
 
     if action.type == AlertRuleTriggerAction.Type.EMAIL.value:
@@ -26,13 +26,10 @@ def get_action_description(action: AlertRuleTriggerAction) -> str:
             elif action.target_type == AlertRuleTriggerAction.TargetType.TEAM.value:
                 action_target_team = cast(Team, action.target)
                 return "Email #" + action_target_team.slug
-    elif action.type == AlertRuleTriggerAction.Type.OPSGENIE.value:
-        return f"Opsgenie to {action.target_display}"
-    elif action.type == AlertRuleTriggerAction.Type.DISCORD.value:
-        return f"Discord to {action.target_display}"
-    else:
-        return action_type_to_string[action.type]
-    return ""
+    elif action.type == AlertRuleTriggerAction.Type.SENTRY_APP.value:
+        return f"Notify {action.target_display}"
+
+    return f"Notify {action.target_display} via {ACTION_TYPE_TO_STRING[action.type]}"
 
 
 def get_workflow_name(alert_rule: AlertRule) -> str:
@@ -54,7 +51,7 @@ def get_workflow_name(alert_rule: AlertRule) -> str:
         for action in actions.filter(alert_rule_trigger_id=trigger.id):
             description = get_action_description(action) + ", "
 
-            if len(name) + len(description) <= MAX_CHARS:
+            if actions_counter < MAX_ACTIONS:
                 name += description
                 actions_counter += 1
             else:

tests/sentry/workflow_engine/migration_helpers/test_utils.py

@@ -1,5 +1,3 @@
-from unittest import mock
-
 from sentry.incidents.models.alert_rule import AlertRuleTriggerAction
 from sentry.integrations.models.integration import Integration
 from sentry.integrations.models.organization_integration import OrganizationIntegration
@@ -95,10 +93,9 @@ def test_warning_and_critical(self):
             == f"Critical - Email {self.rpc_user.email}, Warning - Email {self.rpc_user.email}"
         )
 
-    @mock.patch("sentry.workflow_engine.migration_helpers.utils.MAX_CHARS", 50)
     def test_many_actions(self):
         """
-        Test that if we have so many actions we exceed the char limit we format the name as expected
+        Test that if we have more than 3 actions we format the name as expected
         """
         user2 = self.create_user(email="meow@woof.com")
         user3 = self.create_user(email="bark@meow.com")
@@ -124,7 +121,10 @@ def test_many_actions(self):
         workflow = Workflow.objects.get(id=alert_rule_workflow.workflow.id)
 
         assert self.rpc_user
-        assert workflow.name == f"Email {self.rpc_user.email}, Email {user2.email}...(+2)"
+        assert (
+            workflow.name
+            == f"Email {self.rpc_user.email}, Email {user2.email}, Email {user3.email}...(+1)"
+        )
 
     def test_with_integrations(self):
         """
@@ -169,5 +169,5 @@ def test_with_integrations(self):
         assert self.rpc_user
         assert (
             workflow.name
-            == f"Critical - Email {self.rpc_user.email}, Opsgenie to {self.og_team_table["team"]}, Warning - Email #{self.og_team.slug}, Notify {self.sentry_app.name}, Slack {slack_channel_name}"
+            == f"Critical - Email {self.rpc_user.email}, Notify {self.og_team_table["team"]} via {self.opsgenie_integration.provider.title()}, Warning - Email #{self.og_team.slug}...(+2)"
         )