Skip to content

Commit 2f614ce

Browse files
ref: remove try around parse_size
given the parser input values it cannot fail
1 parent a7cd980 commit 2f614ce

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

src/sentry/api/event_search.py

+3-12
Original file line numberDiff line numberDiff line change
@@ -891,11 +891,8 @@ def visit_size_filter(self, node, children):
891891
operator = get_operator_value(operator)
892892

893893
if self.is_size_key(search_key.name):
894-
try:
895-
search_value = parse_size(*search_value)
896-
except InvalidQuery as exc:
897-
raise InvalidSearchQuery(str(exc))
898-
return SearchFilter(search_key, operator, SearchValue(search_value))
894+
search_value_f = parse_size(*search_value)
895+
return SearchFilter(search_key, operator, SearchValue(search_value_f))
899896

900897
search_value = "".join(search_value)
901898
search_value = operator + search_value if operator not in ("=", "!=") else search_value
@@ -989,13 +986,7 @@ def visit_aggregate_size_filter(self, node, children):
989986
(negation, search_key, _, operator, search_value) = children
990987
operator = handle_negation(negation, operator)
991988

992-
try:
993-
aggregate_value = parse_size(*search_value)
994-
except ValueError:
995-
raise InvalidSearchQuery(f"Invalid aggregate query condition: {search_key}")
996-
except InvalidQuery as exc:
997-
raise InvalidSearchQuery(str(exc))
998-
989+
aggregate_value = parse_size(*search_value)
999990
return AggregateFilter(search_key, operator, SearchValue(aggregate_value))
1000991

1001992
def visit_aggregate_percentage_filter(self, node, children):

0 commit comments

Comments
 (0)