Skip to content

Commit 411715c

Browse files
fix(apis): user details apis should return email in response (#87049)
Fixes GH-77000
1 parent 5a95f38 commit 411715c

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

src/sentry/users/api/endpoints/user_details.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -209,9 +209,14 @@ def put(self, request: Request, user: User) -> Response:
209209
:param string default_issue_event: Event displayed by default, "recommended", "latest" or "oldest"
210210
:auth: required
211211
"""
212-
if "username" in request.data:
212+
email = None
213+
if "email" in request.data and len(request.data["email"]) > 0:
214+
email = request.data["email"]
215+
elif "username" in request.data and len(request.data["username"]) > 0:
216+
email = request.data["username"]
217+
if email:
213218
verified_email_found = UserEmail.objects.filter(
214-
user_id=user.id, email=request.data["username"], is_verified=True
219+
user_id=user.id, email=email, is_verified=True
215220
).exists()
216221
if not verified_email_found:
217222
return Response({"detail": "Verified email address is not found."}, status=400)

tests/sentry/users/api/endpoints/test_user_details.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,11 @@ def test_change_username_when_different(self):
184184
self.login_as(user=user, superuser=False)
185185

186186
self.create_useremail(user, "[email protected]", is_verified=True)
187-
self.get_success_response("me", username="[email protected]")
188-
187+
response = self.get_success_response("me", username="[email protected]")
189188
user = User.objects.get(id=user.id)
190189

191190
assert user.email == "[email protected]"
191+
assert response.data["email"] == "[email protected]"
192192
assert user.username == "[email protected]"
193193

194194
def test_change_username_when_same(self):

0 commit comments

Comments
 (0)