Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 4b46b96

Browse files
committedMar 18, 2025·
♻️ pr comments 1
1 parent f8e8f6a commit 4b46b96

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed
 

‎static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.spec.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ describe('FlagDetailsDrawerContent', () => {
112112
render(<FlagDetailsDrawerContent />, {router});
113113

114114
expect(
115-
await screen.findByText('No audit log events were found for this flag.')
115+
await screen.findByText('No audit logs were found for this featureflag.')
116116
).toBeInTheDocument();
117117
});
118118
});

‎static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export function FlagDetailsDrawerContent() {
7676
if (!flagLog.data.length) {
7777
return (
7878
<EmptyStateWarning withIcon={false} small>
79-
{t('No audit log events were found for this flag.')}
79+
{t('No audit logs were found for this feature flag.')}
8080
</EmptyStateWarning>
8181
);
8282
}

‎static/app/views/issueDetails/groupTags/groupTagsDrawer.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ export function GroupTagsDrawer({
173173
const location = useLocation();
174174
const organization = useOrganization();
175175
const environments = useEnvironmentsFromUrl();
176+
// XXX: tagKey param is re-used for feature flag details drawer
176177
const {tagKey} = useParams<{tagKey: string}>();
177178
const drawerRef = useRef<HTMLDivElement>(null);
178179
const {projects} = useProjects();
@@ -346,7 +347,7 @@ export function GroupTagsDrawer({
346347
to: tagKey
347348
? {
348349
pathname: `${baseUrl}${TabPaths[Tab.TAGS]}`,
349-
query: {tab: FEATURE_FLAGS_TAB, ...location.query},
350+
query: {...location.query, tab: FEATURE_FLAGS_TAB},
350351
}
351352
: undefined,
352353
},

‎static/app/views/issueDetails/streamline/featureFlagUtils.tsx

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import styled from '@emotion/styled';
2+
13
import {Tag} from 'sentry/components/core/badge/tag';
24

35
export type RawFlag = {
@@ -45,11 +47,15 @@ export function getFlagActionLabel(action: string) {
4547
const labelType =
4648
action === 'created' ? 'info' : action === 'deleted' ? 'error' : undefined;
4749

48-
const capitalized = action.toUpperCase();
50+
const capitalized = action.charAt(0).toUpperCase() + action.slice(1);
4951

5052
return (
51-
<div style={{alignSelf: 'flex-start'}}>
53+
<ActionLabel>
5254
<Tag type={labelType}>{capitalized}</Tag>
53-
</div>
55+
</ActionLabel>
5456
);
5557
}
58+
59+
const ActionLabel = styled('div')`
60+
align-self: flex-start;
61+
`;

0 commit comments

Comments
 (0)
Please sign in to comment.