Merge branch 'master' into lms/feat-previous-trace-links

Author: s1gr1d

.github/CODEOWNERS

@@ -68,7 +68,7 @@ updates:
     schedule:
       interval: 'daily'
     reviewers:
-      - '@getsentry/open-source'
+      - '@getsentry/dev-infra'
       - '@getsentry/security'
     # security only updates
     open-pull-requests-limit: 0

.github/dependabot.yml

@@ -31,8 +31,8 @@ typecheckable_rules_changed: &typecheckable_rules_changed
 # Trigger to apply the 'Scope: Frontend' label to PRs
 frontend_all: &frontend_all
   - added|modified: '**/*.[tj]{s,sx}'
-  - added|modified: '**/*.{less,json,yml,md}'
-  - added|modified: '{.volta,vercel}.json'
+  - added|modified: 'static/**/*.{less,json,yml,md}'
+  - added|modified: '{.volta,vercel,tsconfig,biome,package}.json'
 
 # Also used in `getsentry-dispatch.yml` to dispatch backend tests on getsentry
 backend_dependencies: &backend_dependencies
@@ -66,6 +66,7 @@ backend_all: &backend_all
   - *backend_src
   - '**/*.py'
   - '**/*.pyi'
+  - 'devservices/**'
 
 # This is the ultimate controller for acceptance.yml
 acceptance: &acceptance

.github/file-filters.yml

@@ -19,8 +19,6 @@ concurrency:
 env:
   SEGMENT_DOWNLOAD_TIMEOUT_MINS: 3
   NODE_OPTIONS: '--max-old-space-size=4096'
-  # Disables sentry reporting for devservices
-  DEVSERVICES_DISABLE_SENTRY: 1
   CHARTCUTERIE_CONFIG_PATH: ${{ github.workspace }}/config/chartcuterie
   SNUBA_NO_WORKERS: 1
 

.github/workflows/acceptance.yml

@@ -15,8 +15,6 @@ concurrency:
 # hack for https://github.com/actions/cache/issues/810#issuecomment-1222550359
 env:
   SEGMENT_DOWNLOAD_TIMEOUT_MINS: 3
-  # Disables sentry reporting for devservices
-  DEVSERVICES_DISABLE_SENTRY: 1
   SNUBA_NO_WORKERS: 1
 
 jobs:

.github/workflows/backend.yml

@@ -60,7 +60,6 @@ jobs:
         uses: ./.github/actions/setup-sentry
         id: setup
         with:
-          use-new-devservices: true
           mode: backend-ci
       - name: Download Codecov CLI
         run: |

.github/workflows/codecov_ats.yml

@@ -36,7 +36,6 @@ jobs:
         uses: ./.github/actions/setup-sentry
         id: setup
         with:
-          use-new-devservices: true
           mode: backend-ci
 
       - name: Run backend test (${{ steps.setup.outputs.matrix-instance-number }} of ${{ steps.setup.outputs.matrix-instance-total }}) with --cov-context=test

.github/workflows/codecov_per_test_coverage.yml

@@ -130,9 +130,9 @@ jobs:
           DEBUG_PRINT_LIMIT: 0
         run: |
           if [ ${{ github.ref }} = 'refs/heads/master' ]; then
-            JEST_TESTS=$(yarn -s jest --listTests --json) yarn test-ci --forceExit --coverage
+            yarn test-ci --forceExit --coverage
           else
-            JEST_TESTS=$(yarn -s jest --listTests --json) yarn test-ci --forceExit
+            yarn test-ci --forceExit
           fi
 
       # We only upload coverage data for FE changes since it conflicts with

.github/workflows/frontend.yml

@@ -53,7 +53,6 @@ jobs:
       - name: Setup sentry env
         uses: ./.github/actions/setup-sentry
         with:
-          use-new-devservices: true
           mode: migrations
 
       - name: Apply migrations

.github/workflows/migrations.yml

@@ -30,7 +30,6 @@ jobs:
       - name: Setup sentry env
         uses: ./.github/actions/setup-sentry
         with:
-          use-new-devservices: true
           mode: migrations
         if: steps.changes.outputs.api_docs == 'true'
 

.github/workflows/openapi-diff.yml

@@ -32,7 +32,6 @@ jobs:
       - name: Setup sentry env
         uses: ./.github/actions/setup-sentry
         with:
-          use-new-devservices: true
           mode: migrations
         if: steps.changes.outputs.api_docs == 'true'
 

.github/workflows/openapi.yml

@@ -7,10 +7,6 @@
  *              deleted/renamed in `getsentry`, this will fail
  */
 const DISPATCHES = [
-  {
-    workflow: 'js-build-and-lint.yml',
-    pathFilterName: 'frontend_all',
-  },
   {
     workflow: 'backend.yml',
     pathFilterName: 'backend_all',

.github/workflows/scripts/getsentry-dispatch.js

@@ -52,7 +52,6 @@ jobs:
         uses: ./.github/actions/setup-sentry
         id: setup
         with:
-          use-new-devservices: true
           mode: backend-ci
 
       - name: Run backend test (${{ steps.setup.outputs.matrix-instance-number }} of ${{ steps.setup.outputs.matrix-instance-total }})

.github/workflows/shuffle-tests.yml

@@ -1,3 +1,113 @@
+25.3.0
+------
+
+### Automate Code Mappings & In-App Stack Trace Rules for Java projects (ongoing)
+
+Currently, we ask developers to set up their Java code mappings manually (because the SDK cannot determine it):
+https://docs.sentry.io/platforms/java/source-context/#setting-up-code-mappings
+
+Unfortunately, many stack traces do not contain in-app frames, thus, many Sentry features are not available (e.g. SCM linking, suspect commit).
+
+This tracks using the code mappings derivation system to automatically add the code mappings and stack trace rules to mark in-app frames as such.
+
+This will automatically enable the following Sentry features :
+- Suspect Commits
+- GitHub pull request comments
+- Auto-assignments (if Codeowners imported)
+- Stack trace linking
+- Code coverage (if the customer also has an account)
+
+This will only be available to customers with the GitHub integration installed.
+
+You can read more about the system here:
+https://blog.sentry.io/code-mappings-and-why-they-matter/
+
+By: @armenzg (#86283, #86327, #86280, #86196, #86188, #86189, #86109, #86026, #85981, #85976, #85931, #85742)
+
+### Various fixes & improvements
+
+- Revert "chore(sentry apps): add SLO context manager for send alert event (issue alerts) (#86356)" (fa6491f2) by @getsentry-bot
+- fix(autofix): Fix running autofix after all issue summaries (#87134) by @jennmueng
+- fix(data-consent): Fix non touch customers seeing msa prompt (#87133) by @jennmueng
+- fix(eap-spans): count_op should use `score.total` (#87132) by @DominikB2014
+- chore(sentry apps): Add context manager for comment webhook SLOs (#86739) by @Christinarlong
+- feat(devenv): Skip `devenv sync` call when we have FE changes and env var is set (#87112) by @wedamija
+- feat(insights): make score easier to query (#87129) by @DominikB2014
+- chore(issue-details): Fix a few things about issue guide (#87122) by @leeandher
+- feat(issue-views): Improve drag handle and safari interactions (#87119) by @MichaelSun48
+- :recycle: ref(aci): remove alert rule from metric alert chart building logic (#87103) by @iamrajjoshi
+- fix(jira): Add a 'key_id' block list for JIRA installed webhook endpoint (#87086) by @Christinarlong
+- fix(event_manager): Resolve TypeError while recording first insight span (#87123) by @jan-auer
+- chore(sentry apps): add SLO context manager for send alert event (issue alerts) (#86356) by @Christinarlong
+- ref(feedback): add evidence test coverage and send alerts if source is none (#87121) by @aliu39
+- feat(releases): Change "version" to "release" in table (#87088) by @billyvg
+- feat(releases): Change release bubbles series color to match bubbles (#87109) by @billyvg
+- test(react19): Wait for text in billingPlans.spec.tex (#87120) by @scttcper
+- ref(tsc): convert projectPlugins details to FC (#87035) by @michellewzhang
+- chore(issues): Opt more modules into stronger typing (#87117) by @mrduncan
+- feat(ui): Move checkInTimeline underscan to the left (#87096) by @evanpurkhiser
+- fix(aci): ANY_SHORT_CIRCUIT early exit (#87114) by @cathteng
+- test(react19): Adjust widgetViewerModal for react 19 (#87110) by @scttcper
+- chore(uptime): Commit test helpers for getsentry (#87115) by @wedamija
+- feat(insights): add most related issues to backend (#87033) by @DominikB2014
+
+_Plus 1390 more_
+
+25.2.0
+------
+
+### Automate Code Mappings & In-App Stack Trace Rules for Java projects (ongoing)
+
+Currently, we ask developers to set up their Java code mappings manually (because the SDK cannot determine it):
+https://docs.sentry.io/platforms/java/source-context/#setting-up-code-mappings
+
+Unfortunately, many stack traces do not contain in-app frames, thus, many Sentry features are not available (e.g. SCM linking, suspect commit).
+
+This tracks using the code mappings derivation system to automatically add the code mappings and stack trace rules to mark in-app frames as such.
+
+This will automatically enable the following Sentry features :
+- Suspect Commits
+- GitHub pull request comments
+- Auto-assignments (if Codeowners imported)
+- Stack trace linking
+- Code coverage (if the customer also has an account)
+
+This will only be available to customers with the GitHub integration installed.
+
+You can read more about the system here:
+https://blog.sentry.io/code-mappings-and-why-they-matter/
+
+By: @armenzg (#85174, #85065)
+
+### Various fixes & improvements
+
+- Revert "feat(autofix): Add Autofix status to sidebar button (#85287)" (b20e50ed) by @getsentry-bot
+- fix(autofix): Fix flash on initial run (#85299) by @roaga
+- feat(autofix): Add Autofix status to sidebar button (#85287) by @roaga
+- fix(issues): Left align commit authors (#85291) by @scttcper
+- :sparkles: feat(aci): add support for sentry apps for issue alerts in NOA (#85218) by @iamrajjoshi
+- feat(crons): Implement an all checks page for crons (#85202) by @leeandher
+- fix(apidocs): fix typo in user feedback api (#85280) by @michellewzhang
+- ref(dashboards): Namespaced `Widget` components (#85238) by @gggritso
+- ref(uptime): Remove config_topic from UptimeRegionConfig (#85155) by @evanpurkhiser
+- ref(seer grouping): Add ability to ignore useless filenames (#85277) by @lobsterkatie
+- fix(auto_source_config): Handle when the frame is None (#85235) by @armenzg
+- feat(issues): Disable delete on missing permission (#85278) by @scttcper
+- fix(widget-builder): Visualize field overflows on long field names (#85271) by @nikkikapadia
+- feat(nav): Update rest of alert links to use new pathname builder (#85257) by @malwilley
+- fix(profiling): Prevent landing page from scrolling on context menu (#85273) by @Zylphrex
+- ref: remove default margin from Alert in sentry (#85128) by @michellewzhang
+- feat(taskworker) Add metrics for RPC durations (#85194) by @markstory
+- feat(nav): Update alert links from explore/insights/crons (#85254) by @malwilley
+- feat(nav): Update replay onboarding to use drawer (#85267) by @malwilley
+- ref(crons): Rename parallel field -> batched_parallel (#85261) by @evanpurkhiser
+- Reapply "ref(crons): Remove parallel mode (batched-parallel replaced it)" (#85262) by @evanpurkhiser
+- ref(widget-builder): Extract selection components (#85248) by @narsaynorath
+- chore(apis): Publish GroupExternalIssue endpoint (#85184) by @Christinarlong
+- ref: get_group_{body,title,description} to not need request (#85263) by @asottile-sentry
+
+_Plus 1429 more_
+
 25.1.0
 ------
 

CHANGES

@@ -1,7 +1,7 @@
 {
   "get": {
     "tags": ["Projects"],
-    "description": "Return a list of user feedback items within this project.\n\n*This list does not include submissions from the [User Feedback Widget](https://docs.sentry.io/product/user-feedback/#user-feedback-widget). This is because it is based on an older format called User Reports - read more [here](https://develop.sentry.dev/application/feedback-architecture/#user-reports). To return a list of user feedback items from the widget, please use the [issue API](https://docs.sentry.io/api/events/list-a-projects-issues/)* with the filter `issue.category:feedback`.*",
+    "description": "Return a list of user feedback items within this project.\n\n*This list does not include submissions from the [User Feedback Widget](https://docs.sentry.io/product/user-feedback/#user-feedback-widget). This is because it is based on an older format called User Reports - read more [here](https://develop.sentry.dev/application/feedback-architecture/#user-reports). To return a list of user feedback items from the widget, please use the [issue API](https://docs.sentry.io/api/events/list-a-projects-issues/) with the filter `issue.category:feedback`.*",
     "operationId": "List a Project's User Feedback",
     "parameters": [
       {

api-docs/paths/projects/user-feedback.json

@@ -13,7 +13,7 @@ const config: TransformOptions = {
       '@babel/preset-env',
       {
         useBuiltIns: 'usage',
-        corejs: '3.37',
+        corejs: '3.41',
       },
     ],
     // TODO: Remove allowDeclareFields when we upgrade to Babel 8

babel.config.ts

@@ -61,9 +61,5 @@ def generate_outcomes():
                 )
 
 
-def drop_outcomes():
-    assert requests.post(settings.SENTRY_SNUBA + "/tests/entities/outcomes/drop").status_code == 200
-
-
 if __name__ == "__main__":
     generate_outcomes()

bin/mock-outcomes

@@ -6,7 +6,6 @@ from sentry.runner import configure
 from sentry.utils.json import dumps_htmlsafe
 
 configure()
-import pathlib
 import uuid
 from datetime import datetime, timedelta
 
@@ -88,11 +87,6 @@ def store_replay_segments(replay_id: str, project_id: int, segment_id: int, segm
     )
 
 
-def make_filename(filename: str) -> str:
-    parent_dir = pathlib.Path(__file__).parent.resolve()
-    return f"{parent_dir}/rrweb-output/{filename}"
-
-
 def main():
     project_name = "Replay Test Project"
 

bin/mock-replay

@@ -0,0 +1,79 @@
+#!/usr/bin/env python
+"""Insert mock replay recording messages into the INGEST_REPLAYS_RECORDINGS topic.
+
+Helpful commands:
+
+    - Run the consumer.
+        - `sentry run consumer ingest-replay-recordings --consumer-group 0`
+        - `sentry run consumer ingest-replay-recordings-two-step --consumer-group 0`
+    - Check if offsets are committed correctly.
+        - `docker exec -it kafka-kafka-1 kafka-consumer-groups --bootstrap-server localhost:9092 --describe --group 0`
+"""
+
+import logging
+import os
+import time
+import uuid
+
+import click
+import django
+from arroyo import Topic as ArroyoTopic
+from arroyo.backends.kafka import KafkaPayload, KafkaProducer, build_kafka_configuration
+from sentry_kafka_schemas.codecs import Codec
+from sentry_kafka_schemas.schema_types.ingest_replay_recordings_v1 import ReplayRecording
+
+from sentry.conf.types.kafka_definition import Topic, get_topic_codec
+from sentry.runner import configure
+from sentry.utils.kafka_config import get_kafka_producer_cluster_options, get_topic_definition
+
+configure()
+
+os.environ.setdefault("DJANGO_SETTINGS_MODULE", "sentry.conf.server")
+
+
+django.setup()
+
+
+logger = logging.getLogger(__name__)
+
+
+def get_producer() -> KafkaProducer:
+    cluster_name = get_topic_definition(Topic.INGEST_REPLAYS_RECORDINGS)["cluster"]
+    producer_config = get_kafka_producer_cluster_options(cluster_name)
+    return KafkaProducer(build_kafka_configuration(default_config=producer_config))
+
+
+RECORDING_CODEC: Codec[ReplayRecording] = get_topic_codec(Topic.INGEST_REPLAYS_RECORDINGS)
+
+
+@click.command()
+@click.option("--organization-id", type=int, required=True, help="Organization ID")
+@click.option("--project-id", type=int, required=True, help="Project ID")
+def main(organization_id: int, project_id: int) -> None:
+    """Produce a mock uptime result message to the INGEST_REPLAYS_RECORDINGS topic."""
+    message: ReplayRecording = {
+        "key_id": None,
+        "org_id": organization_id,
+        "payload": b'{"segment_id":0}\n[]',
+        "project_id": project_id,
+        "received": int(time.time()),
+        "replay_event": None,
+        "replay_id": uuid.uuid4().hex,
+        "replay_video": None,
+        "retention_days": 30,
+        "type": "replay_recording_not_chunked",
+        "version": 1,
+    }
+
+    producer = get_producer()
+    topic = get_topic_definition(Topic.INGEST_REPLAYS_RECORDINGS)["real_topic_name"]
+    payload = KafkaPayload(None, RECORDING_CODEC.encode(message), [])
+
+    producer.produce(ArroyoTopic(topic), payload)
+    producer.close()
+
+    logger.info("Successfully produced message to %s", topic)
+
+
+if __name__ == "__main__":
+    main()

bin/mock-replay-recording

@@ -11,7 +11,12 @@ trap "rm -f $files_changed_upstream" EXIT
 
 git diff-tree -r --name-only --no-commit-id ORIG_HEAD HEAD >"$files_changed_upstream"
 
-if grep --quiet 'requirements-dev-frozen.txt' "$files_changed_upstream" || grep --quiet 'yarn.lock' "$files_changed_upstream" || grep --quiet 'migrations' "$files_changed_upstream"; then
+grep_pattern="requirements-dev-frozen.txt|migrations"
+if [[ "$SENTRY_DEVENV_SKIP_FRONTEND" != "1" ]]; then
+  grep_pattern+="|yarn.lock"
+fi
+
+if grep -E --quiet "$grep_pattern" "$files_changed_upstream"; then
   cat <<EOF
 
 [${red}${bold}!!!${reset}] ${red} It looks like some dependencies have changed. Run devenv sync to resync your environment.${reset}