Skip to content

Commit 723a35f

Browse files
authoredJan 28, 2025
fix(feedback): make lookups safe in debug log (#84207)
Fixes [SENTRY-3MTR](https://sentry.sentry.io/issues/6250996998/) Surfaced by #83762 (comment)
1 parent 603ab01 commit 723a35f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎src/sentry/feedback/usecases/create_feedback.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -205,16 +205,16 @@ def should_filter_feedback(event, project_id, source: FeedbackCreationSource):
205205
# Temporary log for debugging.
206206
if random.random() < 0.1:
207207
project = Project.objects.get_from_cache(id=project_id)
208-
contexts = event.get("contexts", {})
209-
feedback = contexts.get("feedback", {})
208+
contexts = event.get("contexts") or {}
209+
feedback = contexts.get("feedback") or {}
210210
feedback_msg = feedback.get("message")
211211
logger.info(
212212
"Filtered missing context or message.",
213213
extra={
214214
"project_id": project_id,
215215
"organization_id": project.organization_id,
216-
"has_contexts": contexts != {},
217-
"has_feedback": feedback != {},
216+
"has_contexts": bool(contexts),
217+
"has_feedback": bool(feedback),
218218
"event_type": event.get("type"),
219219
"feedback_message": feedback_msg,
220220
"platform": project.platform,

0 commit comments

Comments
 (0)
Please sign in to comment.