Skip to content

Commit 74088fe

Browse files
authored
Merge branch 'master' into raj/refactor-slack-metric-alerts
2 parents c33f402 + 2f2caed commit 74088fe

File tree

82 files changed

+1154
-483
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+1154
-483
lines changed

.github/CODEOWNERS

+7-5
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,8 @@ yarn.lock @getsentry/owners-js-de
171171
/static/app/views/alerts/ @getsentry/alerts-notifications
172172
/static/app/views/alerts/rules/uptime @getsentry/crons
173173
/static/app/views/releases/ @getsentry/alerts-notifications
174+
/static/app/views/releases/drawer/ @getsentry/replay-frontend
175+
/static/app/views/releases/releaseBubbles/ @getsentry/replay-frontend
174176
/src/sentry/rules/processing/delayed_processing.py @getsentry/alerts-notifications
175177

176178
/static/app/views/settings/account/notifications/ @getsentry/alerts-notifications
@@ -329,11 +331,11 @@ tests/sentry/api/endpoints/test_organization_dashboard_widget_details.py @ge
329331

330332

331333
## Replays
332-
/static/app/components/replays/ @getsentry/replay-frontend
333-
/static/app/utils/replays/ @getsentry/replay-frontend
334-
/static/app/views/replays/ @getsentry/replay-frontend
335-
/src/sentry/replays/ @getsentry/replay-backend
336-
/tests/sentry/replays/ @getsentry/replay-backend
334+
/static/app/components/replays/ @getsentry/replay-frontend
335+
/static/app/utils/replays/ @getsentry/replay-frontend
336+
/static/app/views/replays/ @getsentry/replay-frontend
337+
/src/sentry/replays/ @getsentry/replay-backend
338+
/tests/sentry/replays/ @getsentry/replay-backend
337339
## End of Replays
338340

339341

devservices/config.yml

+18-6
Original file line numberDiff line numberDiff line change
@@ -60,17 +60,19 @@ x-sentry-service-config:
6060
description: Messaging and streaming broker
6161
memcached:
6262
description: Memcached used for caching
63+
spotlight:
64+
description: Spotlight server for local debugging
6365

6466
modes:
65-
default: [snuba, postgres, relay]
67+
default: [snuba, postgres, relay, spotlight]
6668
migrations: [postgres, redis]
6769
acceptance-ci: [postgres, snuba, chartcuterie]
68-
taskbroker: [snuba, postgres, relay, taskbroker]
70+
taskbroker: [snuba, postgres, relay, taskbroker, spotlight]
6971
backend-ci: [snuba, postgres, redis, bigtable, redis-cluster, symbolicator]
70-
rabbitmq: [postgres, snuba, rabbitmq]
71-
symbolicator: [postgres, snuba, symbolicator]
72-
memcached: [postgres, snuba, memcached]
73-
profiling: [postgres, snuba, vroom]
72+
rabbitmq: [postgres, snuba, rabbitmq, spotlight]
73+
symbolicator: [postgres, snuba, symbolicator, spotlight]
74+
memcached: [postgres, snuba, memcached, spotlight]
75+
profiling: [postgres, snuba, vroom, spotlight]
7476
minimal: [postgres, snuba]
7577
full:
7678
[
@@ -83,6 +85,7 @@ x-sentry-service-config:
8385
taskbroker,
8486
rabbitmq,
8587
vroom,
88+
spotlight,
8689
]
8790

8891
services:
@@ -159,6 +162,15 @@ services:
159162
- devservices
160163
extra_hosts:
161164
- host.docker.internal:host-gateway
165+
spotlight:
166+
image: ghcr.io/getsentry/spotlight:latest
167+
restart: unless-stopped
168+
ports:
169+
- '127.0.0.1:8969:8969/tcp'
170+
networks:
171+
- devservices
172+
labels:
173+
- orchestrator=devservices
162174

163175
networks:
164176
devservices:

requirements-dev-frozen.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ pillow==11.0.0
128128
pip-tools==7.1.0
129129
platformdirs==4.2.0
130130
pluggy==1.5.0
131-
pre-commit==4.0.0
131+
pre-commit==4.2.0
132132
progressbar2==3.41.0
133133
prompt-toolkit==3.0.41
134134
proto-plus==1.25.0

requirements-dev.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ selenium>=4.16.0
2424
sentry-cli>=2.16.0
2525

2626
# pre-commit dependencies
27-
pre-commit>=4
27+
pre-commit>=4.2
2828
black>=24.10.0
2929
flake8>=7
3030
flake8-bugbear>=22.10

src/sentry/api/endpoints/api_tokens.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
from sentry.api.authentication import SessionNoAuthTokenAuthentication
1414
from sentry.api.base import Endpoint, control_silo_endpoint
1515
from sentry.api.exceptions import ResourceDoesNotExist
16-
from sentry.api.fields import MultipleChoiceField
1716
from sentry.api.permissions import SentryIsAuthenticated
1817
from sentry.api.serializers import serialize
1918
from sentry.auth.elevated_mode import has_elevated_mode
@@ -27,7 +26,7 @@
2726

2827
class ApiTokenSerializer(serializers.Serializer):
2928
name = CharField(max_length=255, allow_blank=True, required=False)
30-
scopes = MultipleChoiceField(required=True, choices=settings.SENTRY_SCOPES)
29+
scopes = serializers.MultipleChoiceField(required=True, choices=list(settings.SENTRY_SCOPES))
3130

3231

3332
def get_appropriate_user_id(request: Request) -> int:

0 commit comments

Comments
 (0)