oops

Author: ameliahsu

src/sentry/workflow_engine/endpoints/serializers.py

@@ -148,9 +148,8 @@ def serialize(
         user: Any,
         **kwargs: Any,
     ) -> DataConditionHandlerResponse:
-        if hasattr(kwargs, "condition_type"):
-            condition_type = kwargs["condition_type"]
-        else:
+        condition_type = kwargs.get("condition_type")
+        if condition_type is None:
             raise ValueError("condition_type is required")
         result: DataConditionHandlerResponse = {
             "type": condition_type,

tests/sentry/workflow_engine/endpoints/test_organization_data_condition_index.py

@@ -47,7 +47,7 @@ class TestDetectorTrigger(DataConditionHandler):
             group = DataConditionHandler.Group.DETECTOR_TRIGGER
             comparison_json_schema = {"type": "boolean"}
 
-        # This condition should not be included in the response
+        # This legacy condition should not be included in the response
         @self.registry.register(Condition.EVERY_EVENT)
         @dataclass(frozen=True)
         class TestIgnoredCondition(DataConditionHandler):