Skip to content

Commit 7b8596a

Browse files
authored
ref(replay): Inline some props that are used only once (#72274)
Just inlining some stuff that used to be part of a feature flag.
1 parent 9ae7550 commit 7b8596a

File tree

1 file changed

+18
-22
lines changed
  • static/app/components/events/eventReplay

1 file changed

+18
-22
lines changed

static/app/components/events/eventReplay/index.tsx

+18-22
Original file line numberDiff line numberDiff line change
@@ -78,27 +78,6 @@ function EventReplayContent({
7878
const timeOfEvent = event.dateCreated ?? startTimestampMS ?? event.dateReceived;
7979
const eventTimestampMs = timeOfEvent ? Math.floor(new Date(timeOfEvent).getTime()) : 0;
8080

81-
const commonProps = {
82-
analyticsContext: 'issue_details',
83-
replaySlug: replayId,
84-
orgSlug: organization.slug,
85-
eventTimestampMs,
86-
fullReplayButtonProps: {
87-
analyticsEventKey: 'issue_details.open_replay_details_clicked',
88-
analyticsEventName: 'Issue Details: Open Replay Details Clicked',
89-
analyticsParams: {
90-
...getAnalyticsDataForEvent(event),
91-
...getAnalyticsDataForGroup(group),
92-
organization,
93-
},
94-
},
95-
loadingFallback: (
96-
<StyledNegativeSpaceContainer testId="replay-loading-placeholder">
97-
<LoadingIndicator />
98-
</StyledNegativeSpaceContainer>
99-
),
100-
};
101-
10281
// don't try to construct the url if we don't have a group
10382
const eventIdFromRouter = router.params.eventId;
10483
const baseUrl = group
@@ -138,7 +117,24 @@ function EventReplayContent({
138117
<ReplayGroupContextProvider groupId={group?.id} eventId={event.id}>
139118
<ReactLazyLoad debounce={50} height={448} offset={0} once>
140119
<LazyLoad
141-
{...commonProps}
120+
analyticsContext="issue_details"
121+
replaySlug={replayId}
122+
orgSlug={organization.slug}
123+
eventTimestampMs={eventTimestampMs}
124+
fullReplayButtonProps={{
125+
analyticsEventKey: 'issue_details.open_replay_details_clicked',
126+
analyticsEventName: 'Issue Details: Open Replay Details Clicked',
127+
analyticsParams: {
128+
...getAnalyticsDataForEvent(event),
129+
...getAnalyticsDataForGroup(group),
130+
organization,
131+
},
132+
}}
133+
loadingFallback={
134+
<StyledNegativeSpaceContainer testId="replay-loading-placeholder">
135+
<LoadingIndicator />
136+
</StyledNegativeSpaceContainer>
137+
}
142138
LazyComponent={ReplayClipPreview}
143139
clipOffsets={REPLAY_CLIP_OFFSETS}
144140
overlayContent={overlayContent}

0 commit comments

Comments
 (0)