chore: Tidy up node & config files including excepting them from import/no-nodejs-modules (#83691)

Author: ryan953

.github/workflows/scripts/deploy.js

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 /**
  * GHA Workflow helpers for deploys
  *

.github/workflows/scripts/getsentry-dispatch.js

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 /**
  * List of workflows to dispatch to `getsentry`
  *

api-docs/index.ts

@@ -1,27 +1,26 @@
-/* global process */
-/* eslint-env node */
-/* eslint import/no-unresolved:0 */
 import yaml from 'js-yaml';
 import JsonRefs from 'json-refs';
 import fs from 'node:fs';
 import path from 'node:path';
 
 function dictToString(dict) {
-  const res = [];
+  const res: string[] = [];
   for (const [k, v] of Object.entries(dict)) {
     res.push(`${k}: ${v}`);
   }
   return res.join('\n');
 }
 
 function bundle(originalFile) {
+  // @ts-expect-error: Types do not match the version of js-yaml installed
   const root = yaml.safeLoad(fs.readFileSync(originalFile, 'utf8'));
   const options = {
     filter: ['relative', 'remote', 'local'],
     resolveCirculars: true,
     location: originalFile,
     loaderOptions: {
       processContent: function (res, callback) {
+        // @ts-expect-error: Types do not match the version of js-yaml installed
         callback(undefined, yaml.safeLoad(res.text));
       },
     },

api-docs/openapi-diff.ts

@@ -1,6 +1,3 @@
-/* eslint-env node */
-/* eslint import/no-unresolved:0 */
-
 import yaml from 'js-yaml';
 import jsonDiff from 'json-diff';
 import fs from 'node:fs';
@@ -26,6 +23,7 @@ async function main() {
   );
 
   const readFile = fs.readFileSync('tests/apidocs/openapi-derefed.json', 'utf8');
+  // @ts-expect-error: Types do not match the version of js-yaml installed
   const target = yaml.safeLoad(readFile);
 
   // eslint-disable-next-line no-console

api-docs/watch.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-/* eslint import/no-unresolved:0, no-console:0 */
 import {spawn} from 'node:child_process';
 import {join} from 'node:path';
 import {stderr, stdout} from 'node:process';

babel.config.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 import type {TransformOptions} from '@babel/core';
 
 const config: TransformOptions = {

build-utils/last-built-plugin.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 import fs from 'node:fs';
 import path from 'node:path';
 import type webpack from 'webpack';

build-utils/sentry-instrumentation.ts

@@ -1,4 +1,3 @@
-/* eslint-env node */
 import type {Span} from '@sentry/core';
 import type * as Sentry from '@sentry/node';
 import crypto from 'node:crypto';

config/webpack.chartcuterie.config.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 import childProcess from 'node:child_process';
 import path from 'node:path';
 import webpack from 'webpack';

eslint.config.mjs

@@ -307,6 +307,7 @@ export default typescript.config([
       'import/no-anonymous-default-export': 'error',
       'import/no-duplicates': 'error',
       'import/no-named-default': 'error',
+      'import/no-nodejs-modules': 'error',
       'import/no-webpack-loader-syntax': 'error',
 
       // https://github.com/import-js/eslint-plugin-import/blob/main/config/recommended.js
@@ -597,13 +598,17 @@ export default typescript.config([
   },
   {
     name: 'files/*.config.*',
-    files: ['*.config.*'],
+    files: ['**/*.config.*'],
     languageOptions: {
       globals: {
         ...globals.commonjs,
         ...globals.node,
       },
     },
+
+    rules: {
+      'import/no-nodejs-modules': 'off',
+    },
   },
   {
     name: 'files/scripts',
@@ -617,6 +622,8 @@ export default typescript.config([
     },
     rules: {
       'no-console': 'off',
+
+      'import/no-nodejs-modules': 'off',
     },
   },
   {
@@ -625,15 +632,19 @@ export default typescript.config([
       'tests/js/jest-pegjs-transform.js',
       'tests/js/sentry-test/echartsMock.js',
       'tests/js/sentry-test/importStyleMock.js',
+      'tests/js/sentry-test/loadFixtures.ts',
       'tests/js/sentry-test/svgMock.js',
+      'tests/js/setup.ts',
     ],
     languageOptions: {
       sourceType: 'commonjs',
       globals: {
         ...globals.commonjs,
       },
     },
-    rules: {},
+    rules: {
+      'import/no-nodejs-modules': 'off',
+    },
   },
   {
     name: 'files/devtoolbar',

jest.config.ts

@@ -1,4 +1,3 @@
-/* eslint-env node */
 import type {Config} from '@jest/types';
 import path from 'node:path';
 import process from 'node:process';

stylelint.config.js

@@ -1,4 +1,3 @@
-/* eslint-env node */
 module.exports = {
   customSyntax: 'postcss-styled-syntax',
   extends: ['stylelint-config-recommended'],

tests/js/sentry-test/loadFixtures.ts

@@ -1,4 +1,5 @@
-/* global __dirname */
+'use strict';
+
 import fs from 'node:fs';
 import path from 'node:path';
 

tests/js/setup.ts

@@ -1,6 +1,6 @@
+'use strict';
 import '@testing-library/jest-dom';
 
-/* eslint-env node */
 import type {ReactElement} from 'react';
 import {configure as configureRtl} from '@testing-library/react'; // eslint-disable-line no-restricted-imports
 import {enableFetchMocks} from 'jest-fetch-mock';

webpack.config.ts

@@ -1,5 +1,3 @@
-/* eslint-env node */
-
 import {WebpackReactSourcemapsPlugin} from '@acemarke/react-prod-sourcemaps';
 import {RsdoctorWebpackPlugin} from '@rsdoctor/webpack-plugin';
 import {sentryWebpackPlugin} from '@sentry/webpack-plugin';