Skip to content

Commit a3e3a19

Browse files
committed
fix weird _in_app_changed logic
1 parent aa2ceea commit a3e3a19

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/sentry/grouping/enhancer/actions.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,15 @@ def _slice_to_range(self, seq, idx):
106106
return seq[idx + 1 :]
107107
return []
108108

109-
def _in_app_changed(self, frame: dict[str, Any], component) -> bool:
109+
def _in_app_changed(self, frame: dict[str, Any]) -> bool:
110110
orig_in_app = get_path(frame, "data", "orig_in_app")
111111

112112
if orig_in_app is not None:
113113
if orig_in_app == -1:
114114
orig_in_app = None
115115
return orig_in_app != frame.get("in_app")
116116
else:
117-
# FIXME: I don't fully understand this. The `group` Action is the only
118-
# one I can find that actually sets the `contributes` flag to `True`.
119-
# And `orig_in_app` is only `None` if the `app` Action was never applied.
120-
return self.flag == component.contributes
117+
return False
121118

122119
def apply_modifications_to_frame(
123120
self,
@@ -148,7 +145,7 @@ def update_frame_components_contributions(
148145
)
149146
# The in app flag was set by `apply_modifications_to_frame`
150147
# but we want to add a hint if there is none yet.
151-
elif self.key == "app" and self._in_app_changed(frame, component):
148+
elif self.key == "app" and self._in_app_changed(frame):
152149
component.update(
153150
hint="marked {} by {}".format(self.flag and "in-app" or "out of app", rule_hint)
154151
)

0 commit comments

Comments
 (0)