Skip to content

Commit b0971be

Browse files
ref: add tests for invalid datetime range (#87358)
I initially thought these were unreachable and had factored out the `try:` / `except:` here -- but found an edge case so this adds test coverage for it <!-- Describe your PR here. -->
1 parent 7a9bb9d commit b0971be

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

tests/sentry/api/test_event_search.py

+12
Original file line numberDiff line numberDiff line change
@@ -508,6 +508,12 @@ def test_rel_time_filter(self):
508508
SearchFilter(key=SearchKey(name="random"), operator="=", value=SearchValue("-2w"))
509509
]
510510

511+
def test_invalid_rel_time_filter(self):
512+
with pytest.raises(InvalidSearchQuery) as excinfo:
513+
parse_search_query(f'time:+{"1" * 9999}d')
514+
(msg,) = excinfo.value.args
515+
assert msg.endswith(" is not a valid datetime query")
516+
511517
def test_aggregate_rel_time_filter(self):
512518
now = timezone.now()
513519
with freeze_time(now):
@@ -529,6 +535,12 @@ def test_aggregate_rel_time_filter(self):
529535
SearchFilter(key=SearchKey(name="random()"), operator="=", value=SearchValue("-2w"))
530536
]
531537

538+
def test_invalid_aggregate_rel_time_filter(self):
539+
with pytest.raises(InvalidSearchQuery) as excinfo:
540+
parse_search_query(f'last_seen():+{"1" * 9999}d')
541+
(msg,) = excinfo.value.args
542+
assert msg.endswith(" is not a valid datetime query")
543+
532544
def test_invalid_date_filter(self):
533545
with pytest.raises(InvalidSearchQuery) as excinfo:
534546
parse_search_query("time:>0000-00-00")

0 commit comments

Comments
 (0)